From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E06EA034C; Sat, 26 Feb 2022 01:57:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 010DF4068F; Sat, 26 Feb 2022 01:57:40 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2089.outbound.protection.outlook.com [40.107.244.89]) by mails.dpdk.org (Postfix) with ESMTP id 9829940687 for ; Sat, 26 Feb 2022 01:57:38 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KpZ+STIpSDwkUiplsCol7In3QuC2gyvQwaUuS04Zw8oePsc3orgp1XSNzy6CxSgHJCevGevOQGOIXGweSLoBnpx0REl9mDWIhwDi0XRIfDiqdPL2vQpwiNOMWwnTi0NLHNhSvtWRWGQrJ9Nwuged7rDIeWVtgARWKJCe7qcww5Zyf5ygE3ZDgdOHTXkMNoeI5MQbQAZUeP4oY1ZBlz8MkstLMCbccfdld1RRFiS5NLZu408uoLCkmrDkk1V+OBQr3xkyGsOGOvXOAhvxxHipcsR7kFhAufa3Qf5W0cTIHP/+hDm1Vl7TqjSWQ/w1JoqDj6rpDq48iLrbVt2wqDFLtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0xZDU5yO8Lr4b8e1B7ap1LZUTkqFEnEFBAazAJG+MAA=; b=fTJhm6O4GQAPPE4mZHOp8OF7UQ3h36s8FsDFAyGvrt97d4T8inPa1GEynvGPVyg+L7W6ERejQUAtchWqIZQlfAvLdwe0TW9LQSj3LglAJTt3RoqIQhogsRISBp7w97AN4duxpQumjJ6jp3LnZ9yrbCC/D3BHB7whN3GScEZmbPU5Ch6VUlHasID5uCe0KEXrsAbo38AnZerKLgIMy327VrqiMTKRFBf9uvCKivPA8WxFG1EzInva/Sj/Rd4Hyix557U8/GwDsGIq8gj5YbXfKfJYE1GbHy9fDWaytIAJzsdbUd64IgtnhmtF4xczrRDmR83M/YoKmBtQq36vq8Pvmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0xZDU5yO8Lr4b8e1B7ap1LZUTkqFEnEFBAazAJG+MAA=; b=EmK4Ssk+MZ5OGIaC5nbjv3+RuNnRt5SuGudYMBHTkx/wRXY/bnee8C5a/eNn28F0agJO39kpe93KnaTvKKvaxlkNzBlT+U5cFgCw/5qTiQyrAiyCwEH1uevmgrjVFrb0bVVHlpIg/jrZ/dkUz1oj0lpmvk6oiVGh7aOdsasZv/8xy+5rAdTItO4WP3q1qVqFua0JjDm9HSUQifC1JGuF/AF+HBBWKqncenHfpg+hjIg+U+lHCQ19ACsW3KtlDH0zTznR5aJ8WR0Cxg434b6/d3BM2VxG9ivh2SVnzFBhYtnu4pZ0iOd5FQx/RWhcopN4m8BEn+O/12EszIC2ddRjig== Received: from DM8PR12MB5398.namprd12.prod.outlook.com (2603:10b6:8:3f::5) by BN9PR12MB5164.namprd12.prod.outlook.com (2603:10b6:408:11d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Sat, 26 Feb 2022 00:57:35 +0000 Received: from DM8PR12MB5398.namprd12.prod.outlook.com ([fe80::a1b6:485c:5b95:94e2]) by DM8PR12MB5398.namprd12.prod.outlook.com ([fe80::a1b6:485c:5b95:94e2%7]) with mapi id 15.20.5017.026; Sat, 26 Feb 2022 00:57:35 +0000 From: "Sean Zhang (Networking SW)" To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" CC: Matan Azrad , Slava Ovsiienko , "dev@dpdk.org" , Asaf Penso Subject: RE: [PATCH] net/mlx5: support matching optional fields of GRE Thread-Topic: [PATCH] net/mlx5: support matching optional fields of GRE Thread-Index: AQHYI8d1eZQ6KiLld0GWk6I8H35WOqyXaqAAgAXpg+CABx3qgIAAnfyw Date: Sat, 26 Feb 2022 00:57:35 +0000 Message-ID: References: <20220211014530.77711-5-xiazhang@nvidia.com> <1972215.kUgFBCI4xA@thomas> <8946654.rMLUfLXkoz@thomas> In-Reply-To: <8946654.rMLUfLXkoz@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9df25645-a26a-4940-0031-08d9f8c2fa73 x-ms-traffictypediagnostic: BN9PR12MB5164:EE_ x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fz+ZFa+ESfAEXTKF7gkDj+hfQscK3WdGXOTU1gc4DCssNlngV4QMko0Upg32QNvfWFOsn3cEgKLFxmlpfucDwjBcU8uckZ/CvzfAe0AGJhqgj4VHjj2Re/O/abM9hrucA+OiHK+tU2cLENIbZSB8eILPOYYRRT8J1ryyDDBVmHuyF4rmuzqubg4epGrHvL+v3tVznFMmxBOpWldYiBLE1S3M8AM7kiFxJwJKrcLbnAvvl6AgCck5maPXmgDHNv5CFHrolL2k9spmAId3S8YVjpwnbw/vrsB3M3dupUCC33CFR4IfaWlYXa8B5RmWD31HkKTsj5e+n2k4X4FZiXIRDOdl/BOEfg2DRrjyypZQeXtmcRAdqF1OuGa79wu62Vh5yc5waTeoz1nSySfIu2skh4dkKvR7y6Izzrr7uH8tgr4pUJRFkUerBvBYCwrjxpdp2tfDFIqWQTt+qnF5ZqGyUyIUbbOu0KUMOWqn8fv6c69/zJZkBZLkFX2XbGViBBhjH41aFqk9nHSpWmQEtPQR7kZIpGM20cHv9y1I04lWMnZVlC/l8pl7pNQvNvaM60iY+l7UYbZajYlzow4r88k0+14iUFgypF5Ckgar4QJsYRQder27oFUKtm0Vahn/C+bhCVKRKGOefyunkZqU1pDmaSVAQ1MjO/XFCPGReAqYNprafViGPoke+l8cxtKIei+6h6ipTQmEfcUt662lKmJ7TC7KJpnUORQWtKSRQ27IXLgNwyEW0wzUKBPFoF5V6UnXD2wx82ApBevJ37SX4IJfxD501mOvdd3erXc3U/RFJ7k= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR12MB5398.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(9686003)(86362001)(508600001)(2906002)(966005)(71200400001)(38070700005)(6506007)(53546011)(7696005)(55016003)(38100700002)(8936002)(5660300002)(4326008)(8676002)(64756008)(122000001)(66446008)(83380400001)(66476007)(52536014)(66946007)(66556008)(76116006)(107886003)(6916009)(316002)(54906003)(33656002)(26005)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XpSY1kVoR3Aa663Yj4W3WuhK8z6NjdAXuicJQncSnmRH1QyVr+otXnvcbjxg?= =?us-ascii?Q?vogWz5E4rkEWn3ViJ6VnjXWBu4q/X4zCRcMK3a0chFXvdyV8jdvEoYaQGD9/?= =?us-ascii?Q?6pWQR9IjUTqKiSSTglLDCDOBfPtrPe3JK8vR4LzNqPmxRm1CPjEu6Pxoq7tG?= =?us-ascii?Q?hpJ0KFyA8CJOP9VZW7fVaht7nmNhSOwMe8Nl64BEeseu8+uVYMXp+hD7nscT?= =?us-ascii?Q?XF8FJrOvmLklP0QZK51HMuIrVa+9Ixc4cbFmC2h50ii/BswwSHtL6yCERScC?= =?us-ascii?Q?5FtRIoISFsrhKPV2PoU6k0hx+DObTYSI2Ng6i1WzcH3q+HFza7hjRdDO7hvU?= =?us-ascii?Q?6S8MCqYayjYncEUtQdkwmXtNGw7+D1XYUI3OZz1V/efFAPCobiXlts4VEjzC?= =?us-ascii?Q?S0Oi54/ak4cmDEoxRI6YGHwNoAOvmVLNaJu7Urkwa/BrsP7Yozw0I/mKD7f2?= =?us-ascii?Q?ihGsvh/50dVzdnYCtwTS52inRZLtnmmX3/TO75oFTBMXsW0eSlyKJEq8b4gD?= =?us-ascii?Q?PMdx8gzUKWPGmmjtde0cFWf+sLFl4C4UzblTgbxoqC/hWtqYCuKKebqwle1/?= =?us-ascii?Q?F0sNlqCw3xtPVooDPwpLXjgRd9QlFz8GFoj9Q74J7/sDEQvKngrsxEVOvnKW?= =?us-ascii?Q?ClojP369cFg9SMo2y16CGFYDAG/brIwali7Nlo5iu52IVvYCHvN+vXDBfM9+?= =?us-ascii?Q?sfVINogZn3Wo2heSDR152F0j/Yb5g/WdRmofYEyOSnuX5Hk7usYda2kuhZHB?= =?us-ascii?Q?z/LXnCFT/AEz9Uz4U+UFjYIpc5Bmu3XDIBVxfLKfacsx04IHNPkItOPcqDiS?= =?us-ascii?Q?qYLACThfGStxEdzUUmjuB7MT09uAST9Fny5/nm2W4nQdlyYbCadQDC3VVBV8?= =?us-ascii?Q?hJWEMbaNCFPdkvHh0qvKQcOk62+doTkl8kysCZbpYODkeP9tvl0qmH8N4WKv?= =?us-ascii?Q?s119fjudEmgdjT5jnESBYPgOjSEfwnob6TXcSBCIQ3YU8gd5qpy7n6LzJSxl?= =?us-ascii?Q?/I7pXMWPvdJfXR1riPdLQ3tnZfetO1b8hZKWPgZ8W9NveP+rIKKkzXSgzyxF?= =?us-ascii?Q?RN8NW+OXZGTrJId4rpF+5mjjHnEDwoz/p5lRGFHLKfeB7ga2nYs/zCwdt6oV?= =?us-ascii?Q?A6H9X7lLXJbWVKFcqHT5QcQ6H7LDia5TJcyxoOuAxqathejwRupaLs+oDNcJ?= =?us-ascii?Q?BBF+hF9PaBL/eQUhSGRjPmtbVztCcXWBn3zyyivbXOYp2wWyjZ3/5fnuyZU7?= =?us-ascii?Q?Ke8ZTxO6gbdQXP/8RoBydQgYLjVytdyYCG1JYDv4xZRQoE/vsoEGS5br5ww7?= =?us-ascii?Q?B72vzEmq3P9IIiGE/50EtEahCbb8yL+7AtOs9NU4uD0B+9HcOrExe+Qp/62p?= =?us-ascii?Q?N83XhJGJGtT6bkqUoAN56MrSJCpjkNt5xJNELNzuWPr+Dp8wZ1wMi/FQqtWb?= =?us-ascii?Q?iqoYcMpMuoJE6iOILT+nUL5e6GRxf0CCQb41xaMLM4eyRP/0NcMrfxDnppF2?= =?us-ascii?Q?8P0z5EOit+8aMIFgcKVjMPUKAcckGstVJ8Bppad1RtXPwdQWxL5DDk2vBcxy?= =?us-ascii?Q?C6Tt1J6qYk9Ep4x7h9Iv6epR0xYYDV1zZrJ52w59sa/piUC24Ibyfk/4ehm7?= =?us-ascii?Q?Gg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5398.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9df25645-a26a-4940-0031-08d9f8c2fa73 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2022 00:57:35.8195 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: q1DAoyU5eYRwmtUCOJChpjYw50HNNGeiAMSZd1aovWA8oXVLkG5bxMAkAwNYgl5MWMJHbkoryj3vOXY1J/pOug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5164 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thanks Thomas. > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, February 25, 2022 11:32 PM > To: Sean Zhang (Networking SW) > Cc: Matan Azrad ; Slava Ovsiienko > ; dev@dpdk.org; Asaf Penso > Subject: Re: [PATCH] net/mlx5: support matching optional fields of GRE >=20 > External email: Use caution opening links or attachments >=20 >=20 > 21/02/2022 04:00, Sean Zhang (Networking SW): > > Hi Thomas, > > > > > -----Original Message----- > > > From: Thomas Monjalon > > > Sent: Thursday, February 17, 2022 4:34 PM > > > To: Matan Azrad ; Slava Ovsiienko > > > ; Sean Zhang (Networking SW) > > > > > > Cc: dev@dpdk.org > > > Subject: Re: [PATCH] net/mlx5: support matching optional fields of > > > GRE > > > > > > External email: Use caution opening links or attachments > > > > > > > > > 17/02/2022 07:27, Sean Zhang: > > > > This patch adds matching on the optional fields > > > > (checksum/key/sequence) of GRE header. The matching on checksum > > > > and sequence fields requests support from rdma-core with the > > > > capability of > > > misc5 and tunnel_header 0-3. > > > > > > > > For patterns without checksum and sequence specified, keep using > > > > misc for matching as before, but for patterns with checksum or > > > > sequence, validate capability first and then use misc5 for the matc= hing. > > > > > > > > Signed-off-by: Sean Zhang > > > > Acked-by: Slava Ovsiienko > > > > > > > > --- > > > > v3 - some code style change > > > > v2 - replace default mask with nic mask > > > > --- > > > > doc/guides/nics/mlx5.rst | 10 +++ > > > > drivers/common/mlx5/mlx5_devx_cmds.c | 3 + > > > > drivers/net/mlx5/linux/mlx5_os.c | 2 + > > > > drivers/net/mlx5/mlx5.h | 1 + > > > > drivers/net/mlx5/mlx5_flow.c | 101 > > > +++++++++++++++++++++++++++++ > > > > drivers/net/mlx5/mlx5_flow.h | 6 ++ > > > > drivers/net/mlx5/mlx5_flow_dv.c | 121 > > > +++++++++++++++++++++++++++++++++++ > > > > 7 files changed, 244 insertions(+) > > > > > > Should we add a line in the release notes? > > > > > > > This patch is v3 of the forth patch of patch set: > > https://patches.dpdk.org/project/dpdk/cover/20220211014530.77711-1-xia > > zhang@nvidia.com/ The release notes changed in the second patch of the > > patch set and applied in v2. > > > > --- a/doc/guides/rel_notes/release_22_03.rst > > +++ b/doc/guides/rel_notes/release_22_03.rst > > @@ -87,6 +87,11 @@ New Features > > > > The new API ``rte_event_eth_rx_adapter_event_port_get()`` was added. > > > > +* **Added rte_flow support for matching GRE optional fields.** > > + > > + * Added ``gre_option`` item in rte_flow to support > checksum/key/sequence > > + matching in GRE packets. > > + >=20 > OK but it is missing a line for mlx5 features. > I'm adding it while merging. >=20 >=20