From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9A74A034E; Mon, 21 Feb 2022 04:00:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FA3E4068C; Mon, 21 Feb 2022 04:00:39 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2087.outbound.protection.outlook.com [40.107.92.87]) by mails.dpdk.org (Postfix) with ESMTP id 66E5D40395 for ; Mon, 21 Feb 2022 04:00:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kyB/pQEYQVxUzP58Pb35Zltw6yWojK9JYJ0yDVE/s0Z/HfzR72QzQ6IZ81MXwvVPNZe1lrZSc+aqQjKLw29pGW4FFIL4BARwI7XGQyfciSN9263TNg4encmb9PPg8jb/e4RLqK61zoQDbDUir/rtsSYH1T5Yznhf0vXYYnqPVOLOM/oyzy/WM0HYplTcB0VBJam1Vg+mgHkFVBb111tTooTC4jWGzIt/k7FWHRce1uK1JrZprqeMJFxoWxWLYrAQ08w+fQP0si0trys5Yg0pdyNGW5D9oQjAU0EHw3m4USkNuecxVhrOdqvhQk69S+P9w/uyTY9FkmxA3bYtDrODIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z5PcVpcKiuuLW+SNFmxSDSMGlIdP+AHqwoRw+wXYonA=; b=druSt0wDhRn9VjhW6hC7nkPr9aXboDDwCo9tbx4LeMGWuKNrqwNqkp04FjD+S3+1m3kpmo/uUdBnZJQq197ggx7vrTyFvzeOENJJK9fnivM0xiH/7ejwLSFZzKE/rLeU62iJUOCx5kU5sa/e8ZtFSmfN3+XT/KEwUKtJV7Z5+svPkVwdgn1QczQH59lKNvTMwl/e8IwJBCxXSLfJXByn4D5WSduTTc82TDmuM6/8MHkewizPpZMcMP34ySSMy4Zixjgv6MffL4piAlLWYSDZDOSidFM7OEqeRJFQFWOzdxFZYHdQtYaGF4cVesqeJk6fIvW0BMRQoTaUnyP6yVQDRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z5PcVpcKiuuLW+SNFmxSDSMGlIdP+AHqwoRw+wXYonA=; b=UDnVHV0OOzwNqxsYRuNQdpIPjV3bzw+pw6DLWM2wwJZsdYCPyxmTCSbU91GBTdoyXwtSTQ3Jj0Y41R3MK0yNhcRSG8U/4CW5KxK8zeIfler8UspdWz8hYqx7vgGAph7MLatAoRaCpBAYIjIayfpYv9A9Pde8zPoXtUT8b8LdyLE9MF2q//E2D/LxycJbcLLeNt9RyAzdeK3mwNQG50ZawCCHcZ7uDR5oc3myFkZ+wpCZ+fTM+y7hD4f5NnHpY8r7QHHA4wTKxx6174fuL+wuwhf/HuaUb+XVTsmpomJSNEiZsm5RQljzQmEQDm+5MoxqRZTnJ4Ktg64gXDKz0ZFjgQ== Received: from DM8PR12MB5398.namprd12.prod.outlook.com (2603:10b6:8:3f::5) by DM6PR12MB2828.namprd12.prod.outlook.com (2603:10b6:5:77::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Mon, 21 Feb 2022 03:00:31 +0000 Received: from DM8PR12MB5398.namprd12.prod.outlook.com ([fe80::a1b6:485c:5b95:94e2]) by DM8PR12MB5398.namprd12.prod.outlook.com ([fe80::a1b6:485c:5b95:94e2%8]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022 03:00:31 +0000 From: "Sean Zhang (Networking SW)" To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" Subject: RE: [PATCH] net/mlx5: support matching optional fields of GRE Thread-Topic: [PATCH] net/mlx5: support matching optional fields of GRE Thread-Index: AQHYI8d1eZQ6KiLld0GWk6I8H35WOqyXaqAAgAXpg+A= Date: Mon, 21 Feb 2022 03:00:31 +0000 Message-ID: References: <20220211014530.77711-5-xiazhang@nvidia.com> <20220217062707.51619-1-xiazhang@nvidia.com> <1972215.kUgFBCI4xA@thomas> In-Reply-To: <1972215.kUgFBCI4xA@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c899f39d-c3be-4809-6c33-08d9f4e652cb x-ms-traffictypediagnostic: DM6PR12MB2828:EE_ x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: msQqLFxRzqk4wcRTD5vOziFqb6FkoR2Hr2FidQ5aNmLM/XN7QKMsSfCEOxpULwLuGNv5w1gUoOyKAmfnOwfKr4xN5FAYBKKysGJcC2QBm3qunZrtD1FJIS4U3EiC4WGrE+ObTHLx2TGIMtvyS3bH5N0H51zkYsCrg6wm85WCB00BRB+YG448jUgUQg/Rq64SZrkdnNKruyD616Wij8QyUrg+mKgPuIx9AixSXOpHVk05BUN7+lC6J1gPGPUDinWLPCyBjX4n3EoZLsaoOnrj2KfyWMqjkVD+PkumJWHuJHrvJ++zRqAidGCZ6IHanzq9xHdEOUAXEUSluVo/IzAL2V4kAyWhAb11tFMEp+Z0wCKkhKIF4P5Nv7paZu1VsY36FNzVVynMlgIW51u6gUzXCVXxznHDo7iZclKxaatRtId+k2up4i7VEEQATIAujLaE50bJc8igYHbOtCNGV46HT1mF01FxAVWslHa1XNHzKyNpQVJic/uqawai12M3QeqdMLhCN6tIj+FC87abBmaP+wasFec3E92WGDU7c7wwAYXVEPqnkV2Dp8lm8T7dyKwjJrBaJ4+uH384K3hWVLTVD6OUX+LeHxdxnrmcsJZ/FNonHUcejwunWYwAH5xvTmp7C26ZxXsfhoaqrMKB5oTwPEP4Op/2P2++vt/uLLb3bVOer29YoarsBocdliJ1UyeMPqov3mhSRpL59hC145Czm+VsrG8ybVCpMunVcRq/FzcBsNXD5yyuMK/qJuHDERTwEOwBhq/nkMD4H6sKyz20y2zyC2Jbig8xlSY80H9c11w= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR12MB5398.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6506007)(7696005)(71200400001)(55016003)(508600001)(966005)(38070700005)(53546011)(33656002)(9686003)(2906002)(38100700002)(5660300002)(186003)(6636002)(52536014)(110136005)(8936002)(26005)(316002)(122000001)(86362001)(76116006)(83380400001)(66946007)(66556008)(66476007)(66446008)(64756008)(4326008)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wF35GlcJo3Izp+7lwaDqyKWgspWEGOd751qpg2VSCcgqM5aXkKlQwBckxjS4?= =?us-ascii?Q?RVPdEhgz8fKghzyu2dNPYtiE+hkbxARP+SntBoRsIK4Ss9eAgTZZR+NBTE24?= =?us-ascii?Q?nFO/mG01LzEoMvr1UMmT+E/5SjucWTtll/2qbyWF9zrNuW3Nau4oI0xLORIA?= =?us-ascii?Q?ucZYUBAtUIOjL4qJJJ2JwYurVYg695210B+OgpS4+2E275bwEVTvXt5AJUcz?= =?us-ascii?Q?OiEfN4dJOwt/TvfL0zgOxcE9Qf250iOThBRqWxm0OawEb9Px9+1Ft+4X95gf?= =?us-ascii?Q?4OPI6qim9msti+pfqa25/z5asf3/wvkH3bsIIe7GXWBb/BDHLFA1rPy44IB2?= =?us-ascii?Q?XbGsTjEGe7z2bnRwDm10peKts8FM66uTFOPx8YMtt++SuQ+tZ89vGjBVhl+a?= =?us-ascii?Q?gSSvrEoD8kiwKjpVmSBsLavignelIYAQHW2o40xP2ez1TC5NGM0IZ5zQdMh2?= =?us-ascii?Q?YGXSA5cjX6LViWdy9RHD+PW7Yvh5Jqz0pAswGtttFDfwRA7BLm2pH04e+v6Y?= =?us-ascii?Q?KXtcHFsZtz7WRPkKmSJ/Dg6mGz1juRFRhDvH+H/53HO0cotOlfte2vz8Na6C?= =?us-ascii?Q?D7AhkkviOeOwJgne2bnPGnzm3743+ivGAyqOmXCwLWJXqpuU6q0FogFfMaPF?= =?us-ascii?Q?y0A/GLPYJjw5sMQcGkTa+RIVGhEF6p0tLf2RSeyOcP6aM382AGvPLkraSyI+?= =?us-ascii?Q?CGsakYXRKo012rY1F+N+Ic+bDoxwTLPhBEN+Oe8EL+rr+bmUixg11EtJJNaK?= =?us-ascii?Q?aNvoMrDLcAsY/uZ/rlrh5XepbjxJuH5Vy/rsY10SjPwc3yLdV7EIl0WxJe5c?= =?us-ascii?Q?Xk6SvaApCl/A1UIkQMr6IpanKIJN3idd8vs3uqgJ8uhaLAYhjg4z0QAtA0/+?= =?us-ascii?Q?FOQ5Wy6FTHRNIuvEpO3vmhNr03nFp9UPhFA61eFXGVhuvZdWDvHtx0KLmONP?= =?us-ascii?Q?O7tAJQmVLUV8qmbnPF6rckuwvZOPdLP+LPWgjFBtHOTt1aUy6eKCijKXbp0U?= =?us-ascii?Q?829n6PfYUEZVLqTLb1aomQ5J8pfnbHhQnOpTFCJglunVDV3VuQK+dIZuYvTL?= =?us-ascii?Q?LBwO7HsZLNnZLwSuyJeqroQfLfwpRDnd3UHxsZDGdE47fOa8E6/f1Q5Fd/tD?= =?us-ascii?Q?tLyqJXT3HQKd+Gc7Ct/SlOhRgNsCvlXcIOrKvv68ggPLThfQ9m7X7/7EQZqP?= =?us-ascii?Q?FHRDcyO0uCKYjGZ0vjtlvJ+zFEPXUHqWub8JoDRbxCOUbrefxzdTkUXnIlt6?= =?us-ascii?Q?VMCLgeztr9Ti3uN8RP08aKt3WpW8bZf0emXMssTjggynUp17pI29hbFVpHcA?= =?us-ascii?Q?DmOd763/V4sAe+XYOkc+0ON2X0A2O/2YVXzoYEJfHz9fjslhxLEUSCAbYhcS?= =?us-ascii?Q?k1AK1Pb8Bz+tsEY4c2I4eEmFehMVjIlGDfPPTjyW8Hpx46Pw0ARevqflk2HS?= =?us-ascii?Q?SrErx7FQamFi0LHvhW+lEbHwrEGtk9YxgHKOKmKEIGQFmBnGAuLjAuM+FMNK?= =?us-ascii?Q?TJt+Sf/R3r+luxh6zrUbNz6XVGebHMSVVpx4CyGHWPtwkO7YXmE5OX/Vg8Dr?= =?us-ascii?Q?Kifs8EH7c9XEmlb7N9C0WF5Qiqc4nJ/bxVpiRP5o24cUAmIqCK7lY9cV8HIc?= =?us-ascii?Q?CA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5398.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c899f39d-c3be-4809-6c33-08d9f4e652cb X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2022 03:00:31.7416 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: buuyiWtBiPWSgrdCZ3SvHJ9cDh6KtvuGHuEGnwj6h6Mwz37sW8EsVHedSdHA/MncKYJ5BW1GC9XdBtIJ8X3rqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2828 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, February 17, 2022 4:34 PM > To: Matan Azrad ; Slava Ovsiienko > ; Sean Zhang (Networking SW) > > Cc: dev@dpdk.org > Subject: Re: [PATCH] net/mlx5: support matching optional fields of GRE >=20 > External email: Use caution opening links or attachments >=20 >=20 > 17/02/2022 07:27, Sean Zhang: > > This patch adds matching on the optional fields > > (checksum/key/sequence) of GRE header. The matching on checksum and > > sequence fields requests support from rdma-core with the capability of > misc5 and tunnel_header 0-3. > > > > For patterns without checksum and sequence specified, keep using misc > > for matching as before, but for patterns with checksum or sequence, > > validate capability first and then use misc5 for the matching. > > > > Signed-off-by: Sean Zhang > > Acked-by: Slava Ovsiienko > > > > --- > > v3 - some code style change > > v2 - replace default mask with nic mask > > --- > > doc/guides/nics/mlx5.rst | 10 +++ > > drivers/common/mlx5/mlx5_devx_cmds.c | 3 + > > drivers/net/mlx5/linux/mlx5_os.c | 2 + > > drivers/net/mlx5/mlx5.h | 1 + > > drivers/net/mlx5/mlx5_flow.c | 101 > +++++++++++++++++++++++++++++ > > drivers/net/mlx5/mlx5_flow.h | 6 ++ > > drivers/net/mlx5/mlx5_flow_dv.c | 121 > +++++++++++++++++++++++++++++++++++ > > 7 files changed, 244 insertions(+) >=20 > Should we add a line in the release notes? >=20 This patch is v3 of the forth patch of patch set: https://patches.dpdk.org/= project/dpdk/cover/20220211014530.77711-1-xiazhang@nvidia.com/ The release notes changed in the second patch of the patch set and applied = in v2. --- a/doc/guides/rel_notes/release_22_03.rst +++ b/doc/guides/rel_notes/release_22_03.rst @@ -87,6 +87,11 @@ New Features =20 The new API ``rte_event_eth_rx_adapter_event_port_get()`` was added. =20 +* **Added rte_flow support for matching GRE optional fields.** + + * Added ``gre_option`` item in rte_flow to support checksum/key/sequence + matching in GRE packets. + * **Updated testpmd.** Sorry the subject-prefix missing v3 information. Thanks, Sean