From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFC55A0C43; Wed, 20 Oct 2021 15:49:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5ED6A4118F; Wed, 20 Oct 2021 15:49:17 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2042.outbound.protection.outlook.com [40.107.243.42]) by mails.dpdk.org (Postfix) with ESMTP id 6120140142 for ; Wed, 20 Oct 2021 15:49:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QDG6MSkeX297GrqjoHdGiFQE+4ibVD2id4YlmRAKFFNia+hvnaXn2S64915bjHT5/nABRgUZVmlPlrlZf7wF3sjFs5VoRkVCZgCZlN405M61CbLwZJNUqDSxWEd7qDX1winT+fTrtO7j8QZ2yoXLElbOnLkvgLJfzJVEjZARUOih7+diRlRoIzuFihMxG3InNyAhBLs3GzT1NfKIjy6W1SDlVqFx5fHoFzum3TlZAuavOHxWpWHdnlJbfH92yXDs5/RPTmizQt7dB9up1J7lxEN1DIFfC8dppjKypZ0ZMK7BfWVvxhZ9wppV9vI2NHOuxG3ytpk1ScC1FcoWwvE/KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fJ1R0YI6WMkZNoqGSuQCUeVEPUL7X7gYjIeVEcgRlsA=; b=dCCFh3hNvWU/UwCBCfGL9sT+rzbaGPnEq/3clX4VFnU3aOQTI0OUJqysDosbEDcv17NIMPgjHdlv3lbOVETXiPyBYXHopGXayoX78S+fhzLjagRZTiCzT0+kJy3BC2ocxmJphwKPXzu0KOY0sACQ95pQzkIlUrghAwC2biNTopmYqdphNUt2TBGHKy7NdH62aRTFpkxga1Dfb64aLANSvDT3f8Pq8Kjgj4uenoRPjrEG/nuR6/vYsptsq7S+vIF6ByR6zmhb4WRuo30Z0ku9orYalz5xg0UpF0zaIIQI0oWBxGZJR0EvixLi7hgMop8rV7bN2GxKtOr6b3PBE25KfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fJ1R0YI6WMkZNoqGSuQCUeVEPUL7X7gYjIeVEcgRlsA=; b=ALbI9FldpGv9CuScJBKI1y3KqSjD2G/wqtxXUhUha70wU/Mr/ZNixeoUr4bdLs8MxGxD6IS3ePtF6eIeIRTY2XHC0JD+ACx4jst3A+7vJQljd4YdGcSpkL3Vjmt2qtoNkjoPuTUBrYM0Ft3JJJbaKvqRmL1y+ES8CC5Jb2mxdFR9vHCc1VnU2BAxsj6jRWUPS8igeogP2iOQYHOD7KPOdx0kQ8dv31FMPdNSMIf3urZd4Qr3+2ykDdhhoLTX7mDUZmqJ5qD/evfVtWJ/hemyrKgv2EAd7JXsMfHUvg/cMJl34svrBYnwDH4vN0CL4XQi7oRVgWsA5iv7YOw+ZYD79A== Received: from DM8PR12MB5400.namprd12.prod.outlook.com (2603:10b6:8:3b::12) by DM4PR12MB5072.namprd12.prod.outlook.com (2603:10b6:5:38b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Wed, 20 Oct 2021 13:49:11 +0000 Received: from DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::d03d:1f75:ca20:6a32]) by DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::d03d:1f75:ca20:6a32%6]) with mapi id 15.20.4628.016; Wed, 20 Oct 2021 13:49:11 +0000 From: Ori Kam To: Andrew Rybchenko , Ferruh Yigit , NBU-Contact-Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 06/10] ethdev: fix ID spelling in comments and log messages Thread-Index: AQHXxbC1jRiwaHUm7USWzfYDuCQT2avb5t1Q Date: Wed, 20 Oct 2021 13:49:11 +0000 Message-ID: References: <20211014083704.2542493-1-andrew.rybchenko@oktetlabs.ru> <20211020124727.2829268-1-andrew.rybchenko@oktetlabs.ru> <20211020124727.2829268-7-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20211020124727.2829268-7-andrew.rybchenko@oktetlabs.ru> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f817e292-5458-4bca-4e86-08d993d0659c x-ms-traffictypediagnostic: DM4PR12MB5072: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vmZyUilwZa38tXmDQOMrOkajo+VIXd47YYEF7+/In8xjkZG5a6WToch5SahrUKkIFNsOo9zHszWNJWDNzc1mL9Y4jhxeGvBhHR97+9dYPCaLjZWir/1F5RmlFnXQyGqbdYsBi/KLi2v3iyyKYQPgG3HgpnR6ItGfPOwcDuXxNJR73xtto3cwmpBwziluSX1yKLdDRGtAGivgHK6Vq4Puh7sNRzVpv0vJOpHgNBMFer0B2/DeGGCfFAms3SUm8RdyBwFh8T3vdmoBuksVt9gCg2OdGw4QFjiLtB7LarKyjmYei9OAJ+u+f+34TBN4spF/3unFqSkWLV4A4hxwTTTKGJi1wQU7z4xV12YUpjnBSrxYObs8bpAieFK8cir9biqTjG302eUIJ7VUG123z+iYsB8H10xHtEjDWsQt5duDQ3YCwWWo3VRSL9hc23od2HssmtVYMm0RxQ3nBYxP1fg2k+txV1puhxB271HCK8UVO7Cs7fM3RHJEGPe4D8S6mw17qErIF53nknSytKYZ4EX9nWU7krttkr+g8E+a2JJMYzjCgIOkGwBbNRRsgB5KS2S14BarRslOq2YdsDEBDRsEPx0PA9CBIVu2I/A+J+7GhWBNLty/KcFwF9cXbZYhZm4nCv5DcXteNDfnKT9w6nHPo99XDPvOCyTQhejQjn9L/XqxyuLq1LxzCuUmV/p9EdtnpAfpJ00NamXV+MSGbvJsMw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR12MB5400.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6506007)(53546011)(186003)(7696005)(8936002)(8676002)(71200400001)(86362001)(508600001)(4326008)(55016002)(9686003)(316002)(15650500001)(64756008)(110136005)(66476007)(66946007)(76116006)(5660300002)(33656002)(2906002)(38100700002)(52536014)(83380400001)(30864003)(38070700005)(122000001)(66556008)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: G1XwJhM0kx22kxHDw78Dxj8IOCOhEt9od552C0+SaOJtucwk2SkUrAcL7SIwxCRJu6yqKoT/C25lJIIIGaUQopDLy4slKSoj7tz1HZYquAI5s25iNynn9ZU9lX51Gd7YUJMUbh6vFpKcSSkMjHWm/dbkybccXrJ5qyHA+Wq0KdR/mYMjjK+duoFlAzRHkluj1AtzkznBBIZ/yrIYnyr7/voDwp0KM8ZBFlUplfqkxuHSpttot0VnS03wX7/rWIIIet4c5WqVVU/H48/0NI3gNe1ZUM5RT9eLxsIwDWZBbHn9qlIiOvSBxh/fFDwpoBeLNIzvYYfsz8fSSgf/lNHLlgSeZRE5FiPaHARlz8w6WjI= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5400.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f817e292-5458-4bca-4e86-08d993d0659c X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2021 13:49:11.5833 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: orika@nvidia.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5072 Subject: Re: [dpdk-dev] [PATCH v3 06/10] ethdev: fix ID spelling in comments and log messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Andrew, > -----Original Message----- > From: Andrew Rybchenko > Sent: Wednesday, October 20, 2021 3:47 PM > Subject: [PATCH v3 06/10] ethdev: fix ID spelling in comments and log mes= sages >=20 > Signed-off-by: Andrew Rybchenko > --- > lib/ethdev/ethdev_driver.h | 2 +- > lib/ethdev/ethdev_private.h | 2 +- > lib/ethdev/rte_class_eth.c | 2 +- > lib/ethdev/rte_ethdev.c | 14 ++++----- > lib/ethdev/rte_ethdev.h | 62 ++++++++++++++++++------------------- > lib/ethdev/rte_flow.h | 4 +-- > 6 files changed, 43 insertions(+), 43 deletions(-) >=20 > diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h > index 94878f94fc..6b01ea829d 100644 > --- a/lib/ethdev/ethdev_driver.h > +++ b/lib/ethdev/ethdev_driver.h > @@ -1420,7 +1420,7 @@ rte_eth_linkstatus_get(const struct rte_eth_dev *de= v, > * > * A pool of switch domain identifiers which can be allocated on request= . This > * will enabled devices which support the concept of switch domains to r= equest > - * a switch domain id which is guaranteed to be unique from other device= s > + * a switch domain ID which is guaranteed to be unique from other device= s > * running in the same process. > * > * @param domain_id > diff --git a/lib/ethdev/ethdev_private.h b/lib/ethdev/ethdev_private.h > index 5721be7bdc..cc91025e8d 100644 > --- a/lib/ethdev/ethdev_private.h > +++ b/lib/ethdev/ethdev_private.h > @@ -10,7 +10,7 @@ > #include "rte_ethdev.h" >=20 > /* > - * Convert rte_eth_dev pointer to port id. > + * Convert rte_eth_dev pointer to port ID. > * NULL will be translated to RTE_MAX_ETHPORTS. > */ > uint16_t eth_dev_to_id(const struct rte_eth_dev *dev); > diff --git a/lib/ethdev/rte_class_eth.c b/lib/ethdev/rte_class_eth.c > index eda216ced5..c8e8fc9244 100644 > --- a/lib/ethdev/rte_class_eth.c > +++ b/lib/ethdev/rte_class_eth.c > @@ -90,7 +90,7 @@ eth_representor_cmp(const char *key __rte_unused, > np =3D eth_da.nb_ports > 0 ? eth_da.nb_ports : 1; > nf =3D eth_da.nb_representor_ports > 0 ? eth_da.nb_representor_ports : = 1; >=20 > - /* Return 0 if representor id is matching one of the values. */ > + /* Return 0 if representor ID is matching one of the values. */ > for (i =3D 0; i < nc * np * nf; ++i) { > c =3D i / (np * nf); > p =3D (i / nf) % np; > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > index 9d1793e216..02c2034000 100644 > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -538,7 +538,7 @@ rte_eth_dev_allocate(const char *name) >=20 > /* > * Attach to a port already registered by the primary process, which > - * makes sure that the same device would have the same port id both > + * makes sure that the same device would have the same port ID both > * in the primary and secondary process. > */ > struct rte_eth_dev * > @@ -668,7 +668,7 @@ eth_dev_owner_set(const uint16_t port_id, const uint6= 4_t old_owner_id, > struct rte_eth_dev_owner *port_owner; >=20 > if (port_id >=3D RTE_MAX_ETHPORTS || !eth_dev_is_allocated(ethdev)) { > - RTE_ETHDEV_LOG(ERR, "Port id %"PRIu16" is not allocated\n", > + RTE_ETHDEV_LOG(ERR, "Port ID %"PRIu16" is not allocated\n", > port_id); > return -ENODEV; > } > @@ -760,7 +760,7 @@ rte_eth_dev_owner_delete(const uint64_t owner_id) > owner_id); > } else { > RTE_ETHDEV_LOG(ERR, > - "Invalid owner id=3D%016"PRIx64"\n", > + "Invalid owner ID=3D%016"PRIx64"\n", > owner_id); > ret =3D -EINVAL; > } > @@ -779,7 +779,7 @@ rte_eth_dev_owner_get(const uint16_t port_id, struct = rte_eth_dev_owner > *owner) > ethdev =3D &rte_eth_devices[port_id]; >=20 > if (!eth_dev_is_allocated(ethdev)) { > - RTE_ETHDEV_LOG(ERR, "Port id %"PRIu16" is not allocated\n", > + RTE_ETHDEV_LOG(ERR, "Port ID %"PRIu16" is not allocated\n", > port_id); > return -ENODEV; > } > @@ -4327,7 +4327,7 @@ rte_eth_dev_mac_addr_add(uint16_t port_id, struct r= te_ether_addr *addr, > return -EINVAL; > } > if (pool >=3D ETH_64_POOLS) { > - RTE_ETHDEV_LOG(ERR, "Pool id must be 0-%d\n", ETH_64_POOLS - 1); > + RTE_ETHDEV_LOG(ERR, "Pool ID must be 0-%d\n", ETH_64_POOLS - 1); > return -EINVAL; > } >=20 > @@ -4552,7 +4552,7 @@ int rte_eth_set_queue_rate_limit(uint16_t port_id, = uint16_t queue_idx, >=20 > if (queue_idx > dev_info.max_tx_queues) { > RTE_ETHDEV_LOG(ERR, > - "Set queue rate limit:port %u: invalid queue id=3D%u\n", > + "Set queue rate limit:port %u: invalid queue ID=3D%u\n", > port_id, queue_idx); > return -EINVAL; > } > @@ -6409,7 +6409,7 @@ rte_eth_rx_metadata_negotiate(uint16_t port_id, uin= t64_t *features) >=20 > if (dev->data->dev_configured !=3D 0) { > RTE_ETHDEV_LOG(ERR, > - "The port (id=3D%"PRIu16") is already configured\n", > + "The port (ID=3D%"PRIu16") is already configured\n", > port_id); > return -EBUSY; > } > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 2c35caf000..f7be628f7d 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -197,7 +197,7 @@ int rte_eth_iterator_init(struct rte_dev_iterator *it= er, const char *devargs); > * Iterates on devices with devargs filter. > * The ownership is not checked. > * > - * The next port id is returned, and the iterator is updated. > + * The next port ID is returned, and the iterator is updated. > * > * @param iter > * Device iterator handle initialized by rte_eth_iterator_init(). > @@ -205,7 +205,7 @@ int rte_eth_iterator_init(struct rte_dev_iterator *it= er, const char *devargs); > * by calling rte_eth_iterator_cleanup(). > * > * @return > - * A port id if found, RTE_MAX_ETHPORTS otherwise. > + * A port ID if found, RTE_MAX_ETHPORTS otherwise. > */ > uint16_t rte_eth_iterator_next(struct rte_dev_iterator *iter); >=20 > @@ -230,7 +230,7 @@ void rte_eth_iterator_cleanup(struct rte_dev_iterator= *iter); > * the function rte_eth_iterator_cleanup() must be called. > * > * @param id > - * Iterated port id of type uint16_t. > + * Iterated port ID of type uint16_t. > * @param devargs > * Device parameters input as string of type char*. > * @param iter > @@ -935,7 +935,7 @@ struct rte_eth_vmdq_dcb_conf { > * Passing the ETH_VMDQ_ACCEPT_UNTAG in the rx_mode field allows pool > * selection using only the MAC address. MAC address to pool mapping is = done > * using the rte_eth_dev_mac_addr_add function, with the pool parameter > - * corresponding to the pool id. > + * corresponding to the pool ID. > * > * Queue selection within the selected pool will be done using RSS when > * it is enabled or revert to the first queue of the pool if not. > @@ -1471,7 +1471,7 @@ struct rte_eth_dev_portconf { > }; >=20 > /** > - * Default values for switch domain id when ethdev does not support swit= ch > + * Default values for switch domain ID when ethdev does not support swit= ch > * domain definitions. > */ > #define RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID (UINT16_MAX) > @@ -1481,7 +1481,7 @@ struct rte_eth_dev_portconf { > */ > struct rte_eth_switch_info { > const char *name; /**< switch name */ > - uint16_t domain_id; /**< switch domain id */ > + uint16_t domain_id; /**< switch domain ID */ > /** > * Mapping to the devices physical switch port as enumerated from the > * perspective of the embedded interconnect/switch. For SR-IOV enabled > @@ -1644,7 +1644,7 @@ struct rte_eth_burst_mode { > * This structure is used by rte_eth_xstats_get() to provide > * statistics that are not provided in the generic *rte_eth_stats* > * structure. > - * It maps a name id, corresponding to an index in the array returned > + * It maps a name ID, corresponding to an index in the array returned > * by rte_eth_xstats_get_names(), to a statistic value. > */ > struct rte_eth_xstat { > @@ -1860,12 +1860,12 @@ struct rte_eth_dev_owner { > * Iterates over valid ethdev ports owned by a specific owner. > * > * @param port_id > - * The id of the next possible valid owned port. > + * The ID of the next possible valid owned port. > * @param owner_id > * The owner identifier. > * RTE_ETH_DEV_NO_OWNER means iterate over all valid ownerless ports. > * @return > - * Next valid port id owned by owner_id, RTE_MAX_ETHPORTS if there is = none. > + * Next valid port ID owned by owner_id, RTE_MAX_ETHPORTS if there is = none. > */ > uint64_t rte_eth_find_next_owned_by(uint16_t port_id, > const uint64_t owner_id); > @@ -1882,9 +1882,9 @@ uint64_t rte_eth_find_next_owned_by(uint16_t port_i= d, > * Iterates over valid ethdev ports. > * > * @param port_id > - * The id of the next possible valid port. > + * The ID of the next possible valid port. > * @return > - * Next valid port id, RTE_MAX_ETHPORTS if there is none. > + * Next valid port ID, RTE_MAX_ETHPORTS if there is none. > */ > uint16_t rte_eth_find_next(uint16_t port_id); >=20 > @@ -1898,11 +1898,11 @@ uint16_t rte_eth_find_next(uint16_t port_id); > * Iterates over ethdev ports of a specified device. > * > * @param port_id_start > - * The id of the next possible valid port. > + * The ID of the next possible valid port. > * @param parent > * The generic device behind the ports to iterate. > * @return > - * Next port id of the device, possibly port_id_start, > + * Next port ID of the device, possibly port_id_start, > * RTE_MAX_ETHPORTS if there is none. > */ > uint16_t > @@ -1913,7 +1913,7 @@ rte_eth_find_next_of(uint16_t port_id_start, > * Macro to iterate over all ethdev ports of a specified device. > * > * @param port_id > - * The id of the matching port being iterated. > + * The ID of the matching port being iterated. > * @param parent > * The rte_device pointer matching the iterated ports. > */ > @@ -1926,11 +1926,11 @@ rte_eth_find_next_of(uint16_t port_id_start, > * Iterates over sibling ethdev ports (i.e. sharing the same rte_device)= . > * > * @param port_id_start > - * The id of the next possible valid sibling port. > + * The ID of the next possible valid sibling port. > * @param ref_port_id > - * The id of a reference port to compare rte_device with. > + * The ID of a reference port to compare rte_device with. > * @return > - * Next sibling port id, possibly port_id_start or ref_port_id itself, > + * Next sibling port ID, possibly port_id_start or ref_port_id itself, > * RTE_MAX_ETHPORTS if there is none. > */ > uint16_t > @@ -1942,9 +1942,9 @@ rte_eth_find_next_sibling(uint16_t port_id_start, u= int16_t ref_port_id); > * Note: the specified reference port is part of the loop iterations. > * > * @param port_id > - * The id of the matching port being iterated. > + * The ID of the matching port being iterated. > * @param ref_port_id > - * The id of the port being compared. > + * The ID of the port being compared. > */ > #define RTE_ETH_FOREACH_DEV_SIBLING(port_id, ref_port_id) \ > for (port_id =3D rte_eth_find_next_sibling(0, ref_port_id); \ > @@ -2413,7 +2413,7 @@ int rte_eth_hairpin_unbind(uint16_t tx_port, uint16= _t rx_port); > * @param port_id > * The port identifier of the Ethernet device > * @return > - * The NUMA socket id to which the Ethernet device is connected or > + * The NUMA socket ID to which the Ethernet device is connected or > * a default of zero if the socket could not be determined. > * -1 is returned is the port_id value is out of range. > */ > @@ -2575,7 +2575,7 @@ int rte_eth_dev_set_link_down(uint16_t port_id); > int rte_eth_dev_close(uint16_t port_id); >=20 > /** > - * Reset a Ethernet device and keep its port id. > + * Reset a Ethernet device and keep its port ID. > * > * When a port has to be reset passively, the DPDK application can invok= e > * this function. For example when a PF is reset, all its VFs should als= o > @@ -2586,7 +2586,7 @@ int rte_eth_dev_close(uint16_t port_id); > * When this function is called, it first stops the port and then calls = the > * PMD specific dev_uninit( ) and dev_init( ) to return the port to init= ial > * state, in which no Tx and Rx queues are setup, as if the port has bee= n > - * reset and not started. The port keeps the port id it had before the > + * reset and not started. The port keeps the port ID it had before the > * function call. > * > * After calling rte_eth_dev_reset( ), the application should use > @@ -2821,7 +2821,7 @@ int rte_eth_stats_reset(uint16_t port_id); > * is too small. The return value corresponds to the size that shoul= d > * be given to succeed. The entries in the table are not valid and > * shall not be used by the caller. > - * - A negative value on error (invalid port id). > + * - A negative value on error (invalid port ID). > */ > int rte_eth_xstats_get_names(uint16_t port_id, > struct rte_eth_xstat_name *xstats_names, > @@ -2854,7 +2854,7 @@ int rte_eth_xstats_get_names(uint16_t port_id, > * is too small. The return value corresponds to the size that shoul= d > * be given to succeed. The entries in the table are not valid and > * shall not be used by the caller. > - * - A negative value on error (invalid port id). > + * - A negative value on error (invalid port ID). > */ > int rte_eth_xstats_get(uint16_t port_id, struct rte_eth_xstat *xstats, > unsigned int n); > @@ -3554,7 +3554,7 @@ typedef int (*rte_eth_dev_cb_fn)(uint16_t port_id, > * Register a callback function for port event. > * > * @param port_id > - * Port id. > + * Port ID. > * RTE_ETH_ALL means register the event for all port ids. > * @param event > * Event interested. > @@ -3575,7 +3575,7 @@ int rte_eth_dev_callback_register(uint16_t port_id, > * Unregister a callback function for port event. > * > * @param port_id > - * Port id. > + * Port ID. > * RTE_ETH_ALL means unregister the event for all port ids. > * @param event > * Event interested. > @@ -4007,7 +4007,7 @@ int rte_eth_dev_uc_all_hash_table_set(uint16_t port= _id, uint8_t on); > * @param port_id > * The port identifier of the Ethernet device. > * @param queue_idx > - * The queue id. > + * The queue ID. > * @param tx_rate > * The Tx rate in Mbps. Allocated from the total port link speed. > * @return > @@ -4709,7 +4709,7 @@ int > rte_eth_read_clock(uint16_t port_id, uint64_t *clock); >=20 > /** > -* Get the port id from device name. The device name should be specified > +* Get the port ID from device name. The device name should be specified > * as below: > * - PCIe address (Domain:Bus:Device.Function), for example- 0000:2:00.0 > * - SoC device name, for example- fsl-gmac0 > @@ -4727,7 +4727,7 @@ int > rte_eth_dev_get_port_by_name(const char *name, uint16_t *port_id); >=20 > /** > -* Get the device name from port id. The device name is specified as belo= w: > +* Get the device name from port ID. The device name is specified as belo= w: > * - PCIe address (Domain:Bus:Device.Function), for example- 0000:02:00.0 > * - SoC device name, for example- fsl-gmac0 > * - vdev dpdk name, for example- net_[pcap0|null0|tun0|tap0] > @@ -5105,7 +5105,7 @@ rte_eth_rx_burst(uint16_t port_id, uint16_t queue_i= d, > * @param port_id > * The port identifier of the Ethernet device. > * @param queue_id > - * The queue id on the specific port. > + * The queue ID on the specific port. > * @return > * The number of used descriptors in the specific queue, or: > * - (-ENODEV) if *port_id* is invalid. > @@ -5455,7 +5455,7 @@ rte_eth_tx_burst(uint16_t port_id, uint16_t queue_i= d, > * > * @param port_id > * The port identifier of the Ethernet device. > - * The value must be a valid port id. > + * The value must be a valid port ID. > * @param queue_id > * The index of the transmit queue through which output packets must b= e > * sent. > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index e3c2277582..9546453762 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -2624,12 +2624,12 @@ struct rte_flow_query_age { > * Adds a counter action to a matched flow. > * > * If more than one count action is specified in a single flow rule, the= n each > - * action must specify a unique id. > + * action must specify a unique ID. > * > * Counters can be retrieved and reset through ``rte_flow_query()``, see > * ``struct rte_flow_query_count``. > * > - * For ports within the same switch domain then the counter id namespace= extends > + * For ports within the same switch domain then the counter ID namespace= extends > * to all ports within that switch domain. > */ > struct rte_flow_action_count { > -- > 2.30.2 Acked-by: Ori Kam Best, Ori