From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28630A034F; Mon, 11 Oct 2021 12:02:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9698040E01; Mon, 11 Oct 2021 12:02:37 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2042.outbound.protection.outlook.com [40.107.237.42]) by mails.dpdk.org (Postfix) with ESMTP id C160240142 for ; Mon, 11 Oct 2021 12:02:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O3J9rGcjdPVj8PHVB62oEt7cpiBGYys6QAAs0Q9ZviS9oqkeUdpFdLIfDaaPpRGby7dKehssaMonJfS8hyj6tAv+hpaquGkJKB9V49Y9BYvfdL4j9ioqhrrR7iniZf8dnRBJqdzGrhdiwRxnWRMbRq2Xq+PP+QiOwtzEKEO6/E8NQeKfbrL8Z3LRKGoPM6Bd9kZkQ579qHkhCFC7byVregQvVA2C/zY/Q/2xOEcsUpEj9r60m4gPILMi0Nz89YV0N7PIk4rbhukKIw8FT5SlfP6hiwaqfkklScUvAHdCOD61/QKBPBiG4T5I3Pmz3mZCWv9uq+yR58wg1ozoPG3lGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8r96bP4JAt68f5P88anfcrL7W1EhS72OThm2rcUhnac=; b=WoRPeY/UZWO7Cq35Js3UXXr1wHauyEpv0wtudgoe+EEnJ7TVx8I6s/EBKvnkrzGWZ+YMK4ciVvPFaVTdTiSLBq+nBenJHEYqGVk7e5PHFt4NnmSz+TAg428YN4i511gXEsIBmnGnGYkYc+q2qMMDZMX4qfXjticP17aerzwoxDhkR/Ax/n8YiJ4+yK566lye8UHeI3WUWSq6OgvjwS4OmI4D7dlOySitrD/up4lu9CfItDqxeAgF0VVt65RY9jUNEibhq0sKqbxcBy3ijem0QinZpQUaTING/pIqww339en8L0ST0InynTH51FM5CqbtpkFVVF0yjv3jgJjnNog0xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8r96bP4JAt68f5P88anfcrL7W1EhS72OThm2rcUhnac=; b=afbOTmK5v/b+UyN81fZb7jPf2vT/goQzD0ERbi3w4ODdXJDcB/VzUVNKoOD85M+5oV+f8TVf23Ccaqw+q7kVMcExOd5Yw7BuYApTccJjTHoNiOMqxa1uxICxdpCg7vpHfShFUw1OyJXrSyQaiyvKyubVMYrVuJ4mbJOPBSBGpZEGj9/wb3XXYV+6AGb47D1NUG/QCCFvqkJy0jbga6LD2Ga8wVNnKYHFuc5YRb+TF3bDlIAygz//ups0BDo9hAlbmNV2mdBqDfqfk84/o1fbbV8iYpfd83g3VZT1YOCqjUYf4l4afHlayFs3d+6KGxarOw7z4g2TbkIc5NyD/7VvPw== Received: from DM8PR12MB5400.namprd12.prod.outlook.com (2603:10b6:8:3b::12) by DM4PR12MB5101.namprd12.prod.outlook.com (2603:10b6:5:390::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct 2021 10:02:34 +0000 Received: from DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::d03d:1f75:ca20:6a32]) by DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::d03d:1f75:ca20:6a32%6]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021 10:02:34 +0000 From: Ori Kam To: Andrew Rybchenko , Xiaoyun Li , Ray Kinsella , Ajit Khaparde , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , Qiming Yang , Qi Zhang , Matan Azrad , Slava Ovsiienko , Jerin Jacob , Jasvinder Singh , Cristian Dumitrescu , NBU-Contact-Thomas Monjalon , Ferruh Yigit CC: "dev@dpdk.org" , Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH v2] ethdev: remove deprecated shared counter attribute Thread-Index: AQHXvC8AHF4/YmBPYE64acxUXO6X36vNlRUA Date: Mon, 11 Oct 2021 10:02:34 +0000 Message-ID: References: <20210928152300.989961-1-andrew.rybchenko@oktetlabs.ru> <20211008102616.2627821-1-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20211008102616.2627821-1-andrew.rybchenko@oktetlabs.ru> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0b383bfa-bb5a-49f7-232e-08d98c9e3f2a x-ms-traffictypediagnostic: DM4PR12MB5101: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: y6kKsPe7iXNp7fDp05NvcHzAWwpYSGuu8HhU8iI4+cHq199MOvejjNSHjib8IJJEHAy8BkSF6KDiScqX8vI3YJj/Blne9PNKV49glEWv5AQhrVyL9YI0yPbY8eq/XvjsZIL4rSDDfq+yPbZLrv8zkxKWccq10de2s2wksxgQMitBK6Ph75fgT2GfNkVc0VQq30K3HV/VKYhm/A2m1gcCh4JCssT7UxhAujtXoFy6k+CJ9n7JywEtXfVWE5WFge94cr4SLtSZBUoFBON9DBbQJqb8qbSVv1uKfA1TRoYhISqxi3xGAOwG8wuvhfi3fVCbKIwUC18ma7adzGRXjp7FgmD/+jbwtavV/GPTkgOfZte1kF5HCrIgHIgu/yCTxy/h/Q+0DQGrc7J5KIM5Ecwov2FxeX6vatnrh5ymqPehUbxGZqdGAbahfSQvwj8iJATUmz2ReWBayHoxJ7IW+8TiAJVuxuh2/1T67RiTIXy8iE6suMLh7QzwkX4JQAYgcr4ewgLgvrU6th//AF0JQkNfJUplYEH3TuO6uEeU2aSUQIMng55reXwlP6ByiuRU8yK2lAHke6CuN2gS1IGHJ1rY9ttyjWy7QXkb0Pac3bTuAqCQi7huduO0wIEMrQ8EcgRL2Hg254iH+oxcVZDCpMmpjy66bqvOxaPb7LYUx3wLld6xGpXVilU2gCmX9BdQS88I9YNn2zD7RYHHp7bJsPA1yaCxnOlxRh7Vc2IHzNfkAlA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR12MB5400.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(7416002)(508600001)(86362001)(316002)(4326008)(38100700002)(5660300002)(54906003)(110136005)(26005)(33656002)(9686003)(7696005)(55016002)(6506007)(38070700005)(52536014)(122000001)(8936002)(76116006)(64756008)(66446008)(66476007)(66556008)(66946007)(921005)(83380400001)(71200400001)(186003)(2906002)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4WgcfepL19fIYxv2UJWhBupaCFaOFH88pZT4ORtHxBhV91M4fHdvTwhCPFC9?= =?us-ascii?Q?HHHIeWBZYd8DeCwvv+ZlFLmZpyrdLj1MG7crgRRXIXluNAin3hDx2EkOZfh3?= =?us-ascii?Q?HTS2jjopDjXNf1HazJO8KL5qJbKF1MF1GXm9ymfw3bYjuCF0Jdzqd4GNNhhj?= =?us-ascii?Q?u8ZdL/cTjfOzVu7XLwtW7O1J63CcoqmVCxrbSC4ZocrJ7/ipRPThwUBMU7Jn?= =?us-ascii?Q?2ABECmEPICVPNNMyvcd21efSN9VmTeDJHPzkRwyXKHxj1q1tMrhuiphX3TMk?= =?us-ascii?Q?0XPacIIEg8rOuFDg3kRDDgRPIL9QCCmWKE4dnc2ZqM793tJJqKnQDYhxgaX+?= =?us-ascii?Q?t0x/OAP73VU89OET1m6vU3ytmSvFMuYhopaIr8JhFU8ap0eKIQkz/S+b1ozG?= =?us-ascii?Q?JVGLreSV2sOl4ZXRULkLIqa8/Ih5309PdyWEjp4epMUaBQlfdaOoAGYcek+v?= =?us-ascii?Q?foiFwK7877Iov+3gnYJlpAcUaWGGrFFAcJ4rcFpIjttApOqr6Yu8zLBz1L+n?= =?us-ascii?Q?pBOTkhAbedQxaHNFQa9Hfg7dgmPAPZkPqDg2NqQDxx9M6HkekOUGZCHCWU2W?= =?us-ascii?Q?f6JoQmmuJQq5JiMskkXMb9qUMZ3cVLIDykuBwCnBe1MQRdJ11j6x9RzJhdzZ?= =?us-ascii?Q?wG9p3pnT7OIcKeMDT5dr+CsfxjgSVTxWOzqUQQYIhqIZh2/VILPrGe9BWTLl?= =?us-ascii?Q?RMGS/1r7/ThKiCqN2J64/a6cOB/ybVjtTBx8fsjmRDEnN13LAOK4vTOaXAS0?= =?us-ascii?Q?j61QldYsUQ8FCYBmQz4eaqCdFBsvX9raZhck68816t6nQL2g6hNkKXKbTTEB?= =?us-ascii?Q?x5CXS7g4QMw0pvkGG/lyM3vGcq4Q1z4Z/dUOZ6TOBdfPSlrYuarVkGW3gTx5?= =?us-ascii?Q?tsX8qcNQKzSJFDKuCYy12SS/HQAFPQ+YzpDPbr4vem2560vvsEyoKJ967X+B?= =?us-ascii?Q?1ItiAECdbwNE+jGS0RY9Ni7omUpovXvLseare7WimVIL/ORspLtw8hwo9jiO?= =?us-ascii?Q?gSbjOd92DEbuP1MxKfiSxn7206MiWuviiGEDty9L670YWKcMOGDYlVw4bmnl?= =?us-ascii?Q?sE7A3GpzbPJAY30zvfkwH98fqLDV8Rd8cuhUcSKiHvKlnlzlsRVMGL36hSwz?= =?us-ascii?Q?28SuQcjux/VvMqp09Hgt3zfr7YufFrFRMPwCubYXdE1wte997AsPvZP6l/Ml?= =?us-ascii?Q?g6Z5/rxeRwJLuiRvjgWLAz/elZK+ObrZ/Em+8/AKVpvL/suAufDAkEZdOXwA?= =?us-ascii?Q?VIsfb0chJoA6bdEGmH3VuSxXp2NXKo9WDYxxLKPtOr3zMhSF8OcYtKNWN2D3?= =?us-ascii?Q?Cd3gUw6S+tf5hN+diOohApQ1?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5400.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b383bfa-bb5a-49f7-232e-08d98c9e3f2a X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2021 10:02:34.0878 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DPnUn/5o5ArwGFXeCdZONBv8vsL+b7WisKbEx+qO9yeQl/9AqoCIvWzwiNiwmvKcqy+RUB9bcGEStsmzjfmcuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5101 Subject: Re: [dpdk-dev] [PATCH v2] ethdev: remove deprecated shared counter attribute X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Andrew, Sorry but I think I missed something.=20 > -----Original Message----- > From: dev On Behalf Of Andrew Rybchenko > Sent: Friday, October 8, 2021 1:26 PM >=20 > Indirect actions should be used to do shared counters. >=20 > Signed-off-by: Andrew Rybchenko > Acked-by: Thomas Monjalon > Acked-by: Ajit Khaparde > Acked-by: Somnath Kotur > Acked-by: Ori Kam > --- > v2: > - remove reserved field from count structure (review from Stephen) > - apply mlx5 review notes from Matan >=20 > app/test-pmd/cmdline_flow.c | 10 -- > doc/guides/prog_guide/rte_flow.rst | 19 +--- > doc/guides/rel_notes/deprecation.rst | 4 - > doc/guides/rel_notes/release_21_11.rst | 4 + > drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 5 - > drivers/net/cnxk/cnxk_rte_flow.c | 8 -- > drivers/net/hns3/hns3_flow.c | 3 +- > drivers/net/ice/ice_fdir_filter.c | 4 +- > drivers/net/mlx5/mlx5.c | 11 -- > drivers/net/mlx5/mlx5.h | 9 -- > drivers/net/mlx5/mlx5_flow_dv.c | 118 ++------------------- > drivers/net/mlx5/mlx5_flow_verbs.c | 22 +--- > drivers/net/octeontx2/otx2_flow_parse.c | 10 -- > drivers/net/sfc/sfc_mae.c | 9 +- > drivers/net/softnic/rte_eth_softnic_flow.c | 7 -- > lib/ethdev/rte_flow.h | 16 +-- > 16 files changed, 22 insertions(+), 237 deletions(-) >=20 [Snip] > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index 7b1ed7f1= 10..9819c25d2f 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -75,7 +75,7 @@ extern "C" { > * At least one direction must be specified. > * > * Specifying both directions at once for a given rule is not recommende= d > - * but may be valid in a few cases (e.g. shared counter). > + * but may be valid in a few cases. > */ > struct rte_flow_attr { > uint32_t group; /**< Priority group. */ @@ -2498,24 +2498,10 @@ struct = rte_flow_query_age > { > * Counters can be retrieved and reset through ``rte_flow_query()``, see > * ``struct rte_flow_query_count``. > * > - * @deprecated Shared attribute is deprecated, use generic > - * RTE_FLOW_ACTION_TYPE_INDIRECT action. > - * > - * The shared flag indicates whether the counter is unique to the flow r= ule the > - * action is specified with, or whether it is a shared counter. > - * > - * For a count action with the shared flag set, then then a global devic= e > - * namespace is assumed for the counter id, so that any matched flow rul= es using > - * a count action with the same counter id on the same port will contrib= ute to > - * that counter. > - * > * For ports within the same switch domain then the counter id namespace= extends > * to all ports within that switch domain. I don't think we need this anymore. > */ > struct rte_flow_action_count { > - /** @deprecated Share counter ID with other flow rules. */ > - uint32_t shared:1; > - uint32_t reserved:31; /**< Reserved, must be zero. */ > uint32_t id; /**< Counter ID. */ Why do we need to keep the id field? > }; >=20 > -- > 2.30.2 Best, Ori