From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 275E3A0547; Sun, 17 Oct 2021 11:45:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8FB2410F4; Sun, 17 Oct 2021 11:45:07 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2054.outbound.protection.outlook.com [40.107.94.54]) by mails.dpdk.org (Postfix) with ESMTP id EAA4C40041 for ; Sun, 17 Oct 2021 11:45:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YWPguae08J9p4xdgt6Yadg2qKKKllgWVEnbY8vsNU1750D5uhm9ADNoZY/zh6tZmQ1YD+KnTBmiQ9/3M3KiDtxcMWzAvcsFOtIWXW1tGsCFtPOcYNqECnmxlGKznYliBN2U7QuCNVoqEaPb5F/Guwzo+iyTc0cNv6QRj2OfE7Qqa9vKaYtR4Qb4K41wF4XQImgVQKR9BxoLxrBNJmn8PvDtc/Aluos1IULJHL9eutXPqxLASK13sVxIFt6M3HMpXFYzYMkllC1xQ0FXR71X+01ThQy+f10I1SH4aNaimbLdzt202pWNjUAAiiE6pammjX8hMxTU4VXmq/L/6V9nEjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f5T8OBy3YdPxaGHdq7nwMRx4/5t2O2UGaO9v73vfaig=; b=hI6hwAWFn9qJgqBWcC/hI4fL0tLxrd98SHiCR3KrFR5U+CCpo0Gk5yhMCLqneSR81cEgNfQTxmpZYorBSHHEj/mdcyBYwdJagacSVeP6INkknLPas9301We2+P9u2jjXvCj9WPF1nYP1h13A4uhNrVaQsK9VbyUBBqvRPHb1gXX6/CyRR3a2VB33sA+v4cdLtiVcGxPlTQrtmn16wmHG29gzbQBAT4CChcrNItbWvxz8DOvgAbtEa2Ysj+37PX1AvJ84uwlIit7BqpxLOJMBxC5a0DYcVTgI+DncSC2BukEZx5zbseXDZMCD501V+AIm8ewYBsZKI+7rH8lWhZ8Tvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f5T8OBy3YdPxaGHdq7nwMRx4/5t2O2UGaO9v73vfaig=; b=O+X338m1EMllCM9LivNNCo3+1CP0mbnD6hCiDDFUjVLSVtjAS2Q+Z1+St0P6bWB6Xiyfc0lY+GJWuE81wfM78jB/7cWly8088ygKJ7I99cL59tgOf5tOBWFIaDEE4dU1JONI2IA29ro5KzKNVdBu4dkgWmO6RptY8y6Fm3rNJv0d3FXWDRhN1lza/Hh8m/lROOJ7YSW4ID2ccamnXPfcoBsXiJfObZw7Yy02oJxrKzPFzy/cziDreM8/zFqyyMk+9BdLTk2mube1503nHykx1DQ4+Xro/goeTprX7vsDAxAY44PSdaD4kxg5IVaCgceMN3UGJhFqzBdmgbt+HgbIGA== Received: from DM8PR12MB5400.namprd12.prod.outlook.com (2603:10b6:8:3b::12) by DM8PR12MB5477.namprd12.prod.outlook.com (2603:10b6:8:35::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Sun, 17 Oct 2021 09:45:04 +0000 Received: from DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::d03d:1f75:ca20:6a32]) by DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::d03d:1f75:ca20:6a32%7]) with mapi id 15.20.4608.018; Sun, 17 Oct 2021 09:45:04 +0000 From: Ori Kam To: Dmitry Kozlyuk , "dev@dpdk.org" CC: NBU-Contact-Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko Thread-Topic: [PATCH v2 2/5] ethdev: add capability to keep shared objects on restart Thread-Index: AQHXweBSEnuELz3mOkmY6XNTB/cjw6vW1trggAAUNYCAAARfIA== Date: Sun, 17 Oct 2021 09:45:04 +0000 Message-ID: References: <20211005005216.2427489-1-dkozlyuk@nvidia.com> <20211015161822.3099818-1-dkozlyuk@nvidia.com> <20211015161822.3099818-3-dkozlyuk@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 063891bb-614c-479c-d269-08d99152cbf9 x-ms-traffictypediagnostic: DM8PR12MB5477: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hAA98l5CNyokeZG15lASGxoMxn1EDFZ4GxRR+H0BLUZTNBGKdHZ1GKo22KBKi+cfH1fs0DOWNRVZQsrh/ABSQHx/RTphoURUC/RqYOJOCSoxcDLEcmpe2hTjgU3WR9IveqoKSUckWQRdCvolBB3ebEg6a58snHQIjMkGBJ4ADC1wVEx+uG0yast5KKkJr6B6oBQ2kXlVNF5m0myMPJ4JCJ9AvdTttcIDxmL7oxENnAKyFk3x9mXgk9oLWdvdKwDcpEGxsSNd9AFcMyaz7AdC0yVBTJBi93oBDPqCwnMgCK0jltXnlmIiusPS1A9ygs4VFsGJ6DVG+w1wZQI3U7k1/Y8cpVhDb0gOzvEQpXMdVs/qObI/xXe0LX5glU5EbsPmF+vbvD0qxPgxoZRCADUE/LbmI/YWVU7DRebJJSaCeTqM8/AkWK//63N2w1sgG6AtUN/ajOYUokcuy8ugK3VA/7ulLYf5xzBvWHZSI+v1ao0g9n7KatTu/PfLAGVuZLNxpculxbdd7/0jOi3uoh3jQu9hFqKybPKryuMfJq9UMt3GDqqdXGLq1zrBbONvI11EU4TsLkcna2A6HoDVyEElbt3H0SaryNlIA4q/9r6xKfahuoge9A8T4XMCOKjbBn+YOCV2l7ePw7kwMertMZqQV04/BjIT7MjNl4ZffLov3nhqQ/90OofRvzdUUwMTlhDrVgEFTXpCZzeQZ9FpBy7+mw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR12MB5400.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(7696005)(66476007)(54906003)(110136005)(6506007)(26005)(66446008)(71200400001)(186003)(64756008)(2906002)(55016002)(52536014)(122000001)(508600001)(8936002)(76116006)(83380400001)(86362001)(5660300002)(53546011)(38100700002)(66556008)(38070700005)(66946007)(4326008)(316002)(8676002)(33656002)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qTArGOQWM8hOdNXxmy4pQmFmsfb/xk4OIHmsivdmoITyS1ksEg3Ect/uLlHB?= =?us-ascii?Q?nmDvxbXkHLbFUVaoVC1/oGlBYveBxZlM1m6U7nJPi4GsDGB7iWLxXYLPqzsK?= =?us-ascii?Q?cLi54cCTyWUx/9iM2vWgNw3FW4/CRBCeWf6jIdK/s+ignklmT21Rvp0kRXW8?= =?us-ascii?Q?SdFlZ+SbXsOUdLLVH2mg2QmvtRIoP5cqRaKt7l3Pwk91k9PZymEBYTkeho+a?= =?us-ascii?Q?+7DZlQ5dLUdk9SzACl3GF17PdAwGG5lA/kMZBHWh99srdEDBw2METh68Pvlv?= =?us-ascii?Q?yxYVlgxnSMEVTSz3+ejx7xbls8uAF/8QpJbUsczxT47JLLUXYKBA4C/UhuAe?= =?us-ascii?Q?aajoS3cN8v+06miKnAiCxQ4+BZAu5bJCFNWUuufAx/oeoMhZr+hMowjSNNTm?= =?us-ascii?Q?0RhBt1sKuYTw+bqLftfqzlaeDbrwBL+08Tbi7p7+o4v87InwtzMAzsfDxVZp?= =?us-ascii?Q?ozYF6EZAExByOe2jfqjn3w/n1HtwxNjKD/8jVxI4xb/pzw/C51sCWZ7tLK4o?= =?us-ascii?Q?e9E50UCEn6brM70cB6bPD+K0gZeylkICkRPlNqR9RD/SExSy55lgjQogulax?= =?us-ascii?Q?TYdg4lw9eYjDaBl7t/zppWR0pz7QavJFiV1oW+cb2ybz/TnMmQc/kfeG6pE7?= =?us-ascii?Q?MlLbPEB+bXrlNW1d1qaX2s5EUcdPSTel+fDO2SaCSh/7PyzuDD+DVMMVmqAC?= =?us-ascii?Q?JhkBUnZaPCli8+eqvwcdgtCwukOF2hn+8QqBtQFJRLKadD2XWGHh1wOyRp5/?= =?us-ascii?Q?61qkeI1AltW7nWHIbNAcciMTbJtzq32EYNYd2O1WYPSG/tqicK2ZQnH/gRjh?= =?us-ascii?Q?tN5DrHqVLY2z95m4JMf2gG4CT48F2VKd3giMM15bOz+v3dtaAmLCG9deADhm?= =?us-ascii?Q?jSxaOwzfV8R39ItIcjYs4cVzgNkwsEz1nqTQiIJIWl9RHdZbv08He5pv12Fw?= =?us-ascii?Q?UV0rdaSW0zQgTZwyTOIDWt7MgifMGLT3d3WmIRhebqNKUDLHzGe0cthqovA0?= =?us-ascii?Q?DZTixD3UQUpS9k/hdnMtv3jrGobXwwkrvlk8ZfJRWoeOPTaEv+XeA1BXAQvX?= =?us-ascii?Q?wMfNl/aZBiw34iOxr2fyN6PDel7i0Q5oOjflSnVhgC5JanMExKGX4c4sy7yc?= =?us-ascii?Q?WJ1TE5KT3heCrQa4qByM3IYkwQNXwJcyPO/kcV2itwgjA2hYCHHe6a4xz6Yl?= =?us-ascii?Q?Uxxmg2hyt39bfY/HKfRqil86BTYsy3bfm3njtJpUUK1z37lERUPn9BIhrsLO?= =?us-ascii?Q?YT0Kq31gcbmL3qqAMrxupKDRYBE45uKrhPR8FdQJzjyr3BmBhnITGPikmCPH?= =?us-ascii?Q?D35wuYfrM3kqR9Vf7rz++OW1?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5400.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 063891bb-614c-479c-d269-08d99152cbf9 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2021 09:45:04.4292 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VB6jIT83uPIfEkPJUW9B7ZL+sND7pUm4HKHL2jsK/ubWSiWPtCn652lz2W83gLRPMMINU3i76q1ghaIzkgAyJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5477 Subject: Re: [dpdk-dev] [PATCH v2 2/5] ethdev: add capability to keep shared objects on restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Dmitry. > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Sunday, October 17, 2021 12:15 PM > Subject: RE: [PATCH v2 2/5] ethdev: add capability to keep shared objects= on restart >=20 > > [...] > > > +By default it is unspecified if indirect actions persist after the > > device stop. > > > +If ``RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP`` is not advertised, > > > +then indirect actions must be explicitly destroyed before stopping > > > +the device if the application needs to ensure they are removed. > > > > I don't understand the above line, if indirect actions must be > > explicitly destroyed what does it means "if the application needs to > > ensure?) I think it should say just like now, application should > > destroy all shared objects before stopping. If application doesn't > > call the destroy the state of the action is undefined. >=20 > I had in mind that some applications don't care, because they only stop t= he port before closing it. > Would the following be more explicit? >=20 > "If ``RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP`` is not advertised, the s= tate of indirect > actions after the device stop is undefined. > Application must destroy all indirect actions before stopping the port if= it intends to start it later, or > unwanted indirect actions can remain." Sounds better, but I would also add something like this: if PMD doesn''t re= port keep, application should release resource before stopping / closing the port otherwise resource leak= may happen.=20 This should also be in the flows patch. Best, Ori