From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 206DDA0C4D; Wed, 13 Oct 2021 11:15:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADEAA41162; Wed, 13 Oct 2021 11:15:03 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2049.outbound.protection.outlook.com [40.107.243.49]) by mails.dpdk.org (Postfix) with ESMTP id 9427D40150 for ; Wed, 13 Oct 2021 11:15:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vs7fB72mmwjwPqMa+4wuQImskAEEZOq5pI84sIAEZ4+45HrOzH5rCkmHaKJbXqHXxH3DdBYsA9J16uH8V/N+MhavTpN1xYaSJoB0KJi+PfyVrnTIqGLfx7/EJKN40D1E144wZbN1dRbX+tVNndJMUbJiQo5h60dCWwvaqZgenCQd/ulTkp+XX2P0wn43Kb7puUpounDKfIDqi9jMwYqlXvc2KPTmubV/Hro1w7DaHya3nBQVt0Ow4guyNIDLeyLfSlimDMUacbB7OPcVMKPOAiB0Y1wjIZmo+fr9j6g9OccYLKrieMAvqOCSHA7/hn/h9zkKP/xoHBerf99MYgJwug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cfc8DbmeDy0kiMXKXXT2SU2w8funhFU/ftBsp+14JXc=; b=FV3I5EVLTHsQ0OhXSB0qIcNqARaSppnNEM6ytIQIn6YJPJ7bKz4keGQcrjFsLyNQ5y1wOhw8h/anKXIER1ZBpBCo66QOxUMQACQQm0Pv7OjfAC4Wu1z1xRufGiytWJRWWHG5hRCMd+KVNAXUktMeF2pm8JptCHTcKS4oi4Al3MqzAgEI8diXe1/1Ntf4h8XsLhUuFVdyvDy2zQvmSuVSHRafkReVnHYSKJEHXCKLUrFL4SpZH/yoay+g2SbNI4jrL/searGdhugmg/2S3Pmc0MhBD4uS1Hh1JIQxBw5w91L0gSV7nDXlOvq8oekxI3kq8ckNDpKUjcJiWDTwmG//Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cfc8DbmeDy0kiMXKXXT2SU2w8funhFU/ftBsp+14JXc=; b=aziDztjmQ6TQNnwdR/+nznTXmOt46wEoQam7ZgkxuJA8DkaNmOysDoquKQCEGPrjg2smByy4kd6yKeprcukvL+BGec9sUrYN1mtqvvoFrHX1asY2l1K6JEpDA7vCowrT20DDqQKV/YjxCMJFZZMg50lnhisuhs64I0aBPMDaz3ogtsuVTebExur7eTv6e906X/XWpVDVZhcyGhLZvz8orkDLZFtzRnPXR87bq6NKaW8cyQE7jD3OB78N+RKWok4BIB0zJhCZlx25xpkIe5TUtlm8IG2ndk/w984YibMBcfBSLC12viX7BugQdFvS8EPTk6ras9mD6qyHxMuY0tt3/g== Received: from DM8PR12MB5400.namprd12.prod.outlook.com (2603:10b6:8:3b::12) by DM4PR12MB5311.namprd12.prod.outlook.com (2603:10b6:5:39f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct 2021 09:15:01 +0000 Received: from DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::d03d:1f75:ca20:6a32]) by DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::d03d:1f75:ca20:6a32%7]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021 09:15:01 +0000 From: Ori Kam To: "Wang, Jie1X" , "dev@dpdk.org" CC: "Yigit, Ferruh" , NBU-Contact-Thomas Monjalon , "andrew.rybchenko@oktetlabs.ru" , "Li, Xiaoyun" , "Yang, SteveX" , "Wu, Jingjing" , "Xing, Beilei" , "Wu, Wenjun1" Thread-Topic: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUDP RSS Hash Thread-Index: AQHXv1OCpPBKXWRmrkKXclbfiXpBX6vPfU6wgAEZH4CAAA/SAA== Date: Wed, 13 Oct 2021 09:15:01 +0000 Message-ID: References: <20210924151705.287571-1-jie1x.wang@intel.com> <20211012102508.275790-1-jie1x.wang@intel.com> <20211012102508.275790-3-jie1x.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: da430f90-32c6-4805-d847-08d98e29ef8b x-ms-traffictypediagnostic: DM4PR12MB5311: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0DVvXV0J7KitmJhO+7FrbXpfVZXnQeJ3HHkPQsD6duyDqW0MHv3EsEEDppnFDrsE9M+Hb+Tj6LhWwizFjHsyfKuz8szSbIAxGehGLFXn0zA79qGZV9FPQpldP1gy6zK1PuB0LvULZ0h52HNrE6FHI5KJzzGmD+pHQ+KuSrM0OonzZlu51O744UB4XPWmHl6EQL4wzzcXP4uqynVGqkYIEKAUH+vN/1gGqH8cBsXYb6WjgtWvgKwjzUSH35wBa/vqjEsIq9s5WTdDw1rsesNOLjeCDtFKW6r1UCs3oeZzGS1yoe8OXQw3JO49Wh+7sOOOHOC7ASxxTjFgkOCH5pTsNbHu44bP2hM4IHBeuAcQG6NFCZmCCZStcFTvUx29MROP7ut/sjpBdnibu6xEYWVOFEyVeUhYr4nEr+SarrsArq7AZ6Gpgp8UpqfbridouWJR7ZMP/cU2sSTP88fpJ1zj3SlCz5UFTo97ztDR4aHHE7KEPCzn7b1YCOACxwIv2Am5oZRqHcnFlPbaNUAVe+zKNrXcdls5e2YPXhQeq0iBZ0AzFKgbbLTVMxR6BcpB410v5xdSVBFn0kbIoaAxASPW3VWdWp0vuxOWhiU3vbdMa5w89xn8osz3nimcPkyt+VaHgQ7S3+ee/dJ9H7A3kivxpz1mQu/bsIMx6Fj/JC07t3rcCZnme3xCRTO+lSepJ4iSiTH6cK/wPVYNSQJ2rx+XVQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR12MB5400.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(83380400001)(316002)(8936002)(186003)(508600001)(6506007)(38070700005)(33656002)(53546011)(7416002)(7696005)(55016002)(9686003)(86362001)(2906002)(54906003)(66946007)(64756008)(66556008)(66446008)(76116006)(4326008)(110136005)(71200400001)(66476007)(8676002)(122000001)(38100700002)(52536014)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hWGzjiafG/0DBh8GjOBu51tkgZWVLDBqcOHzfB3wzu+XFg9edaWtNvrTX/GT?= =?us-ascii?Q?Y27ChB5WUYlBmsIEvMqZaU8/tYGf0u0EK9F4nucGv5fbyhaJ61mt6RLyolXq?= =?us-ascii?Q?fRfFzyUGxSoP+f3H/5Q1dGBNDpBjPO+2QmLfAmzNTjBIaZoWcR0jJ6Trfmxt?= =?us-ascii?Q?ppiG54FliDB+zuwqLGJQN9HQBeBn5hRmTCxABx5GSzwq1FdAjkJcVTtSjpcx?= =?us-ascii?Q?LS+U72l/NkU09yAlQtTDm5+xNgL34+m2SLFtZtWhR/Fa6ckb9aletkTq4ZeE?= =?us-ascii?Q?vxVOivYEjo6SFhYbbIewYormQ8pimNb2Ble098UfJaZgYAfaDrXExUd/eNFs?= =?us-ascii?Q?M+rtWncqcQWLxoRtc+SEL9MAD0M0YQgfCFxU51XjXZOdbxeJ6KbnNxZOFR/O?= =?us-ascii?Q?dqE0YCc0NkV/657QdoHlc9SU0F9QnGze3a/mT1w38W2uyyM7qav2lrAa3zo9?= =?us-ascii?Q?lERkYomu7Oe27KL2B6/tW223M68srTJkcbXn13DGxIs/mYUSBdvdFWMidI5i?= =?us-ascii?Q?mc0hahpnjELxs0JDkbq3hBkHtW/yQplLUt5iYKDTodeJQ036B1UwRc9A9yIo?= =?us-ascii?Q?OPosK7UWfPtpJ9l20Kifi6JvSBWKmvssuAK2VDEe3T6+SFxiG5QVXYgPpl7t?= =?us-ascii?Q?i2EIsjHic7FBLwMnGPQ8ygJ7QUsF7ohmATK2Ha/+Rw9+2RQueaZW+ThYUJ12?= =?us-ascii?Q?rBFMaYG4NjXlxxVEKkgdKG1F37TGmqQ/b3ohNZpImwJuAyAaKo0Sy8xA+dhQ?= =?us-ascii?Q?gIkCtVdO9Ax0k1dg52U8YJJRd60vwl5XnTHNgU/eGJ4k3Q9G/w7suZcZbFd/?= =?us-ascii?Q?k0nbcboXIHDRR/fdL3Ux0G6PbIQOqmRTMSxBHJatXQPD/yPtBC4JQktUU0fB?= =?us-ascii?Q?ugaA7qaoqmpOQu0S1BbPxS+HmFxNu/0N/ymYFBrGtNyCl96eR8UoWM6JsBvC?= =?us-ascii?Q?zVcnYn1fz0N82Y2C1jOeDgVMs7kRlqjQzl4WM44U8hg5OOA1C2g2SBWXb7jX?= =?us-ascii?Q?nkyK/X6rn/xVJcJtSxwWAV1zLUJSwpPF/hKp/pRF29TfOZ1zZ+Sk2bnSzwMy?= =?us-ascii?Q?nV06Zf/KmlZ6ETJ2Rf6zBSLDrLJDmvl3JXV5cx6jqOTghzdnxy/1X27YA4AH?= =?us-ascii?Q?rHWcUso9DNxhMbdbTedXfGWp86vOmzSk2OP7e0QoL4uNii0YDaM0rLsj1Wni?= =?us-ascii?Q?zFH0yHiFwmtyt3nD4xwZPYGc6B2SU42npKi6RraOVOEGjXasgyDSnJxgRF3P?= =?us-ascii?Q?E+rfGlm7cNFTGxPxrQYC74IdsZTZN9S3Al4Pfqxj4YwWk4avsfJWRNotbW/1?= =?us-ascii?Q?NkuZPWmqy1OovCw0Q3cBZW1t44+ElKQVylIbKMGIDX2LxMsLu68iFgJBzoYI?= =?us-ascii?Q?Dp9OYgperwkC73NQkHsPHh0qk+z6?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5400.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: da430f90-32c6-4805-d847-08d98e29ef8b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2021 09:15:01.2402 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: R2GVF7hkXb1ZlYrPKMBLL3NMyj20hDFApPiJ1HUyp+ejWdbqdwxTcEn8z5SabougJhXtmPKGatCkIxue/ksPKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5311 Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUDP RSS Hash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Wang, > -----Original Message----- > From: Wang, Jie1X > Sent: Wednesday, October 13, 2021 11:16 AM > > Subject: RE: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUD= P RSS Hash >=20 >=20 >=20 > > -----Original Message----- > > From: Ori Kam > > Sent: Tuesday, October 12, 2021 11:32 PM > > To: Wang, Jie1X ; dev@dpdk.org > > Cc: Yigit, Ferruh ; NBU-Contact-Thomas > > Monjalon ; andrew.rybchenko@oktetlabs.ru; Li, > > Xiaoyun ; Yang, SteveX ; > > Wu, Jingjing ; Xing, Beilei > > ; Wu, Wenjun1 > > Subject: RE: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support > > PPPoL2TPv2oUDP RSS Hash > > > > Hi Jie, > > > > > -----Original Message----- > > > From: dev On Behalf Of Jie Wang > > > Sent: Tuesday, October 12, 2021 1:25 PM > > > Subject: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support > > > PPPoL2TPv2oUDP RSS Hash > > > > > > Add support for test-pmd to parse protocol pattern L2TPv2 and PPP. > > > > > > Signed-off-by: Wenjun Wu > > > Signed-off-by: Jie Wang > > > --- > > > app/test-pmd/cmdline_flow.c | 34 ++++++++++++++++++++++++++++++++++ > > > 1 file changed, 34 insertions(+) > > > > > > diff --git a/app/test-pmd/cmdline_flow.c > > > b/app/test-pmd/cmdline_flow.c index > > > bb22294dd3..3c9bcabd97 100644 > > > --- a/app/test-pmd/cmdline_flow.c > > > +++ b/app/test-pmd/cmdline_flow.c > > > @@ -299,6 +299,8 @@ enum index { > > > ITEM_GENEVE_OPT_TYPE, > > > ITEM_GENEVE_OPT_LENGTH, > > > ITEM_GENEVE_OPT_DATA, > > > + ITEM_PPP, > > > + ITEM_L2TPV2, > > > ITEM_INTEGRITY, > > > ITEM_INTEGRITY_LEVEL, > > > ITEM_INTEGRITY_VALUE, > > > @@ -997,6 +999,8 @@ static const enum index next_item[] =3D { > > > ITEM_AH, > > > ITEM_PFCP, > > > ITEM_ECPRI, > > > + ITEM_PPP, > > > + ITEM_L2TPV2, > > > > Why in the middle? > > >=20 > Ok, I will update it. >=20 > > > ITEM_GENEVE_OPT, > > > ITEM_INTEGRITY, > > > ITEM_CONNTRACK, > > > @@ -1368,6 +1372,16 @@ static const enum index item_integrity_lv[] = =3D { > > > ZERO, > > > }; > > > > > > +static const enum index item_ppp[] =3D { > > > + ITEM_NEXT, > > > + ZERO, > > > +}; > > > + > > > +static const enum index item_l2tpv2[] =3D { > > > + ITEM_NEXT, > > > + ZERO, > > > +}; > > > + > > > static const enum index next_action[] =3D { > > > ACTION_END, > > > ACTION_VOID, > > > @@ -3579,6 +3593,20 @@ static const struct token token_list[] =3D { > > > (sizeof(struct rte_flow_item_geneve_opt), > > > ITEM_GENEVE_OPT_DATA_SIZE)), > > > }, > > > + [ITEM_PPP] =3D { > > > + .name =3D "ppp", > > > + .help =3D "match ppp header", > > > + .priv =3D PRIV_ITEM(PPP, sizeof(struct rte_flow_item_ppp)), > > > + .next =3D NEXT(item_ppp), > > > + .call =3D parse_vc, > > > + }, > > > + [ITEM_L2TPV2] =3D { > > > + .name =3D "l2tpv2", > > > + .help =3D "match l2tpv2 header", > > > + .priv =3D PRIV_ITEM(L2TPV2, sizeof(struct rte_flow_item_l2tpv2)), > > > + .next =3D NEXT(item_l2tpv2), > > > + .call =3D parse_vc, > > > + }, > > > [ITEM_INTEGRITY] =3D { > > > .name =3D "integrity", > > > .help =3D "match packet integrity", @@ -8343,6 +8371,12 @@ > > > flow_item_default_mask(const struct > > rte_flow_item *item) > > > case RTE_FLOW_ITEM_TYPE_PFCP: > > > mask =3D &rte_flow_item_pfcp_mask; > > > break; > > > + case RTE_FLOW_ITEM_TYPE_L2TPV2: > > > + mask =3D &rte_flow_item_l2tpv2_mask; > > > + break; > > > + case RTE_FLOW_ITEM_TYPE_PPP: > > > + mask =3D &rte_flow_item_ppp_mask; > > > + break; > > > default: > > > break; > > > } > > > -- > > > 2.25.1 > > > > Maybe I'm missing something but I don't see that you added the ability > > to match on any of the header fields value. > > You also didn't update the code of encap (from my understanding this > > is a tunnel > > header) > > > > Best, > > Ori >=20 > Hi Ori, >=20 > This feature is only support for iavf enable PPPoL2TPv2oUDP rss. So it do= esn't need to add the ability > to match on any of the header fields value and the code of encap. >=20 > I'm not sure if it is necessary to add these. You added a lot of fields in the rte_flow and you don't give any way to tes= t them.=20 also Iike I said in previous patch what is the relation between matching it= ems to RSS? You didn't add it to the RSS possible support. Best, Ori