From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21195A0C4C; Wed, 21 Jul 2021 08:23:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FAB4410DA; Wed, 21 Jul 2021 08:23:07 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2089.outbound.protection.outlook.com [40.107.92.89]) by mails.dpdk.org (Postfix) with ESMTP id C1D974014E; Wed, 21 Jul 2021 08:23:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nw05u90nnTkwxCUmiIWUiivWMH+PbAVjO78I71tfgpVYCtiyANga71BJTfWNCJpOf38TafNQCJnAEnxpKhOBxgA3C2t0xddNQy6D6DjfYY4u6OY13w8g6K2LgcOM09fZn99V4ULwFBxyy4sad5aF36dI0ZQ9Hys/LogKtYSz7RaUGORpYP+PVGns3q+YDKa3W6zSgasFDscMvNbHZ6MMmM553V4MCwmGNOG/x7nAvK3TXjOC6j6Eo2ns0Llgl8RljOLvinQFos5www3lLv7Rj0xL9qVUScChd8uErAjE3MeClWvaV1RpKNVwbeVRxs9y8LSI1hoA+xWMGhSS6QsBBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XXcDueaga3PAiqwIM6PFvFf3CS/zSjPgnFDUZ8aS4FI=; b=amv477BBWTPZHx9pOmWvOvJHFjQtZ6TyYfgaj5nnMu7KqQ5q4V/dJd7HNebA/Mv6bLS9OJ1fzge8PMv4tWvwzo9P1oaY04e6mwNzhMJ1lcS3AxgWcIDvnDPEZcPtgo+5oRUk6lSAkbXJN8eMLkvAQ6BeSdZYpPWNqh0qi6ix/iixrEQjocIIn3js/qEQ+xglDuC0nvBbTgPi3JH1knYBJmmxBa/YCP2buvCg9EGTTakCFY8j7O2Bz0agTcB6skU3/oZltt/1q/DFw0az+XPbl64Eaftj1c8haQnYe0ImpaIVgtq3wc2cc8ZSP0fxNcYjd2TbUGErU1aKBtUaiN92PQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XXcDueaga3PAiqwIM6PFvFf3CS/zSjPgnFDUZ8aS4FI=; b=Y6yMEl4P3Xm3Fq6EQO1iwCX11oQep/v4tsZXyZ/iwP276K2U2fG3GoZhG5cZ7w5IcVPUdIKJO0JNnhWipL55zHFCotLjqlYL6PB0+VsPr2vDrvcbwx09tv6IF9oeHwhheclUHjlHqf8okmCLXjQjhIgTXgI2vAdmPNKYXHdrmv7HZlKdSYc9XxedE/bmZA00zoi3RDjlg9qOtCqVRdQ3GuaCfZ4oftEn7JMzuvJPQ0Vqlul45lTaWBVYmGnMmx7K4Z6FKwQtptCH8afK17hKm3ea+k1kMUCkhYJ9ch4/MM8MiDqPt8RBNF2iOYOL6VWXCfkMPZhV9gfLWYMQKq+z/w== Received: from DM8PR12MB5400.namprd12.prod.outlook.com (2603:10b6:8:3b::12) by DM4PR12MB5375.namprd12.prod.outlook.com (2603:10b6:5:39a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.32; Wed, 21 Jul 2021 06:23:04 +0000 Received: from DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::9cf5:169b:e9a5:5811]) by DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::9cf5:169b:e9a5:5811%7]) with mapi id 15.20.4331.034; Wed, 21 Jul 2021 06:23:03 +0000 From: Ori Kam To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , NBU-Contact-Thomas Monjalon , "stable@dpdk.org" Thread-Topic: [PATCH_v4 3/3] regex/mlx5: fix redundancy in PCI remove function Thread-Index: AQHXduyTCW5WJYnzJ0Ww/5QTMPUX5qtNA8EQ Date: Wed, 21 Jul 2021 06:23:03 +0000 Message-ID: References: <20210707120303.2490006-2-michaelba@nvidia.com> <20210712070644.2848418-1-michaelba@nvidia.com> <20210712070644.2848418-4-michaelba@nvidia.com> In-Reply-To: <20210712070644.2848418-4-michaelba@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fdbc0465-f17c-420c-3665-08d94c0fff3b x-ms-traffictypediagnostic: DM4PR12MB5375: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:628; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +JWtndA6Jc4x0ZBm+y+xsCJ6INMnc+bJc54SOkBzTX/AST23yaFe02bX+JF0WKb7pDr62ywErV5waDZhXmetV5aGOCwA5jlsyCAEk7t71U7WXWq5gAxsBFb6n3GJirh4fRcfO+C2weT/RmU3zi/5nA2vKWM0a98cRxB2l/ruE772t/3Nm4Ahc5UXto3/wqccT0RZKLTd73XQOGAg7+hJ/7gvq/YW4UCYVPzlCqD2/t1GUCuHBBoJeyMk3kWQNzC77hHo74pTjg9iAnWoyPapEbk7Tp3glQjnUnh8G5ExO3GwAHzo3E3+wxK/B1F+8Q3xBpE3Tw4xvop27zA6I/cjcPAY4UxBdKiJ6QYKV8K1GJO0NEoHuea5UgT9FgcwVS2njQJCuCmylxgBhCFeED//sQFb/beCrfxfo2ZOJe7l3g4HNLcICWTPjxOu0O3GzM5vJZ9OiMyLQC6EfLhQiVJ977T8kas4tQKkkRbgy7mQUQu7HMP/m9ZrzRf1BkUte3TA4sNBLlCTZO6hNydPP/jhjfx5uclVg6pwD5xIu5mEOOZ9TBoNeSIPV8dtTvVw/DMGrOUAj6qscJEyKzewIW9FsRoXjVw9JPDj7VQwM6nFK+X48obZ2Mb0u2692oJWb1XV+hUjcT24xEnzzPCGq2jm2tAmqPCNf/Ia9SiPePoHC0u6w59o4dKTz7kQdHdBCxlT/zl9HX97FSYWvcHMxjKbDA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR12MB5400.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(366004)(39860400002)(396003)(376002)(54906003)(86362001)(64756008)(76116006)(66556008)(66946007)(66446008)(4326008)(8936002)(66476007)(71200400001)(478600001)(52536014)(7696005)(186003)(6506007)(5660300002)(2906002)(83380400001)(9686003)(33656002)(38100700002)(110136005)(55016002)(8676002)(316002)(122000001)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tTPf5AZqDuyP0uoWjQVTiU6G6VWb7UfLcYGsnh0JjoCB+KJS9+67TUoVAkEm?= =?us-ascii?Q?CFb8Q0O+7uhx+Lt+Zbfa6nvUDtqnn+KC5iwifJG4ffeEa+ThR2tpa8E4udPc?= =?us-ascii?Q?yxK93W9yT3o/Co3zml3+3LPMlqRpu/BJc4ik/lzdXqUlj7ZcihNGFKkj0bVv?= =?us-ascii?Q?ESX4QisyQTYyzA49bL8oI1/e8l8MybCeHCWcPzpSkb7AfiPEm9o7GY//Li0r?= =?us-ascii?Q?UGSxYIj+s8V3ZIbYzwTRx01xUDugNxNi2MWK+aa2fPC9KUjxSVyCEdaD+Bqa?= =?us-ascii?Q?hfKa4uWMUX3EgltdFWuvCt4zTd75SL/9xD1V4kQo1LirvBXZnbwc1faDos6c?= =?us-ascii?Q?PCWcIGDiDfJGnJ3bekdN97asuLfouo48AQv0azqzIBE+JP99K3XG3344d2Lh?= =?us-ascii?Q?KtYU4DB22wbrWXZtMyIv5gCQlpBinwP5KPKCnyaBk0jxMzix9nIxRSLN4eKi?= =?us-ascii?Q?HGmlkVnrSZBNEItbkIdf+2zs4nGTX1vY1OzszEWGZFcTvPcdhn5V1asqAP03?= =?us-ascii?Q?OqfxD4EpTla1/o1Adk9n9InJxoF3I8VM5uDL1HRa6GQ/q62iA6ntX/ZuLx6V?= =?us-ascii?Q?EYkzKH4tg9vfPtnqlK3l2GvQP2nCGSJ+sG9iMBZGhX/kS1CvDgLFGXLTD1JF?= =?us-ascii?Q?bJ8vK1OEuMM1YTePHOD1LcTEsBq3wV5gRBaPqZvpAj3XAdx1KvY2JcewT/33?= =?us-ascii?Q?WZZdcGJUztBH4FIK9FBxvuQS96FO10Gr9b2sgf5flY503iyjwHlXGOKbBYry?= =?us-ascii?Q?EJkEl2OpSAleUzuHtNH2zVnt1K2lcfMbeEKjDsLlaSW5uvG7IILRylsvQqMk?= =?us-ascii?Q?Pk5D74FQ3GZ3m7GA4BHv39NKOqZUbgCNs9d+pRqEWASgAA+C71TBN1qaOZHU?= =?us-ascii?Q?nUPQpOHLCrw/u9XHXWy8XAj6tzI7r1VDOgqZRzOhnUeb3tFO7fgBFjKFe4MR?= =?us-ascii?Q?fPMh940g943zTk3HfJlIO4UxKKMTUqTxUpnwt9oUXXscAQ+NJUswCsna8wa9?= =?us-ascii?Q?dOSj++99rHVEIqyzcUuSdbUoDVq4eeUICnBkpta9depfQBwQv9tcSA1H6wKx?= =?us-ascii?Q?32ebNEkW563Czd7hrPQl/PTPtaPnPfhZe3bkA6BopsGBf3nTDWXf/CGl2iYE?= =?us-ascii?Q?WdEKOx3ZK5gXyZHZxr4HwOpTTPHf7Ot4wKpxfVSMnykAKhmpENsYrs/uZN6K?= =?us-ascii?Q?G7s277azSb0xpg713DlTiW6gmdee82zENQlVqYgs+3NqCbDcnsQxu1Qc791w?= =?us-ascii?Q?irfjrjOBEuRBdowodymsfNxgk7velCOp9YrtCvwykHhrr1ZoQIwJTAA7BgT3?= =?us-ascii?Q?yCrwN4ExuuR5lNrECO6w4G5O0RQmDAH6cT5Tvlo1tDNVWGJWGe6vOgreIbNO?= =?us-ascii?Q?bCI/9YUAvQOsXoJHnn4rToIRSLC0?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5400.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdbc0465-f17c-420c-3665-08d94c0fff3b X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2021 06:23:03.8851 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gMqYKDcVae7web7/7T9cfDofUbjruAY7VfNgjbANr6EaV2Q8B/VEzP+7PSqWh7gXO5T4kJeeY4Z9NyOXPOyn+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5375 Subject: Re: [dpdk-dev] [PATCH_v4 3/3] regex/mlx5: fix redundancy in PCI remove function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Michael, > -----Original Message----- > From: Michael Baum > Sent: Monday, July 12, 2021 10:07 AM > In the PCI removal function, PMD releases all driver resources and cancel= s > the regexdev registry. >=20 > However, regexdev registration is accidentally canceled twice. >=20 > Remove one of them. >=20 > Fixes: b34d816363b5 ("regex/mlx5: support rules import") > Cc: stable@dpdk.org >=20 > Signed-off-by: Michael Baum > --- > drivers/regex/mlx5/mlx5_regex.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/regex/mlx5/mlx5_regex.c > b/drivers/regex/mlx5/mlx5_regex.c index f64dc2824c..1c5bf930ad 100644 > --- a/drivers/regex/mlx5/mlx5_regex.c > +++ b/drivers/regex/mlx5/mlx5_regex.c > @@ -290,8 +290,6 @@ mlx5_regex_pci_remove(struct rte_pci_device > *pci_dev) > rte_regexdev_unregister(priv->regexdev); > if (priv->ctx) > mlx5_glue->close_device(priv->ctx); > - if (priv->regexdev) > - rte_regexdev_unregister(priv->regexdev); > rte_free(priv); > } > return 0; > -- > 2.25.1 Acked-by: Ori Kam Thanks, Ori