From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58D3BA0C47; Tue, 12 Oct 2021 17:31:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E20CC41149; Tue, 12 Oct 2021 17:31:56 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2070.outbound.protection.outlook.com [40.107.236.70]) by mails.dpdk.org (Postfix) with ESMTP id 3E0844113A for ; Tue, 12 Oct 2021 17:31:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RTgqwz6R9E6xSdWKwkCnutkOz6bmCg8jjsSrAXj49MjnH9LUQZUc++EeefIvDfop++SZeYvr/8GGppoCj5eW7XN7Q7NJ4Awl3KtrozHCV1gyGO4GoXR9ejZ5qs9Q3LXa2TRoyU25n6Wbrq787y062Xp5Yju4l+QsxcH2X0/WgoR8tXsT/x0IH/z/wTi1h5NnZWNlE1A/0VjyTB9nf1DPTqM5O3UQBbTji9svajfk9E5pJL3iJijIM6Imp3FRVuGKispH2ErIGvxMXt5LgavdTkEBwyfgolkXMBaPz1G4nF1+KSJGGjqUKHAAc8Gek8TClE8/PHXyaQXbgXDxq8ZnCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OdWgWXcC8nPlL2N5YeK0VbXpq7AYxQXBctwIyscxYmg=; b=CapBUoblVpZzh8Ni7s6CWVv5XnFSEu+lTqcu67M1Du3Pn8ONC9/lP/2uao6twccrAID79mv02k43cDHeD1Ma633swISN2ysfUhTUUEDBEhhaoUdYWUIZPdH1Tww69uw647IJDnKXQxFylhaHw0/RBTIdRmJT8HRXGiLOnjDO6Y3A7fMGHtRYP54+JuY/3vMj8uiHv4nMz22/VqWis56h9bvuJIWJM2vv1ZSAQbH86b5rnqnY8xyqjwBa4tAhxJlc7zy6ejIAtk+KqCaFKRUGCJ37wmrtXVrok7ydpoiJsjwe6jqHN60vB3uo5IOOlWV/6skDyYfFXqvE6pZPriX0lA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OdWgWXcC8nPlL2N5YeK0VbXpq7AYxQXBctwIyscxYmg=; b=Q5mkJJxFM/PIfL+NI+0BpjrwP3Z0hmRE5Y6INdvspL2jKAEK3e2SUv0BbzX0yzkcHha3RSSR9eLkELkdFqAqxV81bu13oSQnu94bedtNs8gyTRT3YOUFQFDHv1Mxsf2cDnvAxCH0T2WPdYIadgtvEXSU/6MHuQiGBEwv6dO0YVK74HzVLiK6EZ+DSjcmaA5sgl2xtgrBxaHhueiPqWPZcbZUr+B8uWBB1gxR/6XrCch4oYFmkTcRVJX56hltk0ox9HC+6NxlhRt7bvoa7D8LOZlwV6vIRp/QxtBpntrj67Lu/jq4Gdxig9OyLUOCLc68KO12xpR2kaVm6X+IWcrmRA== Received: from DM8PR12MB5400.namprd12.prod.outlook.com (2603:10b6:8:3b::12) by DM8PR12MB5430.namprd12.prod.outlook.com (2603:10b6:8:28::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct 2021 15:31:53 +0000 Received: from DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::d03d:1f75:ca20:6a32]) by DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::d03d:1f75:ca20:6a32%6]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021 15:31:53 +0000 From: Ori Kam To: Jie Wang , "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , NBU-Contact-Thomas Monjalon , "andrew.rybchenko@oktetlabs.ru" , "xiaoyun.li@intel.com" , "stevex.yang@intel.com" , "jingjing.wu@intel.com" , "beilei.xing@intel.com" , "wenjun1.wu@intel.com" Thread-Topic: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUDP RSS Hash Thread-Index: AQHXv1OCpPBKXWRmrkKXclbfiXpBX6vPfU6w Date: Tue, 12 Oct 2021 15:31:53 +0000 Message-ID: References: <20210924151705.287571-1-jie1x.wang@intel.com> <20211012102508.275790-1-jie1x.wang@intel.com> <20211012102508.275790-3-jie1x.wang@intel.com> In-Reply-To: <20211012102508.275790-3-jie1x.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e91a3530-4c8f-449f-5c91-08d98d956b35 x-ms-traffictypediagnostic: DM8PR12MB5430: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1uiEDl/MZg3QK8UF+dEfB40fAROhXhDrGaCW8rwojPR5rPZb9BRIBA8S5ys1BjNYJ2pN/CYaPd/VSjkOr3mYG1fyLlk9I3oVbuagOH7ZGYmsZtU27Y6gr0sOQ/LwRWj37iRu0ZkH9DssR080kEVBMyw1/Ev42jnflH1MsQTShNlH3OGcYkS6SL26wFSiB7gOgAqvBJ3Uu79C8wUtekF2RtXvIOclj7dVPmGI8xz6PgNTjPn4R2m7GcdjM675QJWR6VuKN07GGzNAB28L57NTZCLTXT+4Kq2GF0GFBcrBTztoahOz1BgKY48Ktr07I8dLV0x1l4Uz/KM6qJkuQC6/28bSmqGx7+WxpzOkwx48IM0QMnTmGW9gnNBcvRR4pT4HFPUFOZx2fRyP1FNFycs+pkpvNMmdj2XE4X14qdkKTAhKUY4jgp7pXdTTjuhGdJQecMVwpyoNR9CirXuQvRoXuEVddalPga9MWpYs6lmEagP1qtGBCxcNXKogfnCbqFfpE/6r0HEVVFdGzhFlcz9xhNxSrNnVqGT6MbRtiFImQqkbq1hJ3DMyDQzeAmYI7tgMyAel8eraca8MZpeXd2ceZM72vsp4+T9wQ4Jx4wW1cxaKv5IPJGYSPF3DrRtTGekVjYOHrrEFByiLt0b+CTtWqn1dql3sNgTOrNr8vMMmM08Kqdf6ve1Nsp5Fk2QSoxHt31PXs2lCg55OL9bgV/9GNQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR12MB5400.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(508600001)(122000001)(38100700002)(52536014)(8676002)(86362001)(55016002)(83380400001)(33656002)(8936002)(5660300002)(66946007)(316002)(110136005)(186003)(26005)(2906002)(53546011)(54906003)(64756008)(38070700005)(66446008)(66556008)(71200400001)(7696005)(7416002)(76116006)(6506007)(9686003)(66476007)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3X1vZCIm4JNxrejwgZeezdXaXPT0nQNTikVv08WZtZ+x5kfmtFjHFnmJ2PQV?= =?us-ascii?Q?oHzKLjW0LRt6oAaRb9Tq/87r6FUT1ozXg56kaU5oPK80AJrgN0npl9HMkx5+?= =?us-ascii?Q?7/XyLoHTkIHBq9ehHgwbl+0eUWfyIaLBdlPh2R5GXDhM0xmCcik/zK9YQk2S?= =?us-ascii?Q?MRnGD8881cRWZGBj1cB2ONO5uTC2fi1L74kf17zTnolh244/SZ9Jc4Cmd3ee?= =?us-ascii?Q?EQ43I/J8VSY3BA/1hXfzVrwhmT9eEs2EtgoLuxCj+Bo0xyy2y+HYhZmndfsD?= =?us-ascii?Q?knkHYk/5WfAoxviD3afcte+1FI1hLul032be/UXajBqtnGjNd/P7TA+JimsH?= =?us-ascii?Q?RMaVnHUQgkv8uLaBfh97Dhs4CN7vIciSAIDKUvSQv3b6Gs0WrwdW/RBMvZJs?= =?us-ascii?Q?WH/7NqslgbjBYL1IPD9EsDMUnoaJMKJsvOQ08G+G8NtkRS6GnLX9k/JZXnjC?= =?us-ascii?Q?a9xDx+5IXifRSVu1sCxaed0+V7RAQxA9pF2qUgt63IPgXVkhNsvsZq0hOOM/?= =?us-ascii?Q?Iqex8myP0AdTAOJC5dp7lWxv1xgb8hWFqRb/GULPWOphPr4zQUSmsvDrlyNI?= =?us-ascii?Q?ZtzRSrQT5gOa3S5H/mEwMP6f5ViN/xWQ2HinVngVIYqEP5MikHTuVQ5PAxhV?= =?us-ascii?Q?grTCgEuWpGz9ibJzZylSL36GiDYIHFoFkFiGDPZWXrfQuaXWbl5tbWpuQ/41?= =?us-ascii?Q?KFpbSGNdOz5TYbP4Xk5v/UOYju5flTFnskI4MNgpzZvQBXKiL3LXKv6isPkP?= =?us-ascii?Q?xFQK4I6iFmzLyP5oSPuejjZgNRinuhGlS1aeHTG6xj0ewg/OzztW04upMGIp?= =?us-ascii?Q?4l9RZcGJFJ765vML1AOYbAuVZeWr1VJxsHe0cRnvOt4kFLnQ0JGvYrMg5gV5?= =?us-ascii?Q?njI8NJGi//vC7zS2V/fYCKW4tHSDPgS9F4S0bL/yB04ETUigCkoFn06aqV+D?= =?us-ascii?Q?ekExJB96+5I8AjIwet+v7dY8mHjnoGFzdHK0opkY/KWjc2Mlje3VNeaejlyG?= =?us-ascii?Q?sXcm8cfdL0YlM0nucbKWMtWI01Nj16u0/v1kIEsf3fN29NvoMuDVr8yvmkhs?= =?us-ascii?Q?s8iW/H4agBQUHh8pgmehA+BaSCBzsbJeNO9otYbUaT0CiqOZ2PoD9t2busfq?= =?us-ascii?Q?uI60XwCvVt6I3+QsjMIanVMOqwi8nh0qh1oYB7+71PyW/ePt39YzMgoEL6F3?= =?us-ascii?Q?hAs8fxh2nKBZQoFv7gRSRg6G1D8RBKn0uhnsYiHU9KSHT8V7jqgM3tUq4qED?= =?us-ascii?Q?Gi6o4VejEGKH16//xMebdlQ9RSC/k42Ljv92GWnDtjU9Gkp/ezxQj4tH9TpJ?= =?us-ascii?Q?AZfUTtXdmg1srdAS6MjlehSP?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5400.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e91a3530-4c8f-449f-5c91-08d98d956b35 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2021 15:31:53.6564 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j5Y0FWayhvLdDaLKQBBTsZOIdHEwwoqxMWbggxu+kSfATf3CEDjzWOf773cTAQqFc3QkAwDDK7nu4oYZpZwifw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5430 Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUDP RSS Hash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jie, > -----Original Message----- > From: dev On Behalf Of Jie Wang > Sent: Tuesday, October 12, 2021 1:25 PM > Subject: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUDP RS= S Hash >=20 > Add support for test-pmd to parse protocol pattern L2TPv2 and PPP. >=20 > Signed-off-by: Wenjun Wu > Signed-off-by: Jie Wang > --- > app/test-pmd/cmdline_flow.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) >=20 > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c in= dex > bb22294dd3..3c9bcabd97 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -299,6 +299,8 @@ enum index { > ITEM_GENEVE_OPT_TYPE, > ITEM_GENEVE_OPT_LENGTH, > ITEM_GENEVE_OPT_DATA, > + ITEM_PPP, > + ITEM_L2TPV2, > ITEM_INTEGRITY, > ITEM_INTEGRITY_LEVEL, > ITEM_INTEGRITY_VALUE, > @@ -997,6 +999,8 @@ static const enum index next_item[] =3D { > ITEM_AH, > ITEM_PFCP, > ITEM_ECPRI, > + ITEM_PPP, > + ITEM_L2TPV2, Why in the middle? > ITEM_GENEVE_OPT, > ITEM_INTEGRITY, > ITEM_CONNTRACK, > @@ -1368,6 +1372,16 @@ static const enum index item_integrity_lv[] =3D { > ZERO, > }; >=20 > +static const enum index item_ppp[] =3D { > + ITEM_NEXT, > + ZERO, > +}; > + > +static const enum index item_l2tpv2[] =3D { > + ITEM_NEXT, > + ZERO, > +}; > + > static const enum index next_action[] =3D { > ACTION_END, > ACTION_VOID, > @@ -3579,6 +3593,20 @@ static const struct token token_list[] =3D { > (sizeof(struct rte_flow_item_geneve_opt), > ITEM_GENEVE_OPT_DATA_SIZE)), > }, > + [ITEM_PPP] =3D { > + .name =3D "ppp", > + .help =3D "match ppp header", > + .priv =3D PRIV_ITEM(PPP, sizeof(struct rte_flow_item_ppp)), > + .next =3D NEXT(item_ppp), > + .call =3D parse_vc, > + }, > + [ITEM_L2TPV2] =3D { > + .name =3D "l2tpv2", > + .help =3D "match l2tpv2 header", > + .priv =3D PRIV_ITEM(L2TPV2, sizeof(struct rte_flow_item_l2tpv2)), > + .next =3D NEXT(item_l2tpv2), > + .call =3D parse_vc, > + }, > [ITEM_INTEGRITY] =3D { > .name =3D "integrity", > .help =3D "match packet integrity", > @@ -8343,6 +8371,12 @@ flow_item_default_mask(const struct rte_flow_item = *item) > case RTE_FLOW_ITEM_TYPE_PFCP: > mask =3D &rte_flow_item_pfcp_mask; > break; > + case RTE_FLOW_ITEM_TYPE_L2TPV2: > + mask =3D &rte_flow_item_l2tpv2_mask; > + break; > + case RTE_FLOW_ITEM_TYPE_PPP: > + mask =3D &rte_flow_item_ppp_mask; > + break; > default: > break; > } > -- > 2.25.1 Maybe I'm missing something but I don't see that you added the ability to m= atch on any of the header fields value. You also didn't update the code of encap (from my understanding this is a t= unnel header) Best, Ori