From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7456A0C55; Wed, 13 Oct 2021 12:19:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9505E410DA; Wed, 13 Oct 2021 12:19:21 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2042.outbound.protection.outlook.com [40.107.102.42]) by mails.dpdk.org (Postfix) with ESMTP id 9013840E64 for ; Wed, 13 Oct 2021 12:19:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lksq8dZYxVDSmCFzBulrtC26DKCLT+nRcxGg1lz15BqtYI0/A98nrINena/qIlm/6j44T3bDec/Xs06ckq09HuUWbVufydC8oXivQ28kEaL49QsHdnfg8zygXHx5hy4gvItre1lS7x0zCJifF+p3SAM+5ZMN6jIkx1bMCThOVJzRRWFVPXplk/wDqZjLuQzuUqcGhdfGXYAuESeTEWG92B9xzutmTFhT2Sp6OrbLDbHFW93IO6OVVrolD5sMMuPTtU7kfUUNWDYZSTbug/zCTqnyEsfYPoh3Gxc02luhRUMt5yePoLv2/nvyD1e/XxiGMoLF5o13TSeGLl7fHUteQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nhmzBsU9UTGgk2Cxuk7w5/R/dGHyZiNmzEFk5vDGd9o=; b=ii0oSii7n633HLS9iXqZn0fGCmbIA1x27kJ2mPltr0S6HEHCVvm2sHElZxdMhdQ5jPdhYVD8QUmKx7X84EBbiiEYGBrc/ymEKW5vlyczQRJPDM9jR1TTm08Q7ddwdV71mp46nC+y1LU5o19cJIv4yQJ21gAPNsw5bVSncxG85edvDOtIdf0zSPtdgRDy7hJR1FOgDXszGoWqvew63N1IZ9Ta11+8HCLIDbbfuc8U/8AkmZRJc7I9RG+jJoP8Vbf/YV5/l0jxyiGpVm9OBbuhDRdyk1Gyn9mkfcCxkmzAnH2Q16ICj3VI5JO3nJqxwcy3Ypmy4xlRDVDx+nt0Slt6Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nhmzBsU9UTGgk2Cxuk7w5/R/dGHyZiNmzEFk5vDGd9o=; b=emd8QomZJiNxHHyAQ+AeybFMEExI82KfRq4DCekuzQh/jHgMY9fAREYSsRJ+oi1JK1GqFzvBXjlGbJJY9364dQxNNzjszjmb931RhBCXZUMw8V28xiGFEq1D60q3W82NBQTgzZiWVZA0EjRsZKMErV7rZ6hzn/UeBq+usljRa3cf6Qs6SfG6CW4uPD3kphZkfd5iKtIYn9OLeBw+VlyWPcVyo8kLg+5UZ7Jo8Irt6GeL4sOZUL5HGHqlZIzcMm1l2YQv189JW8e6RS3wtcel2uXLy3jJkZEVU9pJAPqNCmtd4zTAz6oQYaDG9r9pEFkKNGD5GF2ZWE3guTKrMw2PTQ== Received: from DM8PR12MB5400.namprd12.prod.outlook.com (2603:10b6:8:3b::12) by DM4PR12MB5053.namprd12.prod.outlook.com (2603:10b6:5:388::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Wed, 13 Oct 2021 10:19:19 +0000 Received: from DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::d03d:1f75:ca20:6a32]) by DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::d03d:1f75:ca20:6a32%7]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021 10:19:19 +0000 From: Ori Kam To: "Wang, Jie1X" , "dev@dpdk.org" CC: "Yigit, Ferruh" , NBU-Contact-Thomas Monjalon , "andrew.rybchenko@oktetlabs.ru" , "Li, Xiaoyun" , "Yang, SteveX" , "Wu, Jingjing" , "Xing, Beilei" , "Wu, Wenjun1" Thread-Topic: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUDP RSS Hash Thread-Index: AQHXv1OCpPBKXWRmrkKXclbfiXpBX6vPfU6wgAEZH4CAAA/SAIAAC56AgAAFeRA= Date: Wed, 13 Oct 2021 10:19:19 +0000 Message-ID: References: <20210924151705.287571-1-jie1x.wang@intel.com> <20211012102508.275790-1-jie1x.wang@intel.com> <20211012102508.275790-3-jie1x.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5df3e73b-c12d-4835-6e94-08d98e32eb24 x-ms-traffictypediagnostic: DM4PR12MB5053: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cYolqPjKxc/ltSksY/XeiQI5E1V8ke7DySB8K6VlnsQLACrfxLwzCLrK34pltx4BQxfbauGLLFNMKZUcOWXNKFnpdNZL2y3HbVxupDbmbX4o2Od+vIeVwj22KYBNiDO+ZRGrOFdf5tRkHZCsGbWxvxpiHFs4oP64POIAzV9z8EjKoA7QcZ+fg7nxu1wUHuqFJ+WcoSgOJh08BP24suhHvZ2ugenCV/rV9QlN9BxSC8PVnoQA4JBPO7tu6aXAkzW66+smRR4MjsMX5401LnIPp/6BgfALQY8Ggf2CDZosiu5Gjehh+WTstYdFNlNucZ5Iuzj/YWKw0aWqC4SATWCIt9vh4EMPgP1D0k6DgZAWSAziA+al0jUOeEsqnU888T0RqRlQqr5rC6osw/VswONmrrbxmrhNxdyOVmxcyL89berQxQpkWVRCR9tsA/TdnLiBCRrXa/FRJLssRMPBns85gZBzrdZIMn5K9F0qwjo6Kb/3ZhSfR9IJzRy5ykppcNjnCWkla4e6OrcrN8JV2ha60gWhpxHkrQwdZkapxXikNPPysWeNQTGjX78RRC6/Gk5oJ4oIf+KvqljXy55GOIEormclrM+sFH5KAn7uvMFM0kj/8DGugdVRIFJBJM1Rlmv+Fh/BnHg8zfD3/yorIn0znq0iNLSaHRYTZPRlCzxsO3bH0/PDYQtg4eTO8ozvW3ClVEtM+i4A5ADVksltU1BSHw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR12MB5400.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38100700002)(38070700005)(122000001)(55016002)(8676002)(2906002)(5660300002)(186003)(316002)(110136005)(66446008)(64756008)(66556008)(66476007)(4326008)(86362001)(54906003)(6506007)(33656002)(83380400001)(66946007)(9686003)(8936002)(71200400001)(76116006)(53546011)(52536014)(7696005)(7416002)(508600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3o1r+PPr8zvQYIhrf1pMfstHRmn5sutVibEzwoiYf3fT692XD/pBGIHTUq6Z?= =?us-ascii?Q?F5MKgTT1NDfVq6JBRZ11134rL9SbJTHfXw9/hRXRxUAfssWjBxARo7mbt3ln?= =?us-ascii?Q?qAbQLQDJp/GCvf+wmrHkieWVDBYZeFCQA/CGzjVxjq4vl7xKE/lZxX+FppXH?= =?us-ascii?Q?c10vmxOa4TEYmnG7jGqFO/J795MF0rPiQOSp85+3Lj6CIB5ZwhaktXpo/0TD?= =?us-ascii?Q?XcetmBiVj2+uB0wI2ZKZ+QXQfHVSKpd95Eq3SWWhD9H/Tdv5Teu3h+JdjkMu?= =?us-ascii?Q?3l/u0UNES1pNWW0sU+wTUETJfXZ84m2EuPmotGKXELrgidqUXSZDEDGmW2TJ?= =?us-ascii?Q?U1hynygPMXxMn9PrhMZglh6Cno2TmIdDfNoKTGzbxdJKVgtFfPkkDcKBPH8J?= =?us-ascii?Q?zd5AO+HYr33c37W75gNWxvMgZmHOXlu9vN6UQN4pqDRdsk/2iavckLzs8uTD?= =?us-ascii?Q?Ph2K0+xyVwCjBSvuyLkuSFoR+bTL7Dmbxux20NxPrSwgAnEhDDcyhCqQKg4u?= =?us-ascii?Q?29phfqMPFiOeMi6pD0zfcuI6MsPIV/Y7NMbGh+rKCtfZSOWIbRAVW4H94R7C?= =?us-ascii?Q?VNzp/R/BRcFeIPPTvJGh3mCw1LFEQDQNTUaaiqfzkDAb7kO4UmxZAnxh2E8S?= =?us-ascii?Q?GRqRbzN2YWeLM4fJvCpi/9m3rMo4wSZ4oNliyhiAeSC1h8yRbI+SYaGyThy8?= =?us-ascii?Q?F6/GeuXLusWMvYLe1Ousqq+uP1wB/4cF3ubqxJkpbJjnM9LRq+zgkyE1WvSQ?= =?us-ascii?Q?cZHrX4xfl8WFN9QZvT/cJ4xmsXHlDKUY3f8kwbcs4nLSDwMlZ8IkoE0162PL?= =?us-ascii?Q?WB2IEBe45aU9E5C0vmM3oyLI8njhq2J3CgHWmVn/VWAqQHlFM89zRsx0uUzn?= =?us-ascii?Q?OXvfZMcXHemrCke/je/0AYkNF+F3L6GdQK47oEX6eZKnbM1N94/IPGEefIFf?= =?us-ascii?Q?1YGe/kcLZLpn3PHWz9LJeu3oMwJNnUHH1xfl18G9bpr765JQAAxk46Wj03yk?= =?us-ascii?Q?ddGssFPTs7EV4gAkpVd3VxpVONxWLx+CnZ8AoETkfif/mH2H+REI1zK8Xl1R?= =?us-ascii?Q?pEOdDkeZJbee32uOKOin5WKUAm4jTM1dIboPCvENsuGVYik1FCh3reJOVIXz?= =?us-ascii?Q?c/O37xuMTwgYT9NYsmJRbh5Yh8xhDsm+aKm9pujoNRdPiFteFq4+Zh6sDsqu?= =?us-ascii?Q?NgRLv7bLlW8RCi0/b8J1JOuA8C5I2jInjKNEwD7Y8xfhrB31C3dvTuao7odb?= =?us-ascii?Q?z/jH+VnjuDT5vUv2+TbyFasCvoyuNRA7UXs28emDJIsjHucOsTgEwFgapSZG?= =?us-ascii?Q?aLUgHDwHHrX468n4ijNBWJkKN3Y+HWJNexlZYi/lhItMETN6hgZD0pPGbF3N?= =?us-ascii?Q?cqTpeobkpfjGLw7tQnPgLA8iC9VM?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5400.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5df3e73b-c12d-4835-6e94-08d98e32eb24 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2021 10:19:19.3311 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oX1/82vVb/ZFY8V0rpxi3vECMT2TV4nRxZxf3fTy/1C28dYZ5f7EYhv6YsuNm+n5TikJVJyRyDrtHibUHxrJpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5053 Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUDP RSS Hash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, Jie1X > Sent: Wednesday, October 13, 2021 12:54 PM > Subject: RE: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUD= P RSS Hash >=20 >=20 >=20 > > -----Original Message----- > > From: Ori Kam > > Sent: Wednesday, October 13, 2021 5:15 PM > > To: Wang, Jie1X ; dev@dpdk.org > > Cc: Yigit, Ferruh ; NBU-Contact-Thomas > > Monjalon ; andrew.rybchenko@oktetlabs.ru; Li, > > Xiaoyun ; Yang, SteveX ; > > Wu, Jingjing ; Xing, Beilei > > ; Wu, Wenjun1 > > Subject: RE: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support > > PPPoL2TPv2oUDP RSS Hash > > > > Hi Wang, > > > > > -----Original Message----- > > > From: Wang, Jie1X > > > Sent: Wednesday, October 13, 2021 11:16 AM > > > > > > Subject: RE: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support > > > PPPoL2TPv2oUDP RSS Hash > > > > > > > > > > > > > -----Original Message----- > > > > From: Ori Kam > > > > Sent: Tuesday, October 12, 2021 11:32 PM > > > > To: Wang, Jie1X ; dev@dpdk.org > > > > Cc: Yigit, Ferruh ; NBU-Contact-Thomas > > > > Monjalon ; andrew.rybchenko@oktetlabs.ru; Li, > > > > Xiaoyun ; Yang, SteveX > > > > ; Wu, Jingjing ; > > > > Xing, Beilei ; Wu, Wenjun1 > > > > > > > > Subject: RE: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support > > > > PPPoL2TPv2oUDP RSS Hash > > > > > > > > Hi Jie, > > > > > > > > > -----Original Message----- > > > > > From: dev On Behalf Of Jie Wang > > > > > Sent: Tuesday, October 12, 2021 1:25 PM > > > > > Subject: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support > > > > > PPPoL2TPv2oUDP RSS Hash > > > > > > > > > > Add support for test-pmd to parse protocol pattern L2TPv2 and PPP= . > > > > > > > > > > Signed-off-by: Wenjun Wu > > > > > Signed-off-by: Jie Wang > > > > > --- > > > > > app/test-pmd/cmdline_flow.c | 34 > > > > > ++++++++++++++++++++++++++++++++++ > > > > > 1 file changed, 34 insertions(+) > > > > > > > > > > diff --git a/app/test-pmd/cmdline_flow.c > > > > > b/app/test-pmd/cmdline_flow.c index > > > > > bb22294dd3..3c9bcabd97 100644 > > > > > --- a/app/test-pmd/cmdline_flow.c > > > > > +++ b/app/test-pmd/cmdline_flow.c > > > > > @@ -299,6 +299,8 @@ enum index { > > > > > ITEM_GENEVE_OPT_TYPE, > > > > > ITEM_GENEVE_OPT_LENGTH, > > > > > ITEM_GENEVE_OPT_DATA, > > > > > + ITEM_PPP, > > > > > + ITEM_L2TPV2, > > > > > ITEM_INTEGRITY, > > > > > ITEM_INTEGRITY_LEVEL, > > > > > ITEM_INTEGRITY_VALUE, > > > > > @@ -997,6 +999,8 @@ static const enum index next_item[] =3D { > > > > > ITEM_AH, > > > > > ITEM_PFCP, > > > > > ITEM_ECPRI, > > > > > + ITEM_PPP, > > > > > + ITEM_L2TPV2, > > > > > > > > Why in the middle? > > > > > > > > > > Ok, I will update it. > > > > > > > > ITEM_GENEVE_OPT, > > > > > ITEM_INTEGRITY, > > > > > ITEM_CONNTRACK, > > > > > @@ -1368,6 +1372,16 @@ static const enum index item_integrity_lv[= ] =3D { > > > > > ZERO, > > > > > }; > > > > > > > > > > +static const enum index item_ppp[] =3D { > > > > > + ITEM_NEXT, > > > > > + ZERO, > > > > > +}; > > > > > + > > > > > +static const enum index item_l2tpv2[] =3D { > > > > > + ITEM_NEXT, > > > > > + ZERO, > > > > > +}; > > > > > + > > > > > static const enum index next_action[] =3D { > > > > > ACTION_END, > > > > > ACTION_VOID, > > > > > @@ -3579,6 +3593,20 @@ static const struct token token_list[] =3D= { > > > > > (sizeof(struct rte_flow_item_geneve_opt), > > > > > ITEM_GENEVE_OPT_DATA_SIZE)), > > > > > }, > > > > > + [ITEM_PPP] =3D { > > > > > + .name =3D "ppp", > > > > > + .help =3D "match ppp header", > > > > > + .priv =3D PRIV_ITEM(PPP, sizeof(struct rte_flow_item_ppp)), > > > > > + .next =3D NEXT(item_ppp), > > > > > + .call =3D parse_vc, > > > > > + }, > > > > > + [ITEM_L2TPV2] =3D { > > > > > + .name =3D "l2tpv2", > > > > > + .help =3D "match l2tpv2 header", > > > > > + .priv =3D PRIV_ITEM(L2TPV2, sizeof(struct rte_flow_item_l2tpv2= )), > > > > > + .next =3D NEXT(item_l2tpv2), > > > > > + .call =3D parse_vc, > > > > > + }, > > > > > [ITEM_INTEGRITY] =3D { > > > > > .name =3D "integrity", > > > > > .help =3D "match packet integrity", @@ -8343,6 +8371,12 @@ > > > > > flow_item_default_mask(const struct > > > > rte_flow_item *item) > > > > > case RTE_FLOW_ITEM_TYPE_PFCP: > > > > > mask =3D &rte_flow_item_pfcp_mask; > > > > > break; > > > > > + case RTE_FLOW_ITEM_TYPE_L2TPV2: > > > > > + mask =3D &rte_flow_item_l2tpv2_mask; > > > > > + break; > > > > > + case RTE_FLOW_ITEM_TYPE_PPP: > > > > > + mask =3D &rte_flow_item_ppp_mask; > > > > > + break; > > > > > default: > > > > > break; > > > > > } > > > > > -- > > > > > 2.25.1 > > > > > > > > Maybe I'm missing something but I don't see that you added the > > > > ability to match on any of the header fields value. > > > > You also didn't update the code of encap (from my understanding > > > > this is a tunnel > > > > header) > > > > > > > > Best, > > > > Ori > > > > > > Hi Ori, > > > > > > This feature is only support for iavf enable PPPoL2TPv2oUDP rss. So > > > it doesn't need to add the ability to match on any of the header > > > fields value and > > the code of encap. > > > > > > I'm not sure if it is necessary to add these. > > > > You added a lot of fields in the rte_flow and you don't give any way to= test them. > > also Iike I said in previous patch what is the relation between > > matching items to RSS? > > You didn't add it to the RSS possible support. > > > > Best, > > Ori >=20 > The feature apply a RSS rule on L2TP data packet (include PPP over L2TP) = with inner IP / port as input > set. > It doesn't need match any L2TP field. Just to be clear when you say RSS on mean RSS on ipv4+udp for example not o= n the ppp header itself right? If so then the title should just state that you are adding new items (also = for other patches) since I can use this item to jump to other group or count or any other acti= on. This patch dosesn't have anything to do with hash. I understand that from your point of view you don't need to match on any fi= eld, but you added such fields and no one can test it and no PMD support this so this feature is not valid. Best, Ori