From: Ori Kam <orika@nvidia.com>
To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Slava Ovsiienko <viacheslavo@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Subject: RE: [PATCH v3] ethdev: deprecate header fields and metadata flow actions
Date: Wed, 24 Nov 2021 18:09:31 +0000 [thread overview]
Message-ID: <DM8PR12MB5400D0AA3DA689D90E681123D6619@DM8PR12MB5400.namprd12.prod.outlook.com> (raw)
In-Reply-To: <3238712.SzvLOqgLnN@thomas>
Hi
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, November 24, 2021 7:33 PM
>
> 24/11/2021 17:37, Slava Ovsiienko:
> > From: Ori Kam <orika@nvidia.com>
> > > From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> > > > Action: ``OF_SET_MPLS_TTL``
> > > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > > +This action is deprecated. Consider `Action: MODIFY_FIELD`_.
> > > >
> > >
> > > Since no PMD support this action why set reference to MODIFY_FIELD_?
> > > Same for all unsupported actions.
> >
> > There are some references to this action in PMDs (for example bnxt),
> > but the ENOTSUP returned. I.e., action is in source code, but actually
> > not supported. Hence (due to this and in general), we can't just occasionally
> > remove existing actions, we should deprecate these first.
> > Other point - if someone will decide to implement support for this
> > action in his/her PMD - the deprecation notice will point out the right way -
> > "consider MODIFY_FIELD."
> >
If someone will want to create such action he can see how all the rest of the actions are done.
I don't think we need to point a user incorrect path.
> > >
> > > > Implements ``OFPAT_SET_MPLS_TTL`` ("MPLS TTL") as defined by the
> > > > `OpenFlow Switch Specification`_.
> > > > @@ -2254,6 +2255,7 @@ Switch Specification`_.
> > > >
> > [..snip..]
> > >
> > > If no PMD support this why do we want to add it to the modify_field?
> > > Same for all of the unsupported actions.
> > As I said above - we just propose to consider MODIFY_FIELD actions
> > if someone has intention to implement deprecated OFPAT_SET_MPLS_TTL.
>
> It was an API, we must guide the API reader in the right direction.
> BTW, it can be implemented in a driver which is not yet upstream.
>
So you think we should keep it?
The guideline is that if there is no implementation it should not go in.
I see that this API was added in 2018
if someone is using this API let him rise his voice.
next prev parent reply other threads:[~2021-11-24 18:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 7:59 [PATCH] " Viacheslav Ovsiienko
2021-11-24 8:06 ` [PATCH v2] " Viacheslav Ovsiienko
2021-11-24 14:56 ` Thomas Monjalon
2021-11-24 15:37 ` [PATCH v3] " Viacheslav Ovsiienko
2021-11-24 15:59 ` Thomas Monjalon
2021-11-24 16:21 ` Ori Kam
2021-11-24 16:37 ` Slava Ovsiienko
2021-11-24 17:32 ` Thomas Monjalon
2021-11-24 18:09 ` Ori Kam [this message]
2021-11-25 11:53 ` Ferruh Yigit
2021-11-25 12:03 ` Somnath Kotur
2021-11-25 13:06 ` Thomas Monjalon
2021-11-25 14:13 ` Slava Ovsiienko
2021-11-25 14:40 ` Ferruh Yigit
2021-11-25 14:52 ` Slava Ovsiienko
2021-11-25 14:15 ` Ferruh Yigit
2021-11-25 13:56 ` Slava Ovsiienko
2021-11-25 15:14 ` Ferruh Yigit
2021-11-25 15:53 ` Thomas Monjalon
2021-11-25 12:18 ` Ferruh Yigit
2021-11-25 12:29 ` Ori Kam
2021-11-25 12:46 ` Ferruh Yigit
2021-11-25 13:56 ` Ori Kam
2021-11-25 14:28 ` Ferruh Yigit
2021-11-25 12:31 ` Ferruh Yigit
2021-11-25 12:50 ` Thomas Monjalon
2021-11-26 9:51 ` [PATCH v4] " Viacheslav Ovsiienko
2021-11-26 12:53 ` Ferruh Yigit
2021-11-26 13:06 ` Thomas Monjalon
2021-11-26 14:52 ` Olivier Matz
2021-11-26 17:07 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR12MB5400D0AA3DA689D90E681123D6619@DM8PR12MB5400.namprd12.prod.outlook.com \
--to=orika@nvidia.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).