From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8449A426D0; Fri, 6 Oct 2023 14:35:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D951402C8; Fri, 6 Oct 2023 14:35:55 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id A0F6E400D7 for ; Fri, 6 Oct 2023 14:35:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696595752; x=1728131752; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vGH8JjHWLm7amcrTMSAFX4KhxTa5PZy4bKFe5TMDHqA=; b=bDnKISGb12Nofv004X5600NjYv5wPcYF6gBuskAwkrNer5St8Ev9f3Xb 32s1scz1jaJVr4s7ewWVsY//H+jEYvsG06X+3C3YS16hToSVXyjMGUK8K JhUdCvsRg2VLlJpw0C7/0PoYpe/EVcao0fp1l4fzgCoa0+qGXRYTZ/LEY +srKwldeefozpVu3u4TGVWZUMZ/af5iOk4yBs1XRTDMFEPTgjaR9o0bfH PpW7QEo320IemKssmDGIaBx1caySYAzOwxaNtujDCUXTwRtCcJoeUAlJM C2ZEMLoijwxRJN3AdvzrBb+MmUzYajXG7YnUDqSpNcwi+Aa4kFasT+2wc Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10854"; a="368816425" X-IronPort-AV: E=Sophos;i="6.03,204,1694761200"; d="scan'208";a="368816425" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2023 05:35:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10854"; a="781648465" X-IronPort-AV: E=Sophos;i="6.03,204,1694761200"; d="scan'208";a="781648465" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Oct 2023 05:35:51 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 6 Oct 2023 05:35:51 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Fri, 6 Oct 2023 05:35:51 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Fri, 6 Oct 2023 05:35:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dIu44r3jExD59wXo7MFa8SelpYfLFu+NObJyH1u31iBpXq8o7s63AvJYpH13VqmbLscQpdsm19fH9cBCs7q076eijEQFqONiRfoh3b8Cqhmn6HO6KmJbtBgftYaZYRG60FHWL15SIpx+CTufv97BdaAEaTOsOpHF/xDbJnQZxEPCDRCdjRZKQXP5q4NCSXLiLnM4DV+PITnqQPrdg69UPRrEF9Z799DmXANS3rcBgdEtrm/63V/vupiUeLhRmh3rwrVnfPLQSImySk5ztV4O4TKcl24LI/AfEMZSYIoKldADhHeSt6hDQYqlzwKC8+hwdE5G5SFky9oFzkdRqykykQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vGH8JjHWLm7amcrTMSAFX4KhxTa5PZy4bKFe5TMDHqA=; b=CY0CFwmXiWZZUHBb66kLvLZ21r5wqhlqEzGAMTAlsG26KL9PbO/rUAcu75+j6/lrlTel8oqydu90I0ilB7AuuFd4nTpumhUIrFRcevPrU0EfsW+BvJqJUa48Pu3eJgRsJvcjIeFgSftdmB00cH8zP8LQ41Eifpr0LhUo7trAZtP9AOrt8tYoN1lgdhIYrIN0BqpPclw7ei3uf/KvtfEClxsXvMGIytK5qdFk/uedn+tHy/7UPEbIZwhF8GEBil37RjVax2dAGr0P80rVQo1PwlsCesQ4xJYYhqpqSFPjJ4O7sfhRPhvcymhtyTN+An6ccjg3+KQW2EQzS7kRKG36HQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB7442.namprd11.prod.outlook.com (2603:10b6:8:14d::22) by LV3PR11MB8508.namprd11.prod.outlook.com (2603:10b6:408:1b4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.35; Fri, 6 Oct 2023 12:35:48 +0000 Received: from DS0PR11MB7442.namprd11.prod.outlook.com ([fe80::d480:4435:2089:dd78]) by DS0PR11MB7442.namprd11.prod.outlook.com ([fe80::d480:4435:2089:dd78%4]) with mapi id 15.20.6813.017; Fri, 6 Oct 2023 12:35:48 +0000 From: "Dumitrescu, Cristian" To: "Zhang, Qi Z" , "Singh, Aman Deep" , "Zhang, Yuying" CC: "dev@dpdk.org" , "orika@nvidia.com" , "ferruh.yigit@amd.com" Subject: RE: [PATCH v3] app/testpmd: enable cli for programmable action Thread-Topic: [PATCH v3] app/testpmd: enable cli for programmable action Thread-Index: AQHZ9/9sUNZF1lln5UOxpb9PAuX1rrA8sOXg Date: Fri, 6 Oct 2023 12:35:48 +0000 Message-ID: References: <20231005100246.242970-1-qi.z.zhang@intel.com> <20231006110714.338910-1-qi.z.zhang@intel.com> In-Reply-To: <20231006110714.338910-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS0PR11MB7442:EE_|LV3PR11MB8508:EE_ x-ms-office365-filtering-correlation-id: a159dba8-6070-4310-9b1e-08dbc668c499 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qMo5vlvkps6N1JlrbZ3rNyNGeepsAgPlyZp+SIJBN8tCoET7bAmfn8Ym3hqsHGiNfS6DuWa7G3TU0dfbGn1eZ9qwqAHv1NYwPhCUk4Lv8cYa45E3Tyc/8Ryoh/hh1Ejr54QhR3+Sd5l1vtQQjcNM4KP/4Iin55ax5kM6NFrtoDOdpUm6/k8+FnrMTFwE+BNm1iwsAPFi3wLmcZIDZ6yEO6mel/ge4E//a0fz4SaW8HGYZG8ksfVs+2R0wDz+rf7KmmJnf0tSYcxKtHTVmzhx+TtnaWxZmKk4Cr0iYsTuzEMsv+B+RkO3A2W6kNHblItbMsgVtQslekqCTr4Imr2pN23PhGhuTyJFl6YdTHRP9bfq4K6f1H1nDgR6WjdAuJvTBpzUX6WJZAOtP02NUf6c7a6PMr1GpbgwKZ0hTgpSLPnTXWxBf0vjRfUr52Aq+8s/Q9oQv4fsLx9KKSJWLyLnrs0NWNpf9yOs4mtv1ZxRcZsibTLo3/Lf4rcIMCHDSlHNXGenprB/BAM3FoXwCM3pJVL/OtCj7IA6cB3bEUbPXyO3UwNyGksFgjNEs8LjhWHjePLXrYFTngUs0fT3W+Wwml05Teh7s33UnS8f7Br4x/oipG3Q8+hq99CJZnwB5hBV x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7442.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(366004)(396003)(39860400002)(136003)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(55016003)(71200400001)(478600001)(7696005)(6506007)(33656002)(122000001)(38070700005)(86362001)(38100700002)(82960400001)(2906002)(26005)(83380400001)(9686003)(66946007)(6636002)(64756008)(66556008)(5660300002)(41300700001)(110136005)(66476007)(66446008)(76116006)(316002)(52536014)(4326008)(8936002)(8676002)(54906003)(4744005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sTXfx85vYCWLGYry02fu0ZgbEQA06Bi1hFce5BHnTkBJRWEmQmkVELBTRhPj?= =?us-ascii?Q?i9uajOq7ZFKq59/l6IVou64EUDYKHNO6JIybqYzoKRZNyKtGPHafNTombbQq?= =?us-ascii?Q?ilox9EAdbnLGjYbEN7hGc8h63dvnS8D3apE422k/b9r3/xXcoBgvE2Bv7Yir?= =?us-ascii?Q?rryb1ORJHG/ozD58Jv8DiDfVlEzSGMNX8e9zsYZZb0PRUVC2pRBKjhimrSDb?= =?us-ascii?Q?DfFOm/0pwx1k1U2Pc9yCHXVwBQm90AYekVlag/FrtDimRFnG5etn0YxfRymk?= =?us-ascii?Q?PnNmxkXBNraoVyZOVNXSFmLv+SRir7ilLTtS7WAktgP76ZvJvNotBBXeIkaz?= =?us-ascii?Q?rtfb4bGiWBq6cZC6Mx6GgLODUmN1puDnMy0ndCE+aXUWPltT8emUi4VPR/NZ?= =?us-ascii?Q?lfgJK0bqi/FZDQ0bT0G1Su36x+i8XbRWl0GYPsrnvkfKHip8SAtvVtuecSBT?= =?us-ascii?Q?v1gwiL0yXaHqq8CxfFAzn0HRqgt+gyaEzcSRh7Vq7ONfLrNBHikALCrDQzsy?= =?us-ascii?Q?5+Zk48X8HMJt+2L8hnr7ZaSGoI5+IlW3sL2rUzmXVvWflnBz8eLeKdlvv27B?= =?us-ascii?Q?W4ya2s34MwNXBo1hsii5gR9tMEeb/3+ZuGEms76Kryi+Aw7trocfFg86VOej?= =?us-ascii?Q?yzYKSjTtlVZ0Sn6pRg2xSEseQSKzJWf16LBVugyr1NLKf73lbemZLmR/SSRU?= =?us-ascii?Q?gpDehxIQ6Z1ySEzvpir0gqkQw4L41do69BUNSxEd1x4DguhOH9+Marobt60d?= =?us-ascii?Q?4Q2s1+7d4DJX/KGP5GpHR4xA5QboPKmS3TW5K4Z+Td+DsdBfXFiEtDIa2YsY?= =?us-ascii?Q?rKn3QIXmiwLlpmlK+UF0idnrc+0gCX8IGaNv5bdZyNHEtnJqPy1rWZWhyfkh?= =?us-ascii?Q?iO5dZ4CUn2GfmkUNKI2jUEO4btqb6BYlz+2ZpG8uAlUV8UIxYFEPcdHI1T8z?= =?us-ascii?Q?6Fo9Cs4mlujhX4zXfQXean+UPL8xHPFvio5z/pvBdzySQ3bESFfMBry+ky8f?= =?us-ascii?Q?tFfokre+zrxoCqRP4IUq/1DdeBsLksOqEqWVHjr04Pg2eioqhpoAsS/O/KDs?= =?us-ascii?Q?Vj1KxwQFw50/0Yxxate4sz/kxjCdf9Uit+Fw+TpUhMn1nga6f0BfGTASZ2xM?= =?us-ascii?Q?Xh9T5rnhQhxPGk3sCQfFsJKNRkYYCJYvLz5fAym/hAlINo7QICJEqaxLtXqG?= =?us-ascii?Q?ro55/0Q9TJPBAUkod9lbS0JBUoVw7pRCRQ+BZtFCKsGiud6AtvHrwuWI7bBp?= =?us-ascii?Q?Kw/kGxFGS4dEEDT6TPe2ss3FB0Z6R8mB/Lf00FlLZeE67gTvmlXFvGWOHb8m?= =?us-ascii?Q?nT2pFmBdu7dqiIGmSuQkORCUu57nA8b/ZWvGKIf97nCSjnT3eKW+0UcinWNL?= =?us-ascii?Q?kiXoOI4swpCOsstfW8mcb8rkX0zh+iz6jlWUIsFBSQe29HR6PmyZ/E1Nj+il?= =?us-ascii?Q?4zE+Y733mH6LsnFIV52j15uLkHAfJlsnuSOO3LPyxIe7TBw6slqEtgTNBIm6?= =?us-ascii?Q?7Qk5m0I6lVJkhfU9wACvZVKWOzFgZlFgm9UqewkgDrV8gU14qPEgwmEfW9wZ?= =?us-ascii?Q?toPqgKCMsY0nkROXFrWkdwH5LOy8dBIGQX6ia3aZMiKxdwbwK/7uQrWdmUYB?= =?us-ascii?Q?Ow=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7442.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a159dba8-6070-4310-9b1e-08dbc668c499 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2023 12:35:48.0303 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Iwj6KoPNoKO4WrsFqv29FTTI2qkrWWrtconInukP8nEeLb866/NhncFRmKMXeJJKgBYWhaxifbtFalzbmjJIVs1XKNx6bPvPSauOGsY7Wj8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8508 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Qi, >=20 > +#define ACTION_PROG_NAME_SIZE_MAX 32 > +#define ACTION_PROG_ARG_NUM_MAX 16 > +#define ACTION_PROG_ARG_VALUE_SIZE_MAX 32 Let's be a bit more generous with some of these sizes, please. The action name might be hierarchical, i.e. include the control block and t= able path separated by dots, e.g. "dev5.ingress.forwarding.routing_table.se= t_next_hop", so: #define ACTION_PROG_NAME_SIZE_MAX 256 Some parameters could be 128-bit IPv6 addresses, which may be specified in = hex with additional characters such as '0x' or ':', so: #define ACTION_PROG_ARG_VALUE_SIZE_MAX 64 Regards, Cristian