From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A925143433; Wed, 6 Dec 2023 14:34:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5697E42E7A; Wed, 6 Dec 2023 14:34:38 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mails.dpdk.org (Postfix) with ESMTP id 476DB42E79 for ; Wed, 6 Dec 2023 14:34:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701869676; x=1733405676; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=E501Xp8q6TAj7pq8z4gsnesYkH9kULC87PvpCID3U4k=; b=ODvyxg+Ob1He90D6yt5DAi7mCvPTwLbt/CimwwVKy6uWVyT1pUoAP61I rNXCVr6Z8l4EF+dYV0TkpSDGdtJK/IHek5qtZ2nuMGsvipeWiwpRDCk+y RvF1bcUf+QAHRU9QfS+hGVVcanTwho7mMaiCB31xRqWeEcchkmSpR9ZAq RAkRy7Ojs8s++igTbqsDj5IYP68UCxOdW45JYm9VByiiwm8hW/EpsUg7G s8qQMLeRV8mIPLybK9lHZtKtTR1QTmBJbCnQIqZjfEBLMfE8oYzBXtr/4 iW0cV08iFS7qKvUtDxapK+nsNeSFnax9iVPxvbkX7pjnVUWn9MhuVkepV Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="1129368" X-IronPort-AV: E=Sophos;i="6.04,255,1695711600"; d="scan'208";a="1129368" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2023 05:34:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="1018568682" X-IronPort-AV: E=Sophos;i="6.04,255,1695711600"; d="scan'208";a="1018568682" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Dec 2023 05:34:34 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Dec 2023 05:34:34 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Dec 2023 05:34:34 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 6 Dec 2023 05:34:34 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 6 Dec 2023 05:34:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ORstizL4pcb42w8Hdzb4gOsdjgtl9NjxNfOSr9JJ9BxfKPQFstdem6voZppvvLi2QZas2lY71dGECID0jobOEaxFMG6WrV3bsp1rIgLL5dOglIDekpVjcVOhub1ET8d1EqWFMxFRfaju5/nP2jatDF43z3/fTzWoVrhVsIh3xNRZQl/hMCjTWtPJX5PK5IRmdqdSxm3xkjHQf6O/hVnM6cHXwyJZxFHY5i5UQtT+Fv7oaRTxnfUebA+qNxsidRRVaHllITA/L6TP3c0p70nrtwtrNVmyDHcn5EVrGC8zm0Pq/luGiuGkCOBO/RKS7ZJI8EcOBc3XeGqvUQCfjjhLyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0M3DheVZ2hG2tewyDQ988Y5CPl700kKrMrER8Ye5DYw=; b=hnHjsMMfQLhKWI7KMf2GUMoGn/HsOBFTnAje0MB2C10CXWIiwp2SmCO1wif3ofUtzGeyeO31cNl4cwhOASXog7PwlatBXaUcdkFAalCPnXUs7q+orQVIP5qYIZsptlZJpmRv781Igmd/bMwL0WFImtvMNvbeO6+Ri6kzn36g8do5AKB04kgfZeDuTOdcvdR3VD+FgRnxibmWEz1J6mzo58If6cFl5F7xskhGLcaqOwWDbRE379izONr3JKTWSU/E4u0aWPLJontIhUh5hMeRYtp9Mu088m3uN2Z+4maR4SDGDrUKEpheXguvAFXcR6MYrVrNCDsE+IC8FLpESwfpvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB7442.namprd11.prod.outlook.com (2603:10b6:8:14d::22) by CY8PR11MB7777.namprd11.prod.outlook.com (2603:10b6:930:71::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.25; Wed, 6 Dec 2023 13:34:32 +0000 Received: from DS0PR11MB7442.namprd11.prod.outlook.com ([fe80::f2ba:8da1:22de:8ce1]) by DS0PR11MB7442.namprd11.prod.outlook.com ([fe80::f2ba:8da1:22de:8ce1%7]) with mapi id 15.20.7068.025; Wed, 6 Dec 2023 13:34:32 +0000 From: "Dumitrescu, Cristian" To: "Richardson, Bruce" , Vipin Varghese CC: "dev@dpdk.org" , Ferruh Yigit Subject: RE: [PATCH] cfgfile: increase value length Thread-Topic: [PATCH] cfgfile: increase value length Thread-Index: AQHaKDe4iKCfppVCJEW1iVU5VwaFK7CcPeuAgAADKPA= Date: Wed, 6 Dec 2023 13:34:32 +0000 Message-ID: References: <20231206112952.1588-1-vipin.varghese@amd.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS0PR11MB7442:EE_|CY8PR11MB7777:EE_ x-ms-office365-filtering-correlation-id: f200a7e1-7919-40b2-01ec-08dbf6601457 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LZ0xXk9aIsQuDsMWT5Yr9c22S1KCZ1E5wWgaTnW950wGo2MPp7lB52vr90hvrnF5ZecwTZsjhXTUlgyWu6VCQNK1XtFWwY+zhpfY9YqBAZM5XWe6175HUQa/oDdR/dNT05BfQDopZEWceKqKRu/TAyWpNv6tn+qBZARFFy6//b55fheJqCkIawB0XuI3E3LHzl9bE5BX2ymLd/qWbnYUBnw1K00N8o4hwWXH0O8Ryj7Wjw6v7KeFheuHi4rWfJVIHHRSGYvmGD9Qhq2TaZjo4/wbJh5ZAvRGMUkh+dJpoV0qaPpP31eewclkyLNiaQ370ZRHN0cKnAExS0ExOFdEc8w4m+7+UUbQWOpyP/qdQIwd+SfeL9Y+M3pXp5eYW0yjNuIQ/Uc0BJUHY6bCzNxdXntpJvXEGGGYrEEaNgUichd/9zP11os3P80c2+a5D2wOL2PNzJNYm9q4ib4BObpo7Mt6GKbhWZGtx4X0BzlDh6qFawmFAJWmBolPxrhvfQ+aNtxSX1/miuKlSsxZFBzlZXBEvoBG3XBMUI6v0a1nSeNuureDZQfRp9LjBZe5R2rZuwsC1AYKNQM/idlfhp+wg7sNFrgp8AjS17maB8aZQrA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7442.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(396003)(346002)(136003)(366004)(376002)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(55016003)(33656002)(122000001)(38070700009)(2906002)(83380400001)(82960400001)(71200400001)(9686003)(53546011)(38100700002)(6506007)(7696005)(5660300002)(26005)(478600001)(110136005)(76116006)(966005)(66946007)(41300700001)(66476007)(64756008)(54906003)(4326008)(86362001)(8676002)(66556008)(52536014)(8936002)(316002)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rPfdjijzk9frscUicJ2/day8KIX7A5yowiRyqcol5iCU4YP59J9a7pWW/irw?= =?us-ascii?Q?FdmcQEJlqwKNgzUynd0bmOc64PC2KdNgrTubeeLKlevX9uUxfbou1v5j8qZr?= =?us-ascii?Q?IXrgMlblrzGnGh7P5Ax7Qyvib4J4ONJNERLLabJRhJ4nH2EvWkRNSV+fTgFp?= =?us-ascii?Q?l0SCihmcj0XVipXRLNV9RYvbYJL96x77sJp2XuYZT/UkyERgG8qcuLmC5QM/?= =?us-ascii?Q?F8FdM18JE77PT3FhthB51djDexfYy3sCMCTrIo0qa1F5LJ6O87KoKBVErP7C?= =?us-ascii?Q?qJKMEkUBaUBmQYc5/xOI2TRIjfI9jRaUrUdcXlAtdv47Fu69kW7sAK18fnvK?= =?us-ascii?Q?J4ekEGdsl0UXynINE7cryzV3jZyT7j/JdV9v1tnxQ6bbnkCCXchnMl9Tmpg9?= =?us-ascii?Q?TngJjiiMBV40U9eXkKQVQVRA7slVReZVrPT2bOLxmTQrsX8gnkdt62+YDnKM?= =?us-ascii?Q?PH3CRWTCxVA6NGzco/+17fV6Ov2Ap0ll4mr+gXQob7NEs+MnuQ/sSAW6UA8q?= =?us-ascii?Q?QSHvpBeDK6ozg68wX+gM1HXv6PkguSnEG3donCmDga+BYSn7jWMBLRx3tYzp?= =?us-ascii?Q?cQ6nnJqLyQ+wTjSNPvqpmiS0G9BtkkrVcRSKsz/wgY1Kj+L3YSTQVmyw6h0b?= =?us-ascii?Q?/ezwuRC+TsnY27HVLMLobh12qwA19hb40Ni7z7iT5239lffZiyIVtrG8NIdP?= =?us-ascii?Q?ybsfVDILjpv63Gy4gXY3zdRe9/kbSHszVVfYi3qUwtMWNOu1CUg08YukpFrw?= =?us-ascii?Q?ACK3QDPJGUhvLIhOkS1O1H6vETeNKC2sJ/X7FTXFCK/yuF/Ptv8vJmjiF3Oq?= =?us-ascii?Q?mb9io/y/gC6li6QOG23N+QVsrKKmZcusIGt0x+kOqgEoF0we5ranr8GFl4Qn?= =?us-ascii?Q?zc6z7vezqCs+D12YcDipSwqs69y1eAHXb35IjEpw2Dh+atu9HGI5bxMxF79C?= =?us-ascii?Q?kM1A1zYLk8Ig7fUOYQc+GLjUY5VFN/LKK8IddsCen3Gn4UVAHLgRhWtk2TVR?= =?us-ascii?Q?baEd/O2qz4tYt4xHntTnCYmxbk73fXNE4Ef5m9tWQ7CVd8lgZtkvIzsvlFwU?= =?us-ascii?Q?+r1pQD2NjNSNcrBJuPGyFiWsNKBM5xtC58qU/kf7JdPgsmFlMjhmhQQp/WDu?= =?us-ascii?Q?QS/6lvsd02xxe1SesfekOf/enJA8P19KPUZkIDd83SpzFP/+PBkW8uiGIs7T?= =?us-ascii?Q?3w6RFac3s5FFub/0sYFF614zVc4Cu02+wvz7ALlQ2uBhOEPOvdStm9/Wy0K7?= =?us-ascii?Q?I1yZY+2lU1YqNkNjlSxB4GU6S4hWRe/Na+4WYMg8ZW2kYHXFZC2ZnlFNmL8r?= =?us-ascii?Q?4h0cLJBNYkN6F0UQaa9ZDGXab7c/nSZRwxrw1yBSKa/x1EXHpCCCkgSKlPco?= =?us-ascii?Q?Rc6h6io7Fg7Tuz2+g38oI4Vlo/OnJyMd3wQc++ltlPmdtpQG6ElIttuKuzip?= =?us-ascii?Q?zxxYOCHyMN2GPT/Vze6iadFGnHeDu3vUUyQcrdOuvy43tBAGHhjemDR+Xy6a?= =?us-ascii?Q?oJkoDscOZE+6Lkj+oclEd9loYKpLsv3sHyzyU9lhrgjBuw6GXFKW8zhDQyrY?= =?us-ascii?Q?nTLOPwE5b55RuGskIg2uNOWNAkk7c+hH7i4E7GQsBHPyoZQd73l9y8WHfzpL?= =?us-ascii?Q?JQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7442.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f200a7e1-7919-40b2-01ec-08dbf6601457 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2023 13:34:32.0992 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: D2RcyTwBNNk0dIQbsrqeVcXeDbwY0CMHg4ARjqH0w87KcrSwIzytv5ochbzrZnIVoDmg9tZW8F4bOH0fLT6XAjLS+UCGRfcY/vJaVyUehqo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7777 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Richardson, Bruce > Sent: Wednesday, December 6, 2023 1:22 PM > To: Vipin Varghese > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > Ferruh Yigit > Subject: Re: [PATCH] cfgfile: increase value length >=20 > On Wed, Dec 06, 2023 at 04:59:52PM +0530, Vipin Varghese wrote: > > The default value for CFG_VALUE_LEN is set to 256 characters. > > This limits the parsing for longer strings in configuration file. > > Setting the default to 2048 characters increases the value array > > size in `struct rte_cfgfile_entry`. > > > > Files using cfgfile library are > > 1. drivers/net/mvpp2/ > > 2. app/test-dma-perf/ > > 3. app/test/ > > 4. examples/qos_sched/ > > > > The structure `rte_cfgfile_entry` is not included in DPDK libraries. > > Modifying from 256 to 2048 allows `app/test-dma-perf/main.c` helps to > > parse longer string as shared in > https://bugs.dpdk.org/show_bug.cgi?id=3D1333 > > > > Signed-off-by: Vipin Varghese > > Suggested-by: Ferruh Yigit > > --- > > lib/cfgfile/rte_cfgfile.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/cfgfile/rte_cfgfile.h b/lib/cfgfile/rte_cfgfile.h > > index 232c65c77b..401353c44e 100644 > > --- a/lib/cfgfile/rte_cfgfile.h > > +++ b/lib/cfgfile/rte_cfgfile.h > > @@ -24,7 +24,7 @@ extern "C" { > > #endif > > > > #ifndef CFG_VALUE_LEN > > -#define CFG_VALUE_LEN 256 > > +#define CFG_VALUE_LEN 2048 > > #endif > > > An increase seems ok to me, but is an 8x increase really necessary? If > lines in the config files are over 1k in size, then it implies that some > other mechanism would surely be better for configuration. > Can we make do with an increase to 512 only? >=20 > /Bruce Happy to compromise with 1K. Acked-by: Cristian Dumitrescu