From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E6EF45AD5; Mon, 7 Oct 2024 12:35:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E7B60402EA; Mon, 7 Oct 2024 12:35:44 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by mails.dpdk.org (Postfix) with ESMTP id CB4214026C for ; Mon, 7 Oct 2024 12:35:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728297344; x=1759833344; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=kXz3LeU8KV1fQKxALSrbWGpEWWICDQSEAd03vHQ2drw=; b=Upu4JfuEERFBdsic+Xm6BhmCuw1ny4R+j44RWr5gSc3yCGPPfwRLcXZI 6N0mdFZ2iVRs/prxYVCO43P9TkRGstaYfRRxYPh/SXo8h0gfjXY35AD0u OkqN0aM+4WMzBiNc4QBl2ZH+QdB89JEUt7V8lDUFEb2BzQWG9ThohZfZ8 4xUHsygZ20AErravlTR+rH4/Vjn/3HTBptpnQRfBlBHmkyBBNOiLFbKBp s+2a4OKrRbvdYOTWLA9oJeAW41vKUpiy7BzJ3Wvl/u5R8ahTt4XdQ3gm7 1YYrZuyBmMXpucTRqln4krPEZpe5G6Zq4ebigCz/LRgLb8t0f9YJ18oKc Q==; X-CSE-ConnectionGUID: TfxzZJ63QyOSeY1CdOeR9w== X-CSE-MsgGUID: gIfuBv3gReGa5keXh2AOBQ== X-IronPort-AV: E=McAfee;i="6700,10204,11217"; a="27322115" X-IronPort-AV: E=Sophos;i="6.11,184,1725346800"; d="scan'208,217";a="27322115" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2024 03:35:42 -0700 X-CSE-ConnectionGUID: uBDKV+LMQdi72DOg5o+27w== X-CSE-MsgGUID: uXz85kleQiesLmEOeSLscg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,184,1725346800"; d="scan'208,217";a="80021247" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Oct 2024 03:35:42 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 7 Oct 2024 03:35:42 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 7 Oct 2024 03:35:41 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 7 Oct 2024 03:35:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I1kl2Y6XhllKnNqLJHWgUq/BquLNlVLWQXZBLAO5oPdaq1dPtSuH9gLqvxPDP0IBAVS2NUzrnuT3j2kz+EraFxIaciV3blEcW6HNWshW4fmObdF9smRKU77csvYlu2RAEtKVEpXqaEDNSd6nW8HQ+0bWJf6R20RT9JbP+fzXrZiCu5OR2Sr+w+7tuNCHpeDxZAPWIJQqQ2msaS7FdBFd+sUt6iBnmTn4Taw9bg/Ua35XC30T8feWJjNtyyUs6m+TmIV2Gqqnw/EMfLMi45nMZDrXslXN4hM+WSsq3D75B1TVxtqkxkyIwDUWw6w5FNsskcu8sHJ5ReZAHHEYjQXtUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A9pMoxBGfmeuVibka/f7czWZ8nsFu4PjdO7oSYoSfSw=; b=WWcermOhNLqQPnY+qv72lwTjr8xlV5E1KNf2+VGvylVUtfnva0QXEH5YqRCfY1FAIU0Ht0SJGFNSDjaoHhlhcYHi3h2ROOrgWLvPpBe/Ihzz2wtDvGi6Bu4kdYGUecBM5XaoW8D8B/b3lNSRVQ327FHEvNcyNmcGKMyACLrkxnop21OJiWYBUClKEswH37BSUdvbAuSZW/3ioYlow/ltI+boDnK9Ku6T7Ia2Uo7uOryaDWl5bm4MviLuTnxra7vnzij1edyPlSZwzWx3AzOtqNE7p122StFFFQQMWKzzdpM8IaGExEEX9i4IqB0Kp2gtDx/Che7evRBCpgobZvhl8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB7458.namprd11.prod.outlook.com (2603:10b6:8:145::13) by IA0PR11MB7308.namprd11.prod.outlook.com (2603:10b6:208:436::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.22; Mon, 7 Oct 2024 10:35:37 +0000 Received: from DS0PR11MB7458.namprd11.prod.outlook.com ([fe80::1a9e:53a6:9603:8f79]) by DS0PR11MB7458.namprd11.prod.outlook.com ([fe80::1a9e:53a6:9603:8f79%4]) with mapi id 15.20.8026.020; Mon, 7 Oct 2024 10:35:37 +0000 From: "Ji, Kai" To: Yong Liang <1269690261@qq.com>, "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Subject: Re: [PATCH] crypto/scheduler: fix incorrect variable usage Thread-Topic: [PATCH] crypto/scheduler: fix incorrect variable usage Thread-Index: AQHbCdZuckZYVTJTq0eMwMb/euz4qbJ7NQoB Date: Mon, 7 Oct 2024 10:35:37 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US, en-IE Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS0PR11MB7458:EE_|IA0PR11MB7308:EE_ x-ms-office365-filtering-correlation-id: 8413f13b-46e1-4a3c-8e46-08dce6bbc890 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?kUHKefYFJl3N2cbC92V1pcxWlWN7yqde3gQi48x0jqEUha+OFaj0kz/NvU?= =?iso-8859-1?Q?aYyh06ycADu8e71oiHZwM3JTgVJn9yfaCC+c+UdcCrWpQnJox+WTQRuBnB?= =?iso-8859-1?Q?MlP7BeQBRDHKvI3kSgu05dvNp6i/MIrBd7SBhWBgDjo4eI3laKGuyOeeZL?= =?iso-8859-1?Q?arrLnYIAGQY9B1WoXZ3ikAJJxyUJaMKWFD9x/HP73f7JWM9ieoKL2J5K5D?= =?iso-8859-1?Q?+PlapJWEzCHYTmva5sEJG1+TFLkjVsWZJFIf14+iq3M3kne16bdbNEX9gy?= =?iso-8859-1?Q?sK8L91jr8irmVhvr4oYjw8CVCUWhccHVAbzhMmkgP4L4Xd1YnMEizIqEVj?= =?iso-8859-1?Q?G1KylGdFVCq9LeZqTry1FZUn6nGncFoZTqFbagOBmbLTpPSQPPloh4OlKV?= =?iso-8859-1?Q?dw3w2htHFH1Q48JMv3QLh9Dh2KOxTOqbo1SBly62SpiTRtOBu+cXcnWFB/?= =?iso-8859-1?Q?+yy4EdmBWH6qa3ya5+mkWWwL/QCuXrXbnfryqGGZsHEyGBMsdvNpC0arp6?= =?iso-8859-1?Q?59eclsKxkTqTtiZdlsrzzyyMlsnZFTBryWju1zULbFyV5dMS6TkGbogb/4?= =?iso-8859-1?Q?kwdIlftmihu6QZLvjY/HNp/XYNBqWIAkFdBtZyay6XuIBBLMHlDJznLJVt?= =?iso-8859-1?Q?cqlNJrE7jgymdRwT4gxBAIDU0Dt+SgbzH8TDSSDkbvIB9lugDQc3xKxysa?= =?iso-8859-1?Q?YNFhfclYqkjCu6B3UN3Fcc7aikR2B73pDyerkt7Svx1WnMHcxVDK+O21+9?= =?iso-8859-1?Q?KL04z421R+ZNlASRRTC2ZvxNb+3rjkTuwtP08dLsyZMWwo3zsyDdBO0vts?= =?iso-8859-1?Q?6D6KxymJIC0EH4RYk+J3JTmbzEdmheYXvAtdWH0rZTX9xn7YIF/HrMhVHI?= =?iso-8859-1?Q?KFWHXKQILYyEzpuTjcPD3fKAUmHjU93h74d/cS18SRx3xFyEOhXvQDAJ/N?= =?iso-8859-1?Q?M5DCcobl1fjGHhMiy2l+5Ppswg6FWAEdZ8k9dZZkf9sRTx4+NtaK9cAAPr?= =?iso-8859-1?Q?DhEjLWUBu2pM6XUYj2mgXwH1ZeLqPNEhFSULpcSzYWV3t8pdZRu/IyKOPz?= =?iso-8859-1?Q?5SFTjXkL1s4PbrHYpNLpNd4R5V+KU6d1oUD8C1hB4frCfY9YZBvankkSTY?= =?iso-8859-1?Q?7k96INTbE10aIcA4F+K21HDCMbNXnjaj7mKYRpN+h5nzJ1xGbzfy7qXkXt?= =?iso-8859-1?Q?ovM7DGzOTU4dcgy4xs98rmuSBj/ll32Xq/ZY017vkF0OK1xX4EB8Awj85Y?= =?iso-8859-1?Q?GkkX9Qfi5ZttNekmV3VqXJhQv0HiyMP5qLyXRAAlsRKKgF9OqaTqqLpn1/?= =?iso-8859-1?Q?hFaBshR8Z619eSvqMGm+waoMtgoALwNChZDnJV1MH7xIcf+VKdn8JGLnJK?= =?iso-8859-1?Q?BA96sZVj7IqOy7gu52IaGOXZcaa/lZ/w=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7458.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?P0cqhbJWm6lPrlZ6W3bzWXFo7Ph50gJj0OCiWLEQiWRG2JIvw+7Xtt9udV?= =?iso-8859-1?Q?amGGBIwp9EJn7Jo98KyoZmsFLgvuu3qGoy+fEYZc2L0lv2wtr02vZO1Hy9?= =?iso-8859-1?Q?2g0CvIUNw2yz2PRTlcoe+PbQ04LkMPuTtc2jlGiaH/SG2EUqjmfrZteivy?= =?iso-8859-1?Q?WO5KolG1WcX4JVKXWJWEV2dbXiOVTRpA6yQdtG9kIVLf8w+Da80CCXKfiP?= =?iso-8859-1?Q?dRN1/vVKW1ox4SDhG+ENaq68ARLuLuYo9FqC/6NwQhLO9o4hB8GqN/woeD?= =?iso-8859-1?Q?YIiG4eln1WYGkI6e7NKDIG69057QK6iSUMs86hidXZk48RuA8D6ra9F/2A?= =?iso-8859-1?Q?CXX8kLC+Wq7vDH8GVP2Cx/g9kc8cmSBDYkBXlSe7S1PGOh6PUiK1hsSxUx?= =?iso-8859-1?Q?+6+JoXC7aau/F2yv1vQpp4R3p7U5jDjHyfj//TzJ12MPBR5gD38m3HwuQS?= =?iso-8859-1?Q?Yt0C7mHtuJPyXAwHQ1Wllg7kpXAmHzfBhY3VTwnd7oV6QWT+Tyn0Q/vQTZ?= =?iso-8859-1?Q?l1qOwYWDAilrLFAifRSuj/ILzwMHuj1svWpsx/itnwfB7foLYVo55buWni?= =?iso-8859-1?Q?AmAUsRakNtIRwUrRStk/C2KbqE4MVFbiDppkDAordVWPQRDQXX+t8NH9rZ?= =?iso-8859-1?Q?E2oNkDMPbmXH8tsNPDwL08z4vGP5fhvbYjzks1X2g5IeRuX3jSd71XZk0E?= =?iso-8859-1?Q?mLcfww+pY5TuoTg2EhGbyBPfpJRcJvC95/AcDCNS7ZHcKDiln6mAA5CRyg?= =?iso-8859-1?Q?spwxBB/G5DrGiNw2rspeXcnng8nrm9MHArrfDMPFN/jU1Bu7675hnNOh92?= =?iso-8859-1?Q?ZfYUc5IrYq8KAQPOLGh0eNiR1s6XYtViBx2nyU7u/e7zg8zz1JNN810DyW?= =?iso-8859-1?Q?ceprhfI2tXoCQZTwfPWPo/K30stzD9swZOEI25zu8ChIqskJlATcj9uOeL?= =?iso-8859-1?Q?ib3hYUYHHykxwOtrxO1Wc5fkF3dOqbhuczpHzMoQMhZMOzZ5X7xuOh5pJe?= =?iso-8859-1?Q?cIxap1fBmF1AtdZGipawQiAPP4sxy2ieJyKVEEBeiGqvTexgG4hVA5g6bY?= =?iso-8859-1?Q?G6B2pjikXyQVLzC9h3B99kWdjpCMUGAIu89N6MHU81Hwk+84Yzu6HOUclL?= =?iso-8859-1?Q?xrHlmo8fkth+C3L9pYuxGsTkUbyI4rbx2vZaUlD5YKV5/SYImA+/yN24AW?= =?iso-8859-1?Q?ke8KIAR7WBhW0AJffW2KVmM6cXFShTjSvg0ruUC9mH9jO8BciusSOAQ7/h?= =?iso-8859-1?Q?43Qo+cr+pXvB67WB6AtzGpxtwhwjgbp/PiE0qzTn38MpPkgOTRTVb7y9wy?= =?iso-8859-1?Q?P7Y2n1oPEmbfXKgU+JcXAhtI3aJnvhbqBtU0aqotkMwzUkMG1D55i3TeoV?= =?iso-8859-1?Q?qm4e4r4nEMojxKjUy5Nab1OzIwuOKSjHWPjsHRp9nbBbJc/Ylr5MwyGGoI?= =?iso-8859-1?Q?R8aVCf1CqAxoV426n5oubvvpH5d2YZiGy/u5Mo2D9hC97pbwmH5FqqZ66O?= =?iso-8859-1?Q?d8/5l1+snj+sGxJwmlCvHTtEr4A+iH8iQnawtAexChmUhLn1hXjoK3Kjl2?= =?iso-8859-1?Q?UAAKfttV2i+/cvy/WKOhs8ffdPle1nIpVZ5bLVLPSMzHjuAieSeXXkB7lK?= =?iso-8859-1?Q?XytR8Js0lwbUU=3D?= Content-Type: multipart/alternative; boundary="_000_DS0PR11MB745859953B6C40115240D92F817D2DS0PR11MB7458namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7458.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8413f13b-46e1-4a3c-8e46-08dce6bbc890 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2024 10:35:37.7330 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LjdoOBaWUAwMr9cU6Va7z56fvH6LjixPLPVzIl0BdLVC7hmIskcUOWV1OvwUkCvMTyfPPwzwQZWoPTh7rsiYoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7308 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_DS0PR11MB745859953B6C40115240D92F817D2DS0PR11MB7458namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable I'm not see any issue with original code, can you give more details about c= rash so I can try to reproduce at my end. cc kirill.rybalchenko@intel.com for review ________________________________ From: Yong Liang <1269690261@qq.com> Sent: 18 September 2024 15:15 To: dev@dpdk.org Cc: roy.fan.zhang@intel.com Subject: [PATCH] crypto/scheduler: fix incorrect variable usage The variable `pending_deq_ops` was incorrectly used instead of `pending_enq_ops`. This causes the program to crash when the worker PMD accesses the session Bugzilla ID: 1537 Fixes: 6812b9bf470e ("crypto/scheduler: use unified session") Cc: roy.fan.zhang@intel.com Signed-off-by: Yong Liang <1269690261@qq.com> --- drivers/crypto/scheduler/scheduler_multicore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/scheduler/scheduler_multicore.c b/drivers/crypt= o/scheduler/scheduler_multicore.c index a21b522f9f..70f8a25b70 100644 --- a/drivers/crypto/scheduler/scheduler_multicore.c +++ b/drivers/crypto/scheduler/scheduler_multicore.c @@ -191,11 +191,11 @@ mc_scheduler_worker(struct rte_cryptodev *dev) worker->qp_id, &enq_ops[pending_enq_ops_idx], pending_enq_ops); - if (processed_ops < pending_deq_ops) + if (processed_ops < pending_enq_ops) scheduler_retrieve_sessions( &enq_ops[pending_enq_ops_idx + processed_ops], - pending_deq_ops - processed_ops); + pending_enq_ops - processed_ops); pending_enq_ops -=3D processed_ops; pending_enq_ops_idx +=3D processed_ops; inflight_ops +=3D processed_ops; -- 2.43.0 --_000_DS0PR11MB745859953B6C40115240D92F817D2DS0PR11MB7458namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
I'm not see any issue with original code, can you give more details about c= rash so I can try to reproduce at my end. 
 cc kirill.rybalchenko@intel.com for= review 

The variable `pending_deq_ops` was incorrec= tly used
instead of `pending_enq_ops`.
This causes the program to crash
when the worker PMD accesses the session

Bugzilla ID: 1537
Fixes: 6812b9bf470e ("crypto/scheduler: use unified session")
Cc: roy.fan.zhang@intel.com

Signed-off-by: Yong Liang <1269690261@qq.com>
---
 drivers/crypto/scheduler/scheduler_multicore.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/scheduler/scheduler_multicore.c b/drivers/crypt= o/scheduler/scheduler_multicore.c
index a21b522f9f..70f8a25b70 100644
--- a/drivers/crypto/scheduler/scheduler_multicore.c
+++ b/drivers/crypto/scheduler/scheduler_multicore.c
@@ -191,11 +191,11 @@ mc_scheduler_worker(struct rte_cryptodev *dev)
            &nb= sp;            =             &nb= sp;   worker->qp_id,
            &nb= sp;            =             &nb= sp;   &enq_ops[pending_enq_ops_idx],
            &nb= sp;            =             &nb= sp;   pending_enq_ops);
-            &n= bsp;          if (processed_op= s < pending_deq_ops)
+            &n= bsp;          if (processed_op= s < pending_enq_ops)
            &nb= sp;            =         scheduler_retrieve_sessions(
            &nb= sp;            =             &nb= sp;   &enq_ops[pending_enq_ops_idx +
            &nb= sp;            =             &nb= sp;           processed_o= ps],
-            &n= bsp;            = ;            &n= bsp; pending_deq_ops - processed_ops);
+            &n= bsp;            = ;            &n= bsp; pending_enq_ops - processed_ops);
            &nb= sp;            pendi= ng_enq_ops -=3D processed_ops;
            &nb= sp;            pendi= ng_enq_ops_idx +=3D processed_ops;
            &nb= sp;            infli= ght_ops +=3D processed_ops;
--
2.43.0

--_000_DS0PR11MB745859953B6C40115240D92F817D2DS0PR11MB7458namp_--