DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] driver: crypto: scheduler: fix session size computation
@ 2024-07-05 12:57 jhascoet
  2024-07-19 13:06 ` [EXTERNAL] " Akhil Goyal
  0 siblings, 1 reply; 4+ messages in thread
From: jhascoet @ 2024-07-05 12:57 UTC (permalink / raw)
  To: dev
  Cc: Julien Hascoet, stable, Kai Ji, Kevin O'Sullivan,
	Ciara Power, David Coyle, Anoob Joseph

From: Julien Hascoet <ju.hascoet@gmail.com>

The crypto scheduler session size computation was taking
into account only the worker session sizes and not its own.

Fixes: e2af4e403c1 ("crypto/scheduler: support DOCSIS security protocol")
Cc: stable@dpdk.org

Signed-off-by: Julien Hascoet <ju.hascoet@gmail.com>
---
 drivers/crypto/scheduler/scheduler_pmd_ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/scheduler/scheduler_pmd_ops.c b/drivers/crypto/scheduler/scheduler_pmd_ops.c
index a18f7a08b0..6e43438469 100644
--- a/drivers/crypto/scheduler/scheduler_pmd_ops.c
+++ b/drivers/crypto/scheduler/scheduler_pmd_ops.c
@@ -185,7 +185,7 @@ scheduler_session_size_get(struct scheduler_ctx *sched_ctx,
 		uint8_t session_type)
 {
 	uint8_t i = 0;
-	uint32_t max_priv_sess_size = 0;
+	uint32_t max_priv_sess_size = sizeof(struct scheduler_session_ctx);
 
 	/* Check what is the maximum private session size for all workers */
 	for (i = 0; i < sched_ctx->nb_workers; i++) {
-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [EXTERNAL] [PATCH] driver: crypto: scheduler: fix session size computation
  2024-07-05 12:57 [PATCH] driver: crypto: scheduler: fix session size computation jhascoet
@ 2024-07-19 13:06 ` Akhil Goyal
  2024-10-04  9:04   ` Ji, Kai
  0 siblings, 1 reply; 4+ messages in thread
From: Akhil Goyal @ 2024-07-19 13:06 UTC (permalink / raw)
  To: dev, Kai Ji, john.mcnamara
  Cc: stable, Kevin O'Sullivan, jhascoet, David Coyle, Anoob Joseph

Hi Kai,
Please review.

> From: Julien Hascoet <ju.hascoet@gmail.com>
> 
> The crypto scheduler session size computation was taking
> into account only the worker session sizes and not its own.
> 
> Fixes: e2af4e403c1 ("crypto/scheduler: support DOCSIS security protocol")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Julien Hascoet <ju.hascoet@gmail.com>
> ---
>  drivers/crypto/scheduler/scheduler_pmd_ops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/scheduler/scheduler_pmd_ops.c
> b/drivers/crypto/scheduler/scheduler_pmd_ops.c
> index a18f7a08b0..6e43438469 100644
> --- a/drivers/crypto/scheduler/scheduler_pmd_ops.c
> +++ b/drivers/crypto/scheduler/scheduler_pmd_ops.c
> @@ -185,7 +185,7 @@ scheduler_session_size_get(struct scheduler_ctx
> *sched_ctx,
>  		uint8_t session_type)
>  {
>  	uint8_t i = 0;
> -	uint32_t max_priv_sess_size = 0;
> +	uint32_t max_priv_sess_size = sizeof(struct scheduler_session_ctx);
> 
>  	/* Check what is the maximum private session size for all workers */
>  	for (i = 0; i < sched_ctx->nb_workers; i++) {


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [EXTERNAL] [PATCH] driver: crypto: scheduler: fix session size computation
  2024-07-19 13:06 ` [EXTERNAL] " Akhil Goyal
@ 2024-10-04  9:04   ` Ji, Kai
  2024-10-09 13:57     ` Akhil Goyal
  0 siblings, 1 reply; 4+ messages in thread
From: Ji, Kai @ 2024-10-04  9:04 UTC (permalink / raw)
  To: Akhil Goyal, dev, Mcnamara, John
  Cc: stable, O'Sullivan, Kevin, jhascoet, Coyle, David, Anoob Joseph

[-- Attachment #1: Type: text/plain, Size: 1675 bytes --]

Acked-by: Kai Ji <kai.ji@intel.com>
________________________________
From: Akhil Goyal <gakhil@marvell.com>
Sent: 19 July 2024 14:06
To: dev@dpdk.org <dev@dpdk.org>; Ji, Kai <kai.ji@intel.com>; Mcnamara, John <john.mcnamara@intel.com>
Cc: stable@dpdk.org <stable@dpdk.org>; O'Sullivan, Kevin <kevin.osullivan@intel.com>; jhascoet <ju.hascoet@gmail.com>; Coyle, David <david.coyle@intel.com>; Anoob Joseph <anoobj@marvell.com>
Subject: RE: [EXTERNAL] [PATCH] driver: crypto: scheduler: fix session size computation

Hi Kai,
Please review.

> From: Julien Hascoet <ju.hascoet@gmail.com>
>
> The crypto scheduler session size computation was taking
> into account only the worker session sizes and not its own.
>
> Fixes: e2af4e403c1 ("crypto/scheduler: support DOCSIS security protocol")
> Cc: stable@dpdk.org
>
> Signed-off-by: Julien Hascoet <ju.hascoet@gmail.com>
> ---
>  drivers/crypto/scheduler/scheduler_pmd_ops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/scheduler/scheduler_pmd_ops.c
> b/drivers/crypto/scheduler/scheduler_pmd_ops.c
> index a18f7a08b0..6e43438469 100644
> --- a/drivers/crypto/scheduler/scheduler_pmd_ops.c
> +++ b/drivers/crypto/scheduler/scheduler_pmd_ops.c
> @@ -185,7 +185,7 @@ scheduler_session_size_get(struct scheduler_ctx
> *sched_ctx,
>                uint8_t session_type)
>  {
>        uint8_t i = 0;
> -     uint32_t max_priv_sess_size = 0;
> +     uint32_t max_priv_sess_size = sizeof(struct scheduler_session_ctx);
>
>        /* Check what is the maximum private session size for all workers */
>        for (i = 0; i < sched_ctx->nb_workers; i++) {


[-- Attachment #2: Type: text/html, Size: 2931 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [EXTERNAL] [PATCH] driver: crypto: scheduler: fix session size computation
  2024-10-04  9:04   ` Ji, Kai
@ 2024-10-09 13:57     ` Akhil Goyal
  0 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2024-10-09 13:57 UTC (permalink / raw)
  To: Ji, Kai, dev, Mcnamara, John
  Cc: stable, O'Sullivan, Kevin, jhascoet, Coyle, David, Anoob Joseph

> Acked-by: Kai Ji <kai.ji@intel.com>

Applied to dpdk-next-crypto
Thanks.
Updated .mailmap
Updated patch title

> From: Akhil Goyal <gakhil@marvell.com>
> Sent: 19 July 2024 14:06
> To: dev@dpdk.org <dev@dpdk.org>; Ji, Kai <kai.ji@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Cc: stable@dpdk.org <stable@dpdk.org>; O'Sullivan, Kevin
> <kevin.osullivan@intel.com>; jhascoet <ju.hascoet@gmail.com>; Coyle, David
> <david.coyle@intel.com>; Anoob Joseph <anoobj@marvell.com>
> Subject: RE: [EXTERNAL] [PATCH] driver: crypto: scheduler: fix session size
> computation
> 
> Hi Kai,
> Please review.
> 
> > From: Julien Hascoet <ju.hascoet@gmail.com>
> >
> > The crypto scheduler session size computation was taking
> > into account only the worker session sizes and not its own.
> >
> > Fixes: e2af4e403c1 ("crypto/scheduler: support DOCSIS security protocol")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Julien Hascoet <ju.hascoet@gmail.com>
> > ---
> >  drivers/crypto/scheduler/scheduler_pmd_ops.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/crypto/scheduler/scheduler_pmd_ops.c
> > b/drivers/crypto/scheduler/scheduler_pmd_ops.c
> > index a18f7a08b0..6e43438469 100644
> > --- a/drivers/crypto/scheduler/scheduler_pmd_ops.c
> > +++ b/drivers/crypto/scheduler/scheduler_pmd_ops.c
> > @@ -185,7 +185,7 @@ scheduler_session_size_get(struct scheduler_ctx
> > *sched_ctx,
> >                uint8_t session_type)
> >  {
> >        uint8_t i = 0;
> > -     uint32_t max_priv_sess_size = 0;
> > +     uint32_t max_priv_sess_size = sizeof(struct scheduler_session_ctx);
> >
> >        /* Check what is the maximum private session size for all workers */
> >        for (i = 0; i < sched_ctx->nb_workers; i++) {
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-09 13:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-05 12:57 [PATCH] driver: crypto: scheduler: fix session size computation jhascoet
2024-07-19 13:06 ` [EXTERNAL] " Akhil Goyal
2024-10-04  9:04   ` Ji, Kai
2024-10-09 13:57     ` Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).