From: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
To: "Marchand, David" <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
Jerin Jacob <jerinj@marvell.com>,
Akhil Goyal <gakhil@marvell.com>,
Volodymyr Fialko <vfialko@marvell.com>,
"Naga Harish K, S V" <s.v.naga.harish.k@intel.com>
Subject: RE: [PATCH] eventdev: fix build with clang 21
Date: Tue, 4 Nov 2025 14:23:33 +0000 [thread overview]
Message-ID: <DS0PR11MB9456C66582DF2E7AB1D5A671E8C4A@DS0PR11MB9456.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20251104130820.2692144-1-david.marchand@redhat.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, November 4, 2025 6:38 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> Jerin Jacob <jerinj@marvell.com>; Akhil Goyal <gakhil@marvell.com>;
> Volodymyr Fialko <vfialko@marvell.com>; Naga Harish K, S V
> <s.v.naga.harish.k@intel.com>
> Subject: [PATCH] eventdev: fix build with clang 21
>
> Fix 16-bits formatting issues reported by clang 21 on Fedora 43:
>
> ../lib/eventdev/rte_event_crypto_adapter.c:1461:4: error:
> format specifies type 'unsigned char' but the argument has type
> 'uint16_t' (aka 'unsigned short') [-Werror,-Wformat]
> 1459 | RTE_EDEV_LOG_ERR("Failed to get adapter caps dev %" PRIu8
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1460 | " cdev %" PRIu8, adapter->eventdev_id,
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1461 | adapter->next_cdev_id);
> | ^~~~~~~~~~~~~~~~~~~~~~
>
> ../lib/eventdev/rte_event_crypto_adapter.c:1592:46: error:
> format specifies type 'unsigned char' but the argument has type
> 'uint16_t' (aka 'unsigned short') [-Werror,-Wformat]
> 1592 | RTE_EDEV_LOG_ERR("Invalid dev_id=%" PRIu8, cdev_id);
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
>
> ../lib/eventdev/rte_event_crypto_adapter.c:1613:45: error:
> format specifies type 'unsigned char' but the argument has type
> 'uint16_t' (aka 'unsigned short') [-Werror,-Wformat]
> 1612 | RTE_EDEV_LOG_ERR("Event vectorization is not supported,"
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1613 | "dev %" PRIu8 " cdev %" PRIu8, dev_id, cdev_id);
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
>
> Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type")
> Fixes: 04ed18cd41f1 ("eventdev/crypto: support runtime set/get parameters")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: abhinandan.gujjar@intel.com
> ---
> lib/eventdev/rte_event_crypto_adapter.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/eventdev/rte_event_crypto_adapter.c
> b/lib/eventdev/rte_event_crypto_adapter.c
> index b827a0ffd6..3f9cc7379a 100644
> --- a/lib/eventdev/rte_event_crypto_adapter.c
> +++ b/lib/eventdev/rte_event_crypto_adapter.c
> @@ -1457,7 +1457,7 @@ crypto_adapter_cap_check(struct
> event_crypto_adapter *adapter)
> &caps);
> if (ret) {
> RTE_EDEV_LOG_ERR("Failed to get adapter caps dev %" PRIu8
> - " cdev %" PRIu8, adapter->eventdev_id,
> + " cdev %" PRIu16, adapter->eventdev_id,
> adapter->next_cdev_id);
> return ret;
> }
> @@ -1589,7 +1589,7 @@ rte_event_crypto_adapter_vector_limits_get(
> RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
>
> if (!rte_cryptodev_is_valid_dev(cdev_id)) {
> - RTE_EDEV_LOG_ERR("Invalid dev_id=%" PRIu8, cdev_id);
> + RTE_EDEV_LOG_ERR("Invalid dev_id=%" PRIu16, cdev_id);
> return -EINVAL;
> }
>
> @@ -1610,7 +1610,7 @@ rte_event_crypto_adapter_vector_limits_get(
>
> if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_EVENT_VECTOR)) {
> RTE_EDEV_LOG_ERR("Event vectorization is not supported,"
> - "dev %" PRIu8 " cdev %" PRIu8, dev_id,
> cdev_id);
> + "dev %" PRIu8 " cdev %" PRIu16, dev_id,
> cdev_id);
> return -ENOTSUP;
> }
>
> --
> 2.51.0
prev parent reply other threads:[~2025-11-04 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 13:08 David Marchand
2025-11-04 14:23 ` Gujjar, Abhinandan S [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DS0PR11MB9456C66582DF2E7AB1D5A671E8C4A@DS0PR11MB9456.namprd11.prod.outlook.com \
--to=abhinandan.gujjar@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=s.v.naga.harish.k@intel.com \
--cc=stable@dpdk.org \
--cc=vfialko@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).