From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52E5743C27; Fri, 8 Mar 2024 19:22:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B2E340E28; Fri, 8 Mar 2024 19:22:13 +0100 (CET) Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2095.outbound.protection.outlook.com [40.107.249.95]) by mails.dpdk.org (Postfix) with ESMTP id 096D9402E2 for ; Fri, 8 Mar 2024 19:22:12 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gUrNjbgvNQ8oEu5r5dMVIKJhnlpx/jJ0b4LoMOGtSXRx3HRZgO5SDRc1q3/0sA6bSo1dSJdNjZrYR+QK0RB7DPAuMY/vpYzbL5HMHJ4lamWgpbcqiLE16SDc5526LZ2WQ1MHM+rDUZx+xphccrnBCMSbtkWBXNgwr8Wm2LdGNUejkYAQRDBeW+7bHf+ocpFkfPVlcwlatSSy/AzcsaxdQbeqvc+dgymgwmhKVOkGl2Mi6XOsE0Vyp+JWhYcg+bEqXyLaOWgwaOyV4ZcW/Lcm+GnVfR/ghPFvr+VHCYe6LeubQnmdMBr2S8iYdL305KL5R8XDxt4omRWHnDJ/+HZe2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dPsgGpRBXE/Z3rt7BTYdBEmkjTMgbCm4aVWASup4WPg=; b=c05EmGAbPqgXwPR4HVFuMTzg20X6gyq40VwN9zGeuEKZRMEWC60DZpLE0lkoH+UTp5aMzXeU0bVLh5VOacv2EvFvW3Rr/8BumslwyA5ozPJhF8M5RMewnI2FtgHS03u8Jgyv93uX0LhVO+rvQ2IihzpfpIx3WSasEDEgvVeQXtvH7KLy+SmX51U5l8CFMlUXLlhRgEoUGKILePEshNEYYGCnkAqHeM+rNh9+blYpQ9nbFL+/voh79pYRSxXAGA1B3WWBcsagIL0/9Ht9YsfkE+aCBoxWm+3I1hRbibbAlx/lrDfIoLC+L/J9SX/qW7ctfPWOGv9sf0tPKFsv6/HCPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dPsgGpRBXE/Z3rt7BTYdBEmkjTMgbCm4aVWASup4WPg=; b=TnS5YTlhDDqsKPVpIsVKVOK7qpU0OrQtCjWjaRdhQNljK0dntPd22ADHStqN3w5SzEG+tuaW3BpOnTW3LjfWAYz9mBa0Hdq2QuKn02l+ppByZjVapSpdHCUcDBkOoG2LsiDaOU5nuUN4G4srP9dKjXcoU1uLCZcNfQEECDa0EIw= Received: from DU0PR83MB0532.EURPRD83.prod.outlook.com (2603:10a6:10:314::5) by GVXPR83MB0581.EURPRD83.prod.outlook.com (2603:10a6:150:15b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.9; Fri, 8 Mar 2024 18:21:56 +0000 Received: from DU0PR83MB0532.EURPRD83.prod.outlook.com ([fe80::d876:e1dc:284a:fc57]) by DU0PR83MB0532.EURPRD83.prod.outlook.com ([fe80::d876:e1dc:284a:fc57%6]) with mapi id 15.20.7386.011; Fri, 8 Mar 2024 18:21:56 +0000 From: Alan Elder To: Long Li , stephen CC: Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" Subject: RE: [PATCH] net/netvsc: fix number Tx queues > Rx queues Thread-Topic: [PATCH] net/netvsc: fix number Tx queues > Rx queues Thread-Index: AQHaa3y8pbeDbgsdTE6MswPriT1nKbEuM8gA Date: Fri, 8 Mar 2024 18:21:56 +0000 Message-ID: References: <20240229135332.17f2fa50@hermes.local> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=81066abc-d2dc-46ba-b94d-7d7796651ac3; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-03-01T02:02:46Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DU0PR83MB0532:EE_|GVXPR83MB0581:EE_ x-ms-office365-filtering-correlation-id: bd24d165-de49-4c7d-7253-08dc3f9ca2fc x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dVXVU447Iq4dF8/QUMsrIJFCBIUugExLoJ9gVtpEW9w4O7kZuTN2ZCZlvOYREdARod5nHUkrWUVowytafh60h01Xqojw+qCKrYhzvZriu6JaTb4Lu7vYRGy9CY417n8kryfIyW2iL2IQd97JKpn3mWyGpLhE4DUmwHNI5WiA0QbotceTln4Asy8TSqJHA/GJmZwQP4IJLTEWKoIPpjAaXtMlXOUlRRifcAFvMFx8Hu1i+P76PrkuJmlhnBVCxmFBcuqHXN5svni0hL4IGFJXhWT2XBsUH15OGshpuKJ9+j5oNQrpXvGo/Aqaqoo4f37W3JFfCeI/aVRgcDIJNbCYbMYvo8oVHie/NykawdTM1utYDNdta+TyISal48LWy8RMbm4go8VHRsr4xuCs4mP64u7ew1KYCI1/v+Fpjv0GDLjlWsv6cR90nk4q8Z7HR/Z5yNn94xHdXatkqGKPfzLkUnj6bUQD61xE4l1jc9YTSeTSBHhimS/lWynvyIRYJsby5rypWKOtH3yfCrewiGJQpJN6aoVye0MpuHyorvYh3JnQPQyaVRXTtR91lMol3uKvbiG3GitjeIPNJ77tyBGqNzEbEe8z/WPQ8CQhU4xRlrpJGsEgEiagsP+OKf15aC8cU5Z5RvTg5D6RxL3bPM9jJc3ZtG5biO9xVQvi0D2598GedI5+8xdZhLyf87+agC2ghrAxMYiZAd7RPjJtDFAajRSe7Ch8Ukz4+u60kYxcB2k= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR83MB0532.EURPRD83.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?H0NNfD8gJtPnZBcLJhoAu4bNb4N5miFBHg6247aV0uSl1EsdHEz0C9i0L35M?= =?us-ascii?Q?RYP5VaLXb8UJGb9wfVis6BJ8AC8omKjH7iO0xLxH3odT76g7HdNGh70uMcuE?= =?us-ascii?Q?rgMLqnObov8LkJaYgX0oZ2APS6BafJlp+taKhc2iLDjrf7MGNtoNbvGLR1eR?= =?us-ascii?Q?Fljtk2C4edBCrcbWBu9RQuYWcUGpKPe2+sONbtlt1qsHSRhtbYXZeXaS2lxK?= =?us-ascii?Q?u67sNpfw4xggBEJvLZVZns3gCsJOaJQ3ceQvsgyAxZmS0H729XNCcXQnNLd8?= =?us-ascii?Q?RAdqv6mmmTB4A2W5yTZfINONozJVdPCpV/FjneB3nKS8HGQLw0QE1KtcBpLR?= =?us-ascii?Q?TGgsAgHHRhtT5B4cWK+B5vNAVuE9sPclWbzPW6qO3w5vV8xefErH7EK6xfYG?= =?us-ascii?Q?ZANP27Oksd60cpZ3yHA30pLZbTbsWwVNei85lQIJ+LphY4VLP+LsIr8OhPHm?= =?us-ascii?Q?JreE9pkgKSbNj3p5DoTLGex7cHDjaylKWMp5aVb3tB0cPikIOJduiCSTUsq3?= =?us-ascii?Q?PgyFaQAoPl8gbpyLKZtKW1eFcJeUc9MjnChw+z/Zr/TK8NK9AQh36dCCWPS5?= =?us-ascii?Q?qssJS7y6AXqz+a+R91pgVeNdNb3Jqfyq7Zln6xOe8XurKn/m2twiShu5X8W7?= =?us-ascii?Q?sf67FFemx+XeOvlxROQMUpXr6j0tJ4lHTydRdlBPbeH2xAABAqwG9wJQDhv/?= =?us-ascii?Q?gKCMGMcmCiupxvqpWmx90e5dq/CruG4lyah/IT3YGKCddTPuY5KZ9Ypl6N+g?= =?us-ascii?Q?LHWhwjmYQ8rBVoKbDeN5kvWkTNj5fpFY57FOZP+RjofSYF5EdC8qRPXWjKuT?= =?us-ascii?Q?gyXswc7s64GXVbqKJg8bYSbMrzVJ9Lj08Oyd2iHBNJ893gcTitaTCC2OY4Na?= =?us-ascii?Q?bKNGoOdOeNyeapLNTBWniRpWVY040Qio+96grqyOpTGd2vDWYS57BM7EYqGi?= =?us-ascii?Q?GTkbWT1HDyBgVTdUbkNbK11ta8W4HX9HaFHqaX60K9FZMMS415hRA7cUSFwX?= =?us-ascii?Q?b+WVBGVoCobDNGsQv0j2H/oY5Ldyh72h6jAviz7+607yB1Ia5gFuH3dNn/Zq?= =?us-ascii?Q?duct2x7OfuVFh9uPOVcuEPGTxbQIlWkeZ7QeDsoFJcfFYe+CFR2pMTu67zwh?= =?us-ascii?Q?NiQfhQItHnN2QToeSqaHVLeSu7N0BoEwyY/AML8RDNeTX9VWz1PHbugXAskT?= =?us-ascii?Q?VuUyGEiE12cLAWZhrbLIy4KLNMd1jsYGU76lCtopTOyE6vey4NNam6eg5OX4?= =?us-ascii?Q?k8qe3zdr5oAOa6yu1LzPboN6SIG0if6DNJhRPDvd19tbBtX3MfsGGQMtw14i?= =?us-ascii?Q?y3mscj47jfEyqxIw2nxEi1k3sXbEvfQDm6Qy6mKjVm4E6NIRtVh85+wJoMue?= =?us-ascii?Q?kU/Zkle6Xogu3HRSK3QlXCoDYCTkldubb/Y0xiG9CGfPjPAiOwbVzhWfcC+/?= =?us-ascii?Q?ZZGkQP9yqaopcZEmTGKgMa6FGVoUFA08YSg0p8Rw1bALApOb+EDntI7gkqjL?= =?us-ascii?Q?ETNkURxVZm9oIz9DdfBrkngrjKG6mrWdjwMW?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DU0PR83MB0532.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd24d165-de49-4c7d-7253-08dc3f9ca2fc X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2024 18:21:56.1457 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8FEUdBpjFR32cEifMOX2gwi7GzePMcCAXKtggRyQ8+PGf3jU7EDES3ZBy31VdqVIqw9S+kLuE+m1xaM9vvbADQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR83MB0581 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: RE: [PATCH] net/netvsc: fix number Tx queues > Rx queues >=20 > > Subject: Re: [PATCH] net/netvsc: fix number Tx queues > Rx queues > > > > On Thu, 29 Feb 2024 19:29:11 +0000 > > Alan Elder wrote: > > > > > The previous code allowed the number of Tx queues to be set higher > > > than the number of Rx queues. If a packet was sent on a Tx queue > > > with index > > > >=3D number Rx queues there was a segfault. > > > > > > This commit fixes the issue by creating an Rx queue for every Tx > > > queue meaning that an event buffer is allocated to handle receiving > > > Tx completion messages. > > > > > > mbuf pool and Rx ring are not allocated for these additional Rx > > > queues and RSS configuration ensures that no packets are received on > them. > > > > > > Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") > > > Cc: sthemmin@microsoft.com > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Alan Elder > > > > Don't have Azure account to test, but looks good to me. > > > > Acked-by: Stephen Hemminger >=20 > Please hold on while we are discussing this patch internally with its int= eraction > with MANA. >=20 > Long Thanks for the feedback Long and Stephen. We've discussed the interaction = with MANA and I think we're good to go ahead with this now. I've submitted= v2 of the patch with a minor fix. Cheers, Alan