From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C64D4A0C55; Wed, 13 Oct 2021 20:59:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADA7541209; Wed, 13 Oct 2021 20:59:23 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70049.outbound.protection.outlook.com [40.107.7.49]) by mails.dpdk.org (Postfix) with ESMTP id D70E3411EC for ; Wed, 13 Oct 2021 20:59:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ERqJjIrXPmVxBsn/WShuMGUtUyE7I9cXkADK1MDWO9bzoqnjwUFW42yBSWAct/j5igkqXVq3CYBsPgVKJVN/6VCO5KJ5tepoXpYsikzvlyogZEeKiZ99G8rjebKpbC/FgzSEC8Nt+TFF52dRO8mJlsm+dWVAjDzP9bgnwtb9mUqm7JGQ+K669gNxSo36u4Z2w0Xcj/v/KfUDq4JWdyztYS1F0JJ2C+r5+Ck2k2WsHROH5xtJv54+gl5dmIGfl0264L3hqtrx+ht4UXptaolKVvX4ipzBkwz3ssoXtYYuxm/MLdt8OmZxBWkCJpEikBG+zpfil4jqvT2lVTvdnRTgzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6/5+8GYyi3K2zGKY7iWt7fZ5JnLcQTxZGtutuygfYBM=; b=i2JUvuYgC1OxdYtyz0l24zNiyhjmq6D88bYyDwVu5CDkf/nKvbf+S40Lsz+H2FUqE7b/X/A6AdqrDnH9bbD8OrAq9DAsttiEaWIcPePyU+TimrQ976Vfj+/j2z2tjRz8smH4JWp/LKiFrdLqx2JpmfqMSKoY2W5+qtBt2tmhySTvVhFckAcRQN5H36jFCQyC9skqXVYVbw+Pc4mNy5450KMoDy9kwt46az1QJOJJwvZ9aMD8X/MEaG2Ih7PJdUFqTAUfPWRVdu1b5xQDbsTzuak7vnJgG8Fo9T4SFxmgr0Le67Ww9iqToba+d/BSueQTPfPSqBPLVzZ9nqNHGwuC/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6/5+8GYyi3K2zGKY7iWt7fZ5JnLcQTxZGtutuygfYBM=; b=j65UO9noMKqnE8FKq1Qxbl+muOPXC57AFMvrdl8m8VnXFjwxdWRrzHDpL0XPPLlOihM/V/GFcgOR3rAX2zcZfVc31LtnJo3msTwmrCI29sWktBX3SH2VU1nLU+Iahr2yNc6ZoRaM67e/FdesVFjA/tCKF1pxpsujdRN6Oa0jKp4= Received: from DU2PR04MB8630.eurprd04.prod.outlook.com (2603:10a6:10:2dd::15) by DU2PR04MB8695.eurprd04.prod.outlook.com (2603:10a6:10:2de::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Wed, 13 Oct 2021 18:59:20 +0000 Received: from DU2PR04MB8630.eurprd04.prod.outlook.com ([fe80::945d:e362:712d:1b80]) by DU2PR04MB8630.eurprd04.prod.outlook.com ([fe80::945d:e362:712d:1b80%3]) with mapi id 15.20.4587.026; Wed, 13 Oct 2021 18:59:20 +0000 From: Hemant Agrawal To: Akhil Goyal , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" , "konstantin.ananyev@intel.com" , Gagandeep Singh Thread-Topic: [EXT] [PATCH v3 02/15] crypto: add total raw buffer length Thread-Index: AQHXwGCXEFCnoKsvbEOT9UReBRev9qvRQZIAgAAGcXA= Date: Wed, 13 Oct 2021 18:59:19 +0000 Message-ID: References: <20211013182720.32486-1-hemant.agrawal@nxp.com> <20211013182720.32486-3-hemant.agrawal@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c28b3296-0fe2-4b65-e270-08d98e7b9026 x-ms-traffictypediagnostic: DU2PR04MB8695: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aInXwstrX+PKBf2lwOWHkakf8xVjUJCs3IniXa7cTgV/TjQcotyIhb545uLuiNs/8C8MaPp+WLZ3zkys6TFMvHZUnLTqC4Q6k8PEzzbvQriWRNeR6FaDTp/7JQSEogiohp0FEoRDYf/GKfXpvIAnWC90tZGTiGSfF1bCkTz/dOlBrECbICffX0EjyVBDCvR3yk9T1w/1sNaufP9avCK3RtDMrRvBkwjdVaNPIz2Wyofv1SkIWzbJCyxG5+7uITnDpSGTSPAJyo73VaUnEdo6j9fnltx0nWf8qKjYYcPSupcxhSXGc2fFmYiWNKrmE4mjmAGPEpk5APHAQslu3qBeFKmygTOXoPRqLgwhvf6KLYC2SRC8dpNydkS/oejvYK3OH2WGekdfwY6KaoD7eEhUWW4bPjQwoUcxsGjIeOJnTZ5mrX1VxTScxZA8UlsOzzcS21iwpV1DATix7OmZXquJiJL0r6cB5/C85auD6rfQl9ks6yLMdf7PSvrMWgpaVgVw5ineWNY9Ym3p9MecMEVEXmPFWIFMkmLRc7jGH5F1BLp7eFLrFeqSKWEKjeRS2K835uvvCdUOnpUmeLmArb+U2evXEzzoTV9VkXq63PTAxRkf3nqL8pQKCqPEavtJ2++vNjyRRGRY2nRvm1TKII+phc2JtxsQWD6tkRhB/C4IHTnYHwJRUk2d5vZsnrwTQ/fcOQ6aDTI+1GsgRX1NoaSttQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8630.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(9686003)(33656002)(44832011)(8936002)(316002)(38100700002)(83380400001)(122000001)(71200400001)(66476007)(55016002)(66946007)(53546011)(6506007)(8676002)(186003)(7696005)(5660300002)(38070700005)(4326008)(55236004)(52536014)(26005)(2906002)(66446008)(110136005)(54906003)(508600001)(76116006)(64756008)(66556008)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PIHBiOTN2oJ4GUwW0PLAVGZIAYJCkltWvA2YsrKWdtcs1uYdIqltuJzOpvUs?= =?us-ascii?Q?inGN3duhArchHXGeBY9ECYQcfW/c/xF/5+DHr80r6TnPI73ixfWfIDv6NAXG?= =?us-ascii?Q?EznkFY9zanEtqm8cloe7i45n0t8zXMEK597UpXPmtK36pxY+1WrJ+BMW/pvv?= =?us-ascii?Q?1T+wvDL5FQYxO9pv1dQscOeOSzcQUD4HKdrpAs/pR9l2UgWCx7kA3tNkbaWY?= =?us-ascii?Q?BHBIiI3d6ArjasKrFaj3j7Rg6HCxnSpku2OjpaDr1s9mI04kBPN2psB6plKg?= =?us-ascii?Q?ylnEsy9tW66CE60ZXrlGD/CIb1NsgHfoOUV18F/SFH6nXJ8NSo42L1avpNdg?= =?us-ascii?Q?b7fyhI+BmBg8e8aRI5q5mt/zmn8Nd/XFHiv5k6UcAAFi+ac7KSady07w+ppa?= =?us-ascii?Q?HHelwm2NqAvgmRtP/XMcMPIF1OqFVd7y6qdmIzW0LhzBX5+JSgwpGZUqEAZr?= =?us-ascii?Q?+UoZ2VVEmNY723hZh2tcqqXfKjadAGXZNbtBbFfrRqBh+6G68P2X896MIEhB?= =?us-ascii?Q?523leUptEyOp5fiwzyQlDqGFjVELabgBShp3K56ANkF2ht4OVRcvke33MwRI?= =?us-ascii?Q?Dm7n7ie1xBdgyOCT+qfqaNh3BImjRIjuZw8vogT7dOuCM1FSmu2xsyrv0pV+?= =?us-ascii?Q?YOypQcPLkVbBlCfUlXeyGc12GFx9Z7CKXhMrFAF2SgwR+oiplMP0770XZ+zm?= =?us-ascii?Q?RYGLYmxnF8iOM8FaQ7jx58iurRb6Oe/XntKpOP1ho85sxxlzc8NY3Bu7GFgq?= =?us-ascii?Q?QA3kanliyrOCJ2l5wdP/tySxST0nq1YtJvSIdvA7rhi3+wwQwnJ3qK0RWoGy?= =?us-ascii?Q?77RdqBH6T2zvRS5jl/xQE3mBDSLuo3VenlqIOUexwhzWIMDFUie1r7aujO25?= =?us-ascii?Q?uKYc0xDsUlWwEKuDRnuveZUVOKeQ3lvausZ1wLaXnvuqF43ClZBzbAA4zSfq?= =?us-ascii?Q?Z+GVGsAhdCfRUyXQPgFH7fm/G89+fkHJuGKpii5lj/zh16kw2L/m3PyAiBxC?= =?us-ascii?Q?WV/E5bKdaMiFfY4n1+usBcsf3rtNz7N8hPatrZs/V5LIFuf2mRSnb2J6Q2RE?= =?us-ascii?Q?5zEt32HXqZThfXyLYd16BwFZfs6z/M8QQISCzwpdImImYX6O2PlfVbNIuSvo?= =?us-ascii?Q?q8MCuHqjdIF9CfBhO66AgsupppiYkqnDnY+YluKFL9FCVN3Bq+zf1ne4VXRI?= =?us-ascii?Q?b2G5fj0xZNWcPcoPaJTKdEs3PFyD34OaAeSkwW4QHkswImINu1z44RPHt8Ix?= =?us-ascii?Q?7Nw1jhX9n8WgTOli602Ow5UtiYS6kz2sgP7EgPGtPqePpufPHiRPUSlNBfgF?= =?us-ascii?Q?0mZIu34TjzERqUtFr/e1O7i9?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8630.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c28b3296-0fe2-4b65-e270-08d98e7b9026 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2021 18:59:19.9060 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: heC7ujkwJKn+EI/gUfsgIjh6EhSYhMs735H2bPoJOZ30Ua9s4OkrB/gQD8Pl5cwprbEHErSQJWHHGdTjDY5mkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8695 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 02/15] crypto: add total raw buffer length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Akhil Goyal > Sent: Thursday, October 14, 2021 12:06 AM > To: Hemant Agrawal ; dev@dpdk.org > Cc: roy.fan.zhang@intel.com; konstantin.ananyev@intel.com; Gagandeep > Singh > Subject: Re: [dpdk-dev] [EXT] [PATCH v3 02/15] crypto: add total raw buff= er > length > Importance: High >=20 > > From: Gagandeep Singh > > > > The current crypto raw data vectors is extended to support > > rte_security usecases, where we need total data length to know how > > much additional memory space is available in buffer other than data > > length so that driver/HW can write expanded size data after > > encryption. > > > > Signed-off-by: Gagandeep Singh > > Acked-by: Akhil Goyal > > --- > > doc/guides/rel_notes/deprecation.rst | 7 ------- > > lib/cryptodev/rte_crypto_sym.h | 6 ++++++ > > 2 files changed, 6 insertions(+), 7 deletions(-) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > b/doc/guides/rel_notes/deprecation.rst > > index f3c998a655..4b26ef6747 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -211,13 +211,6 @@ Deprecation Notices > > This field will be null for inplace processing. > > This change is targeted for DPDK 21.11. > > > > -* cryptodev: The structure ``rte_crypto_vec`` would be updated to add > > - ``tot_len`` to support total buffer length. > > - This is required for security cases like IPsec and PDCP encryption > > offload > > - to know how much additional memory space is available in buffer > > other than > > - data length so that driver/HW can write expanded size data after > > encryption. > > - This change is targeted for DPDK 21.11. > > - > > * cryptodev: Hide structures ``rte_cryptodev_sym_session`` and > > ``rte_cryptodev_asym_session`` to remove unnecessary indirection > > between > > session and the private data of session. An opaque pointer can be > > exposed diff --git a/lib/cryptodev/rte_crypto_sym.h > > b/lib/cryptodev/rte_crypto_sym.h index dcc0bd5933..e5cef1fb72 100644 > > --- a/lib/cryptodev/rte_crypto_sym.h > > +++ b/lib/cryptodev/rte_crypto_sym.h > > @@ -37,6 +37,8 @@ struct rte_crypto_vec { > > rte_iova_t iova; > > /** length of the data buffer */ > > uint32_t len; > > + /** total buffer length*/ > > + uint32_t tot_len; > > }; > > > > /** > > @@ -980,12 +982,14 @@ rte_crypto_mbuf_to_vec(const struct rte_mbuf > > *mb, uint32_t ofs, uint32_t len, > > seglen =3D mb->data_len - ofs; > > if (len <=3D seglen) { > > vec[0].len =3D len; > > + vec[0].tot_len =3D mb->buf_len; > > return 1; > > } > > > > /* data spread across segments */ > > vec[0].len =3D seglen; > > left =3D len - seglen; > > + vec[0].tot_len =3D mb->buf_len; >=20 > I think you missed to update the tot_len as per Konstantin's suggestion. >=20 [Hemant] Sorry, I sent the wrong series