From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDC9EA0548; Thu, 4 Nov 2021 08:34:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 867264115F; Thu, 4 Nov 2021 08:34:25 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2056.outbound.protection.outlook.com [40.107.22.56]) by mails.dpdk.org (Postfix) with ESMTP id 10DDA40E5A; Thu, 4 Nov 2021 08:34:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xt+SS0Ve3QVX3Nhyn3JudMIAiwKV/zDy2nAg0OuJWrY=; b=Bta7845jey9fGSMLXbmx5YP9hAUHu9bY0hOb1lGylFeHEfE0iI1APS10sVqggAC02IOjOX3mjGpvAOeNShmBrHX4Zg6+jKRjqpLXhkDys2PhqxadqqJB1tZbgifMPTrJybyfVXWJ1A9+gqxAga3lJYQtsTy7+OFRMJ+8+udmrWY= Received: from AM6PR08CA0033.eurprd08.prod.outlook.com (2603:10a6:20b:c0::21) by AM6PR08MB3637.eurprd08.prod.outlook.com (2603:10a6:20b:46::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Thu, 4 Nov 2021 07:34:23 +0000 Received: from VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:c0:cafe::b0) by AM6PR08CA0033.outlook.office365.com (2603:10a6:20b:c0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Thu, 4 Nov 2021 07:34:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT023.mail.protection.outlook.com (10.152.18.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Thu, 4 Nov 2021 07:34:22 +0000 Received: ("Tessian outbound 2bb1f94ba47e:v108"); Thu, 04 Nov 2021 07:34:22 +0000 X-CR-MTA-TID: 64aa7808 Received: from 724f61780703.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2CB12D17-6B74-4E46-9B98-B6E9E3C713B4.1; Thu, 04 Nov 2021 07:34:15 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 724f61780703.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 Nov 2021 07:34:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ayUFT/LPDYqnl7RnDoy4ecCPhn+GzN9V68r6isk5Mffz5IP3CPIFpLm6wkYRb3JsypW0FsjnT2/Tdxqrx4cymtZcrPZsmu7JI8oLUY3E6j4L2MiC/88G6WdDpYFIqdQFvoVoCjKSO4pekfLRFp+qtT+kNtLndaHnDaZNQ6QrnOfHxsdkJOekfE9uEKsummT4LRElywck/i5qa7lwRMNIYq7iQVLpTU7TeHc5EFfvFW13mxGOVHV8sJMB3qCf/zT+Bygf37PAY4t6BKyN4irXqq895OEMZOwacoqgEFgHFkfS1ZsPyPUdz91IwgCTtFOm1cyVtXTqhaP3YavXVlT54g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xt+SS0Ve3QVX3Nhyn3JudMIAiwKV/zDy2nAg0OuJWrY=; b=b31MJT+EBd5v9TWicw6KaE6QsmlTtF3XcNMMvgJRjBmTCGJvuHiHF3siZI5Kvc94Jd6lNsdkCWU53c0R4FQPK0+IOwd+mz1g85xOjpDLBfbGcaxzFR3AbV85t8Asu0z6i+90bJ4E8fqaTHhAkUPDi3GxtPeOcqKZIWIzw5Bu6uYdG5MJw6EDHNjrCkPDVusbOM/NzfvqcBnyjFf0luIvnTAnwCIf5g5TuN+XjccDctaR2eLMzUb+QRKCljmhywxfZvdU3LX6S6rHcdqgFg/pry0nNUxGEIQ92t5QOeykgUnrCa5E/afdLPpUMqlaRsNYVSVC+EF/rjEJPl2X948RBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xt+SS0Ve3QVX3Nhyn3JudMIAiwKV/zDy2nAg0OuJWrY=; b=Bta7845jey9fGSMLXbmx5YP9hAUHu9bY0hOb1lGylFeHEfE0iI1APS10sVqggAC02IOjOX3mjGpvAOeNShmBrHX4Zg6+jKRjqpLXhkDys2PhqxadqqJB1tZbgifMPTrJybyfVXWJ1A9+gqxAga3lJYQtsTy7+OFRMJ+8+udmrWY= Received: from DU2PR08MB7287.eurprd08.prod.outlook.com (2603:10a6:10:2d6::20) by DB9PR08MB7147.eurprd08.prod.outlook.com (2603:10a6:10:2cb::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Thu, 4 Nov 2021 07:34:12 +0000 Received: from DU2PR08MB7287.eurprd08.prod.outlook.com ([fe80::455c:4503:6b3a:1b05]) by DU2PR08MB7287.eurprd08.prod.outlook.com ([fe80::455c:4503:6b3a:1b05%8]) with mapi id 15.20.4669.011; Thu, 4 Nov 2021 07:34:11 +0000 From: Joyce Kong To: "Walsh, Conor" , Ori Kam , "Mcnamara, John" , Conor Fogarty CC: "dev@dpdk.org" , nd , "stable@dpdk.org" Thread-Topic: [PATCH v1] examples/flow_filtering: fix wrong comment Thread-Index: AQHX0JapcDFs+PrPEEW8+9PWyoYOTavy+ysg Date: Thu, 4 Nov 2021 07:34:11 +0000 Message-ID: References: <20211103024103.2420-1-joyce.kong@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: AB54CBFED810704FA9DFA6BEF968B03F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: e24daff9-96c6-4f88-37fd-08d99f658558 x-ms-traffictypediagnostic: DB9PR08MB7147:|AM6PR08MB3637: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: G1yDwQrAQmsWheO4ECLb82SFCi7jr4MYx+EqxobjRFM/U72rDVwR9pZYeDivgR8EkBhN3aeO0pcGeH74EmKEgWF9VMCr14kKv5eoLBUxn1MeCvTh0AGwdiRhz5lNL2QLlXsfiVi1B9Dr2KpfUOrI5TozDkDe5oHcyEQQJIr6QafroVDaQfAurjSXHs9baOhvyfgRwIfl69ddjjQ67T/7XnhBG4iagKJYbE5O0q8c/Z3hITmvyIPn4DR3lbutBtQjj237Eq/IcqCbX28IAkuDmAU5azYNCXMZ0sYUDFaUzgR5tbqs66h1og6OL11AGpZjAT3//vCb5YQ5AjMGpoI5nUrT4Ujzu3IRWkPgDzhYt0quoeEPycOxNSXCZB8lIcBSesxQMSsBcTzjLxfxVOOK9Bk13ECRcYxc7GQC7bSRqs7p+2KdiwakEJQV9veqkG14okZjlyv4xUzLAx5xd8gJC7tHlAa/ktcUuTt2pe+HKx5yN+MeyGjOpP/gRY8iSDevrcnJlc9jolV0A9hixh0Moyg6qnRP/ArhHMx/zlgZowLvC8Xh/crwurSVu+9R+ufgYsAk5Ln9qcXqvhhUbr4IAY00OvrqByM+MZKeUROUPKPOHPuKTJqvCk79grAokjYkwsa27QTAsKWo7aodjLghRWD/OD4LfE0zwB4lenMW/RhHyZq24tqZuLkommStOiNdgbQFrTKxX1ktJlPAsRtXtQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR08MB7287.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6506007)(71200400001)(83380400001)(7696005)(122000001)(4326008)(76116006)(66476007)(66556008)(5660300002)(64756008)(66446008)(8676002)(66946007)(86362001)(508600001)(2906002)(38070700005)(52536014)(33656002)(26005)(316002)(55016002)(110136005)(54906003)(9686003)(186003)(8936002)(38100700002); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7147 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ba0f3c69-c0bc-471e-94e4-08d99f657eaa X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jw0KJ3cTbKuk2clyPduNPtjdIy1w5uqI8UmK1NG2rDlsTqig31t6M0YEY73d8FtJaV0XSk9IJ98r8OZbIZn2hTjelmSnE/IGxIlXQbe31IT3VQ3PKDqvtjlx3jXS6Uqicow9atOYIOWPEV8e34So1joNNZoSOOp9/dgL3AiBCWAWKx85/1VMbHzgoT2Pg+zQsifx78+1HDCobA8QdrractYBpRO8725uGItX07TB4fsfibKMgJaB5WJz5PcRu28VoJCYVBWqvV+AmB6o2WCE6tNbU75+2FO/76BxBSxiYLnnuBjCLrNo9uyB8tX0//OI5n22SJ1dad3lGW8npxX7nnSwftAtZNYa0/s8PpJVKhdEZoIc6u6iLEFV/fJsiRUIWCZJM/7/wxeTie+sYcs6LZXspy0pM3QRmW0BXbNNLWoseFsBqTYMkl4hAToW+EMG1nPSnDLglQkIYNCDy9n5Hr81vJUKBSeURLSRzyDnVP+vWWMZl7Ca+XRDJpbzMQUxXG6Smd9U1bBv/qT3Gbqrh+Tj5KdtdfYhdQkzlsuxWEgAgW/LG9B1toA2AY+lCqxUrf2JlBcx0fQq93cIy3B2ATd2tU41JEaUYdEXCf9ATo1i8s3GaykjVkcViMZQNEVS7t3eZpTwvseoUtkJDTLrkvx0Fw8Tum71fjfpkEFLd+8xqWO0dnRMCSMSuscDAdG4BAXEovT1swD/gJM3g6gcZw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(54906003)(450100002)(186003)(82310400003)(8936002)(26005)(83380400001)(6506007)(70206006)(70586007)(36860700001)(336012)(81166007)(2906002)(356005)(110136005)(86362001)(508600001)(8676002)(47076005)(5660300002)(9686003)(7696005)(316002)(55016002)(52536014)(33656002)(4326008); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2021 07:34:22.5821 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e24daff9-96c6-4f88-37fd-08d99f658558 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3637 Subject: Re: [dpdk-dev] [PATCH v1] examples/flow_filtering: fix wrong comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > --- > > examples/flow_filtering/flow_blocks.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/examples/flow_filtering/flow_blocks.c > > b/examples/flow_filtering/flow_blocks.c > > index 3251ed9f8f..b168dc6e71 100644 > > --- a/examples/flow_filtering/flow_blocks.c > > +++ b/examples/flow_filtering/flow_blocks.c > > @@ -75,7 +75,7 @@ generate_ipv4_flow(uint16_t port_id, uint16_t rx_q, > > * ipv4 we set this level to allow all. > > */ > > > > - /* IPv4 we set this level to allow all. 8< */ > > + /* ETH we set this level to allow all. 8< */ > > pattern[0].type =3D RTE_FLOW_ITEM_TYPE_ETH; > > /* >8 End of setting the first level of the pattern. */ >=20 > Hi Joyce, >=20 > This can't be applied as is, it will break the docs build as follows: > doc/guides/sample_app_ug/flow_filtering.rst:225: WARNING: start-after > pattern not found: IPv4 we set this level to allow all. 8< >=20 > The comment is a tag used by the docs to locate a snippet within the code= so > the corresponding tag must be changed in the docs. > The following must be added to this patch: >=20 > diff --git a/doc/guides/sample_app_ug/flow_filtering.rst > b/doc/guides/sample_app_ug/flow_filtering.rst > index 11da9148ca..e8605f36f2 100644 > --- a/doc/guides/sample_app_ug/flow_filtering.rst > +++ b/doc/guides/sample_app_ug/flow_filtering.rst > @@ -224,7 +224,7 @@ Setting the first level of the pattern ETH: >=20 > .. literalinclude:: ../../../examples/flow_filtering/flow_blocks.c > :language: c > - :start-after: IPv4 we set this level to allow all. 8< > + :start-after: ETH we set this level to allow all. 8< > :end-before: >8 End of setting the first level of the pattern. > :dedent: 1 >=20 > Thanks, > Conor. Hi Conor, please see V2. Thanks, Joyce