* [PATCH] net/mlx5: fix transceiver warning when not exist
@ 2025-05-05 12:14 Yogev Chaimovich
0 siblings, 0 replies; 2+ messages in thread
From: Yogev Chaimovich @ 2025-05-05 12:14 UTC (permalink / raw)
To: dsosnowski, viacheslavo, bingz, orika, suanmingm, matan
Cc: dev, Yogev Chaimovich
[-- Attachment #1.1: Type: text/plain, Size: 2 bytes --]
[-- Attachment #1.2: Type: text/html, Size: 562 bytes --]
[-- Attachment #2: 0001-net-mlx5-fix-transceiver-warning-when-not-exist.patch --]
[-- Type: application/octet-stream, Size: 1252 bytes --]
From ffe666291bc531b89620cc28a7b45fa209700f35 Mon Sep 17 00:00:00 2001
From: yogev <yogev@cgstowernetworks.com>
Date: Sun, 4 May 2025 23:11:46 +0300
Subject: [PATCH] net/mlx5: fix transceiver warning when not exist
In case no transceiver exist when trying to get the transceiver's info
There should not be an error message from the library.
The caller may print an appropriate error message using the relevant rte_errno if required.
Signed-off-by: yogev <yogev@cgstowernetworks.com>
---
drivers/net/mlx5/linux/mlx5_ethdev_os.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
index e192f698d8..ba5fd2d253 100644
--- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
+++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
@@ -1253,8 +1253,10 @@ mlx5_get_module_info(struct rte_eth_dev *dev,
}
ret = mlx5_ifreq(dev, SIOCETHTOOL, &ifr);
if (ret) {
- DRV_LOG(WARNING, "port %u ioctl(SIOCETHTOOL) failed: %s",
- dev->data->port_id, strerror(rte_errno));
+ if (rte_errno != EIO) {
+ DRV_LOG(WARNING, "port %u ioctl(SIOCETHTOOL) failed: %s",
+ dev->data->port_id, strerror(rte_errno));
+ }
return ret;
}
modinfo->type = info.type;
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] net/mlx5: fix transceiver warning when not exist
@ 2025-05-06 13:31 yogev
0 siblings, 0 replies; 2+ messages in thread
From: yogev @ 2025-05-06 13:31 UTC (permalink / raw)
To: Dariusz Sosnowski, Viacheslav Ovsiienko, Bing Zhao, Ori Kam,
Suanming Mou, Matan Azrad
Cc: dev, yogev
In case no transceiver exist when trying to get the transceiver's info
There should not be an error message from the library.
The caller may print an appropriate error message using the relevant rte_errno if required.
Bugzilla ID: 1690
Signed-off-by: yogev <yogev@cgstowernetworks.com>
---
drivers/net/mlx5/linux/mlx5_ethdev_os.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
index e192f698d8..ba5fd2d253 100644
--- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
+++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
@@ -1253,8 +1253,10 @@ mlx5_get_module_info(struct rte_eth_dev *dev,
}
ret = mlx5_ifreq(dev, SIOCETHTOOL, &ifr);
if (ret) {
- DRV_LOG(WARNING, "port %u ioctl(SIOCETHTOOL) failed: %s",
- dev->data->port_id, strerror(rte_errno));
+ if (rte_errno != EIO) {
+ DRV_LOG(WARNING, "port %u ioctl(SIOCETHTOOL) failed: %s",
+ dev->data->port_id, strerror(rte_errno));
+ }
return ret;
}
modinfo->type = info.type;
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-06 13:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-05 12:14 [PATCH] net/mlx5: fix transceiver warning when not exist Yogev Chaimovich
2025-05-06 13:31 yogev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).