From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 057B3A0350; Wed, 6 May 2020 10:56:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D8EBE1D658; Wed, 6 May 2020 10:56:04 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 7E56D1D655 for ; Wed, 6 May 2020 10:56:03 +0200 (CEST) IronPort-SDR: 6Nd9O4TzBCb8iLt5kL22vYWztfK3ajLVtsEK3PXsSdUSbh1mgFUvdN/LXAi0vfpgYwghQu3O3Y zQjUqEpv4aZw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2020 01:55:59 -0700 IronPort-SDR: AYnEbYkFyvxdN6IbBt55ZE85pFkmNi5agEutTHPGh5ipm+9zoi1VmrPqBa5qt+xKAWt/NpGMgw 63Q4MmkqqOQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,358,1583222400"; d="scan'208";a="338937128" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 06 May 2020 01:55:59 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 May 2020 01:55:58 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 May 2020 01:55:58 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.210]) by shsmsx102.ccr.corp.intel.com ([169.254.2.38]) with mapi id 14.03.0439.000; Wed, 6 May 2020 16:55:55 +0800 From: "Xu, HailinX" To: "Wang, ShougangX" , "dev@dpdk.org" CC: "Xing, Beilei" , "Yang, Qiming" , "Wang, ShougangX" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix failing to create FDIR flow Thread-Index: AQHWI25wrrJ8qxk4nEajn4TL0Kxbd6iavzZw Date: Wed, 6 May 2020 08:55:54 +0000 Message-ID: References: <20200506061455.102358-1-shougangx.wang@intel.com> In-Reply-To: <20200506061455.102358-1-shougangx.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix failing to create FDIR flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: Xu, Hailin Regards, Xu, Hailin -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shougang Wang Sent: Wednesday, May 6, 2020 2:15 PM To: dev@dpdk.org Cc: Xing, Beilei ; Yang, Qiming ; Wang, ShougangX Subject: [dpdk-dev] [PATCH] net/i40e: fix failing to create FDIR flow This patch fixes the issue that the flow which both source MAC mask and des= tination MAC mask are all zeros can not be created. Fixes: ea0c22fd8227 ("net/i40e: enable MAC address as flow director input s= et") Signed-off-by: Shougang Wang --- drivers/net/i40e/i40e_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c in= dex 7e64ae53a..fa6ab4fbf 100644 --- a/drivers/net/i40e/i40e_flow.c +++ b/drivers/net/i40e/i40e_flow.c @@ -2643,7 +2643,8 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev, filter->input.flow.l2_flow.src =3D eth_spec->src; input_set |=3D (I40E_INSET_DMAC | I40E_INSET_SMAC); - } else { + } else if (!rte_is_zero_ether_addr(ð_mask->src) || + !rte_is_zero_ether_addr(ð_mask->dst)) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, item, -- 2.17.1