From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF720A00C3; Fri, 15 May 2020 08:14:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 574AF1D9D8; Fri, 15 May 2020 08:14:32 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8E6861D9D4; Fri, 15 May 2020 08:14:30 +0200 (CEST) IronPort-SDR: V2AjtSKj/iLla66IDT2squ9vhqm0xGq4fsfLsVQfM4f86VtK0hYjIIXNo2Q8O+JbiBoICu+/Gc gIlvrKdbcN4g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2020 23:14:29 -0700 IronPort-SDR: qDgRTgGzUdkrMUnqQs2q+5an/fz2Aa5l53B8KcdmW2NxGBq+FId4me51tlQzet4HCb51YJkEjp b1unXp5fOgWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,394,1583222400"; d="scan'208";a="341877535" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 14 May 2020 23:14:28 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 May 2020 23:14:28 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 May 2020 23:14:28 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.181]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.177]) with mapi id 14.03.0439.000; Fri, 15 May 2020 14:14:25 +0800 From: "Xu, HailinX" To: "Wang, ShougangX" , "Iremonger, Bernard" , "dev@dpdk.org" CC: "Xing, Beilei" , "Guo, Jia" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in RSS flow Thread-Index: AQHWKNkrR9Z6mBVsp0ui0MIB49t+5KilRgQAgAFd/gCAAgnWIA== Date: Fri, 15 May 2020 06:14:24 +0000 Message-ID: References: <20200424085225.27655-1-shougangx.wang@intel.com> <20200513033320.15771-1-shougangx.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in RSS flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: Xu, Hailin Regards, Xu, Hailin -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wang, ShougangX Sent: Thursday, May 14, 2020 3:04 PM To: Iremonger, Bernard ; dev@dpdk.org Cc: Xing, Beilei ; Guo, Jia ; sta= ble@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in RSS = flow Hi, Bernad > -----Original Message----- > From: Iremonger, Bernard > Sent: Wednesday, May 13, 2020 6:12 PM > To: Wang, ShougangX ; dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia=20 > ; Wang, ShougangX ;=20 > stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in=20 > RSS flow >=20 > Hi Shougang, >=20 > > -----Original Message----- > > From: dev On Behalf Of Shougang Wang > > Sent: Wednesday, May 13, 2020 4:33 AM > > To: dev@dpdk.org > > Cc: Xing, Beilei ; Guo, Jia=20 > > ; Wang, ShougangX ;=20 > > stable@dpdk.org > > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in=20 > > RSS flow > > > > This patch fixes the issue that the queue region does not take=20 > > effect due to incorrectly setting the flow type. > > > > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") > > Cc: stable@dpdk.org > > > > Signed-off-by: Shougang Wang > > Reviewed-by: Jeff Guo > > --- > > drivers/net/i40e/i40e_flow.c | 35 > ++++++++++++++++++++++++++++++++- > > -- > > 1 file changed, 32 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_flow.c=20 > > b/drivers/net/i40e/i40e_flow.c index 7e64ae53a..2f937567b 100644 > > --- a/drivers/net/i40e/i40e_flow.c > > +++ b/drivers/net/i40e/i40e_flow.c > > @@ -4625,6 +4625,34 @@ i40e_flow_parse_rss_action(struct rte_eth_dev=20 > > *dev, uint32_t index =3D 0; uint64_t hf_bit =3D 1; > > > > +static const struct { > > +uint64_t rss_type; > > +enum i40e_filter_pctype pctype; > > +} pctype_match_table[] =3D { > > +{ETH_RSS_FRAG_IPV4, > > +I40E_FILTER_PCTYPE_FRAG_IPV4}, > > +{ETH_RSS_NONFRAG_IPV4_TCP, > > +I40E_FILTER_PCTYPE_NONF_IPV4_TCP}, > > +{ETH_RSS_NONFRAG_IPV4_UDP, > > +I40E_FILTER_PCTYPE_NONF_IPV4_UDP}, > > +{ETH_RSS_NONFRAG_IPV4_SCTP, > > +I40E_FILTER_PCTYPE_NONF_IPV4_SCTP}, > > +{ETH_RSS_NONFRAG_IPV4_OTHER, > > +I40E_FILTER_PCTYPE_NONF_IPV4_OTHER}, > > +{ETH_RSS_FRAG_IPV6, > > +I40E_FILTER_PCTYPE_FRAG_IPV6}, > > +{ETH_RSS_NONFRAG_IPV6_TCP, > > +I40E_FILTER_PCTYPE_NONF_IPV6_TCP}, > > +{ETH_RSS_NONFRAG_IPV6_UDP, > > +I40E_FILTER_PCTYPE_NONF_IPV6_UDP}, > > +{ETH_RSS_NONFRAG_IPV6_SCTP, > > +I40E_FILTER_PCTYPE_NONF_IPV6_SCTP}, > > +{ETH_RSS_NONFRAG_IPV6_OTHER, > > +I40E_FILTER_PCTYPE_NONF_IPV6_OTHER}, > > +{ETH_RSS_L2_PAYLOAD, > > +I40E_FILTER_PCTYPE_L2_PAYLOAD}, > > +}; >=20 > I don't think this is a complete list of RSS offload types. > See file librte_ethdev/rte_ethdev,h lines 496 to 523. > See also app/test-pmd/config.c lines 77 to 121. >=20 Thanks for your review. We can not contain all the RSS offload types. We need i40e_filter_pctype to= configure the queue region. It only defines some basic pctypes and there i= s no regular between i40e_filter_pctype and RSS offload types. So for "flow= create", it can only configure queue region for these basic pctypes. What = we can do is associate them with RSS offload types. Thanks. Shougang