From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 4C6B37CC7 for ; Wed, 26 Jul 2017 16:52:10 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2017 07:52:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,415,1496127600"; d="scan'208";a="883046392" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 26 Jul 2017 07:52:09 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 26 Jul 2017 07:52:09 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.214]) by fmsmsx122.amr.corp.intel.com ([169.254.5.215]) with mapi id 14.03.0319.002; Wed, 26 Jul 2017 07:52:09 -0700 From: "Wiles, Keith" To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [pktgen PATCH 0/6] fix compilation Thread-Index: AQHTBZRb6xXkAZrcrE6TP0e7BwAohKJl7+yAgAAdXACAAJppAA== Date: Wed, 26 Jul 2017 14:52:08 +0000 Message-ID: References: <20170725222107.23203-1-thomas@monjalon.net> <4FFF6FD7-FAAB-4034-92DC-D1CF27294837@intel.com> <5680989.RRpAUyPcSC@xps> In-Reply-To: <5680989.RRpAUyPcSC@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.49.103] Content-Type: text/plain; charset="us-ascii" Content-ID: <2F3211E8532A3A46A6E4139B338A0D51@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [pktgen PATCH 0/6] fix compilation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jul 2017 14:52:11 -0000 > On Jul 26, 2017, at 12:39 AM, Thomas Monjalon wrote= : >=20 > 26/07/2017 06:54, Wiles, Keith: >>=20 >>> On Jul 25, 2017, at 5:21 PM, Thomas Monjalon wrot= e: >>>=20 >>> Some errors were seen when trying to compile with gcc 7 or clang, >>> for 32-bit, and with DPDK 17.08-rc2. >>>=20 >>> Thomas Monjalon (6): >>> remove unused functions >>> fix screen type saving >>> fix compilation of printf based functions >>> fix compilation with gcc 7 >>> fix 32-bit build >>> fix build with dpdk-17.08-rc2 >>>=20 >>> app/Makefile | 3 --- >>> app/cli-functions.c | 2 +- >>> app/lpktgenlib.c | 12 ++---------- >>> app/pktgen-cmds.c | 18 +++++++++--------- >>> app/pktgen-latency.c | 26 ++++++++++++++------------ >>> app/pktgen-log.c | 1 + >>> app/pktgen-port-cfg.h | 2 +- >>> app/pktgen-stats.c | 47 ++++++++++++++++++++++++++++-------------= ------ >>> lib/cli/cli.c | 2 +- >>> lib/cli/cli_cmds.c | 6 +++--- >>> lib/cli/cli_common.h | 1 + >>> lib/cli/cli_map.c | 2 +- >>> lib/cli/cli_scrn.c | 5 ++++- >>> lib/cli/cli_scrn.h | 1 + >>> lib/common/l2p.c | 34 ---------------------------------- >>> lib/common/mbuf.h | 3 +++ >>> lib/common/port_config.c | 10 +--------- >>> 17 files changed, 71 insertions(+), 104 deletions(-) >>=20 >> Acked by: Keith Wiles >>=20 >> I did apply these changes and in testing with i40e Pktgen now only sends= a few thousand packets then stops sending. I am sure these patches are not= the problem, but did you try out Pktgen to see if it worked with 17.08-rc2= ? Which version of Pktgen did you use? >=20 > I have not tested these patches except for compilation. > I was just trying to enable testing for more people > (with different compilers than yours). >=20 >> I tried with clang and gcc both behave the same. >>=20 >> I noticed a new message: >> i40e_dev_start(): please call hierarchy_commit() before starting the por= t >> i40e_dev_start(): please call hierarchy_commit() before starting the por= t >> i40e_dev_start(): please call hierarchy_commit() before starting the por= t >> i40e_dev_start(): please call hierarchy_commit() before starting the por= t >>=20 >> and I tried to add the call in pktgen, but it had no effect. To me the T= M API should be defaulted to the original mode and just work unless someone= needs to use the TM APIs. The hierarchy_commit routine could not need to b= e called in the normal case is my guess. >=20 > Interesting. > Please start a new email thread for this bug, cc Wenzhuo and Cristian. > Thanks >=20 > PS: I've noticed that you are the author of all the pktgen commits. > Are you using git-am when applying patches from other contributors? Yes, I do use git am, but most changes are based on bug reports and not pat= ches. A few people have requested I do not show their name in the commit lo= gs for some reason or privacy concerns. In this case when I find the TX problem you will see your patches are appli= ed. The previous patch for Intel DPDK, I had squashed it into changes I was= making for all of the copyright changes. I should have stashed my changes = and applied your patch instead, sorry. Regards, Keith