From: "Wiles, Keith" <keith.wiles@intel.com>
To: Matan Azrad <matan@mellanox.com>
Cc: Ophir Munk <ophirmu@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/tap: fix zeroed flow mask configurations
Date: Thu, 2 Aug 2018 12:03:23 +0000 [thread overview]
Message-ID: <E0CB2630-6BAF-46DF-82F1-769F0902A172@intel.com> (raw)
In-Reply-To: <1533205980-7874-1-git-send-email-matan@mellanox.com>
> On Aug 2, 2018, at 5:33 AM, Matan Azrad <matan@mellanox.com> wrote:
>
> The rte_flow meaning of zero flow mask configuration is to match all
> the range of the item value.
> For example, the flow eth / ipv4 dst spec 1.2.3.4 dst mask 0.0.0.0
> should much all the ipv4 traffic from the rte_flow API perspective.
>
> From some kernel perspectives the above rule means to ignore all the
> ipv4 traffic (e.g. Ubuntu 16.04, 4.15.10).
>
> Due to the fact that the tap PMD should provide the rte_flow meaning,
> it is necessary to ignore the spec in case the mask is zero when it
> forwards such like flows to the kernel.
> So, the above rule should be translated to eth / ipv4 to get the
> correct meaning.
>
> Ignore spec configurations when the mask is zero.
>
> Fixes: de96fe68ae95 ("net/tap: add basic flow API patterns and actions")
> Cc: stable@dpdk.org
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Keith Wiles<keith.wiles@intel.com>
Regards,
Keith
next prev parent reply other threads:[~2018-08-02 12:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 10:33 Matan Azrad
2018-08-02 12:03 ` Wiles, Keith [this message]
2018-08-02 14:27 ` Adrien Mazarguil
2018-08-02 17:52 ` Matan Azrad
2018-08-03 8:20 ` Adrien Mazarguil
2018-08-05 6:10 ` Matan Azrad
2018-08-06 9:40 ` Adrien Mazarguil
2018-08-06 9:58 ` Matan Azrad
2018-08-06 10:58 ` [dpdk-dev] [PATCH v2] " Matan Azrad
2018-08-06 13:16 ` Adrien Mazarguil
2018-08-07 14:01 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E0CB2630-6BAF-46DF-82F1-769F0902A172@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).