From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 35B09255 for ; Wed, 28 Jan 2015 15:30:28 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 28 Jan 2015 06:30:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,481,1418112000"; d="scan'208";a="519041953" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga003.jf.intel.com with ESMTP; 28 Jan 2015 06:23:13 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.64]) by irsmsx110.ger.corp.intel.com ([169.254.15.8]) with mapi id 14.03.0195.001; Wed, 28 Jan 2015 14:28:51 +0000 From: "De Lara Guarch, Pablo" To: "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [PATCH v2 0/6] new ntuple filter replaces 2tuple and 5tuple filters Thread-Index: AQHQNhZvh3AluUtmEUOwT8nZbJwgnpzVoDUQ Date: Wed, 28 Jan 2015 14:28:51 +0000 Message-ID: References: <1421286361-11504-1-git-send-email-jingjing.wu@intel.com> <1421912305-2022-1-git-send-email-jingjing.wu@intel.com> In-Reply-To: <1421912305-2022-1-git-send-email-jingjing.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 0/6] new ntuple filter replaces 2tuple and 5tuple filters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2015 14:30:29 -0000 > -----Original Message----- > From: Wu, Jingjing > Sent: Thursday, January 22, 2015 7:38 AM > To: dev@dpdk.org > Cc: Wu, Jingjing; De Lara Guarch, Pablo; Cao, Min; Xu, HuilongX > Subject: [PATCH v2 0/6] new ntuple filter replaces 2tuple and 5tuple filt= ers >=20 > v2 changes: > - remove the code which is already applied in patch "Integrate ethertyp= e > filter in igb/ixgbe driver to new API". > - modify commands' description in doc testpmd_funcs.rst. >=20 > The patch set uses filter_ctrl API to replace old 2tuple and 5tuple filte= r APIs. > It defines ntuple filter to combine 2tuple and 5tuple types. > It uses new functions and structure to replace old ones in igb/ixgbe driv= er, > new commands to replace old ones in testpmd, and removes the old APIs. > It removes the filter's index parameters from user interface, only the > filter's key and assigned queue are visible to user. >=20 > Jingjing Wu (6): > ethdev: define ntuple filter type and its structure > ixgbe: ntuple filter functions replace old ones for 5tuple filter > e1000: ntuple filter functions replace old ones for 2tuple and 5tuple > filter > testpmd: new commands for ntuple filter > ethdev: remove old APIs and structures of 5tuple and 2tuple filters > doc: commands changed in testpmd_funcs for 2tuple amd 5tuple filter >=20 > app/test-pmd/cmdline.c | 406 ++++++------- > app/test-pmd/config.c | 65 --- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 99 +--- > lib/librte_ether/rte_eth_ctrl.h | 57 ++ > lib/librte_ether/rte_ethdev.c | 116 ---- > lib/librte_ether/rte_ethdev.h | 192 ------ > lib/librte_pmd_e1000/e1000_ethdev.h | 69 ++- > lib/librte_pmd_e1000/igb_ethdev.c | 869 +++++++++++++++++++---= --- > --- > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 468 +++++++++++---- > lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 52 +- > 10 files changed, 1300 insertions(+), 1093 deletions(-) >=20 > -- > 1.9.3 Acked-by: Pablo de Lara Just mind that the last patch (changing the documentation) does not apply p= roperly, as there was another patch (from you I think), that modifies that document= . Could you send another version of the last patch?=20 Not sure if that's OK or if it is better to send the full patchset again. =20