From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 78EEB5A9B for ; Sat, 7 Mar 2015 22:38:30 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 07 Mar 2015 13:33:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,359,1422950400"; d="scan'208";a="464060570" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by FMSMGA003.fm.intel.com with ESMTP; 07 Mar 2015 13:31:58 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.218]) by IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0195.001; Sat, 7 Mar 2015 21:38:28 +0000 From: "De Lara Guarch, Pablo" To: Takuya ASADA , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] virtio: Add default_txconf Thread-Index: AQHQTz2cVU3Sf4YSTEe2VISy2nJcwp0RnmjA Date: Sat, 7 Mar 2015 21:38:27 +0000 Message-ID: References: <1424677885-24171-1-git-send-email-syuu@cloudius-systems.com> In-Reply-To: <1424677885-24171-1-git-send-email-syuu@cloudius-systems.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] virtio: Add default_txconf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Mar 2015 21:38:30 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Takuya ASADA > Sent: Monday, February 23, 2015 7:51 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] virtio: Add default_txconf >=20 > When I tried to launch test-pmd on KVM guest of Fedora21, I got following > error: >=20 > Configuring Port 0 (socket 0) > Fail to configure port 0 tx queues > EAL: Error - exiting with code: 1 > Cause: Start ports failed >=20 > I found that the error caused here, and actual error message was "TX > checksum offload not supported": > http://dpdk.org/browse/dpdk/tree/lib/librte_pmd_virtio/virtio_rxtx.c#n425 >=20 > This patch adds default_txconf on virtio pmd, to avoid the error. >=20 > Signed-off-by: Takuya ASADA > --- > lib/librte_pmd_virtio/virtio_ethdev.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c > b/lib/librte_pmd_virtio/virtio_ethdev.c > index b3b5bb6..9c183bb 100644 > --- a/lib/librte_pmd_virtio/virtio_ethdev.c > +++ b/lib/librte_pmd_virtio/virtio_ethdev.c > @@ -1188,6 +1188,9 @@ virtio_dev_info_get(struct rte_eth_dev *dev, > struct rte_eth_dev_info *dev_info) > dev_info->min_rx_bufsize =3D VIRTIO_MIN_RX_BUFSIZE; > dev_info->max_rx_pktlen =3D VIRTIO_MAX_RX_PKTLEN; > dev_info->max_mac_addrs =3D VIRTIO_MAX_MAC_ADDRS; > + dev_info->default_txconf =3D (struct rte_eth_txconf) { > + .txq_flags =3D ETH_TXQ_FLAGS_NOOFFLOADS > + }; > } >=20 > /* > -- > 2.1.0 Acked-by: Pablo de Lara