From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C17E7379E for ; Wed, 25 Mar 2015 13:34:46 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 25 Mar 2015 05:34:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,465,1422950400"; d="scan'208";a="546075396" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga003.jf.intel.com with ESMTP; 25 Mar 2015 05:34:46 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.49]) by irsmsx105.ger.corp.intel.com ([163.33.3.28]) with mapi id 14.03.0224.002; Wed, 25 Mar 2015 12:34:44 +0000 From: "De Lara Guarch, Pablo" To: Thomas Monjalon , "Qiu, Michael" Thread-Topic: [dpdk-dev] [PATCH] testpmd: Fix wrong message when no port started Thread-Index: AQHQP4zGKTSmX/ZsY0yiwjXwppqLzJ0qYi4AgAMEJEA= Date: Wed, 25 Mar 2015 12:34:43 +0000 Message-ID: References: <1422952659-21557-1-git-send-email-michael.qiu@intel.com> <3096315.kVbCiLpmZB@xps13> In-Reply-To: <3096315.kVbCiLpmZB@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] testpmd: Fix wrong message when no port started X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Mar 2015 12:34:47 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, March 23, 2015 1:53 PM > To: Qiu, Michael; De Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] testpmd: Fix wrong message when no port > started >=20 > Pablo, what is your opinion on this patch? Sorry for the delay, I missed this email. >=20 > 2015-02-03 16:37, Michael Qiu: > > The log message is wrong when no port started. > > > > Signed-off-by: Michael Qiu > > --- > > app/test-pmd/testpmd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > > index 773b8af..ebf9448 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -1423,7 +1423,7 @@ start_port(portid_t pid) > > if (need_check_link_status && !no_link_check) > > check_all_ports_link_status(nb_ports, RTE_PORT_ALL); > > else > > - printf("Please stop the ports first\n"); > > + printf("Please start at least one port first\n"); >=20 > Why the word "first"? > What could lead to this situation? Wrong pid? > Shouldn't be an error returned? I see no reason why we should change this. Code has changed since, so now it only goes there if user is trying to star= t a port that has been already started. If pid is wrong, it will show "Port invalid". So, in a summary, NACK. Thanks, Pablo >=20 > > > > printf("Done\n"); > > return 0; >=20