From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 65998FE5
 for <dev@dpdk.org>; Tue,  5 May 2015 16:07:54 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga103.fm.intel.com with ESMTP; 05 May 2015 07:07:53 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,372,1427785200"; d="scan'208";a="720978073"
Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25])
 by fmsmga002.fm.intel.com with ESMTP; 05 May 2015 07:07:52 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.246]) by
 irsmsx110.ger.corp.intel.com ([169.254.15.5]) with mapi id 14.03.0224.002;
 Tue, 5 May 2015 15:07:52 +0100
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2] kni: fix compilation issue in KNI vhost
 on	kernel 3.19/4.0
Thread-Index: AQHQhzAaZXOx5CP+PUSpTIgqKI4Zwp1taxnw
Date: Tue, 5 May 2015 14:07:51 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8972729A4CE@IRSMSX108.ger.corp.intel.com>
References: <1430775963-29444-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1430829319-22242-1-git-send-email-pablo.de.lara.guarch@intel.com>
In-Reply-To: <1430829319-22242-1-git-send-email-pablo.de.lara.guarch@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] kni: fix compilation issue in KNI vhost
 on	kernel 3.19/4.0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 05 May 2015 14:07:54 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Tuesday, May 05, 2015 1:35 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] kni: fix compilation issue in KNI vhost on
> kernel 3.19/4.0
>=20
> Due to commit c0371da6 in kernel 3.19, which removed msg_iov
> and msg_iovlen from struct msghdr, DPDK would not build.
> Also, functions memcpy_toiovecend and memcpy_fromiovecend
> were removed in commits ba7438ae and 57dd8a07, being substituted by
> copy_from_iter and copy_to_iter.
>=20
> This patch makes use of struct iov_iter, which has references
> to msg_iov and msg_iovln, and makes use of copy_from_iter
> and copy_to_iter.
>=20
> Reported-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Self-NACK again. Missing checks and wrong variable names.