From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4F6F9C3CE for ; Thu, 25 Jun 2015 23:56:52 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 25 Jun 2015 14:56:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,680,1427785200"; d="scan'208";a="514340638" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by FMSMGA003.fm.intel.com with ESMTP; 25 Jun 2015 14:56:50 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.201]) by IRSMSX101.ger.corp.intel.com ([169.254.1.201]) with mapi id 14.03.0224.002; Thu, 25 Jun 2015 22:56:49 +0100 From: "De Lara Guarch, Pablo" To: Miguel Bernal Marin , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/2] kni: fix build with kernel 4.1 Thread-Index: AQHQr3qqR1gxEWFbwky7VcoGbeoClZ29w5ug Date: Thu, 25 Jun 2015 21:56:48 +0000 Message-ID: References: <1435259380-26251-1-git-send-email-miguel.bernal.marin@linux.intel.com> In-Reply-To: <1435259380-26251-1-git-send-email-miguel.bernal.marin@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/2] kni: fix build with kernel 4.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2015 21:56:52 -0000 Hi Miguel, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Miguel Bernal > Marin > Sent: Thursday, June 25, 2015 8:10 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 0/2] kni: fix build with kernel 4.1 >=20 > Due to API changes in netdevice.h in 4.1 kernel release, KNI modules > would not build. This patch set adds the properly checks to fix > compilation. >=20 > Miguel Bernal Marin (2): > kni: fix igb_ndo_bridge_getlink in 4.1 > kni: fix header_ops in 4.1 >=20 > lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c | 10 ++++++++++ > lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 5 +++++ > lib/librte_eal/linuxapp/kni/kni_net.c | 4 ++++ > 3 files changed, 19 insertions(+) >=20 > -- > 2.3.3 I have tested your fix and it works for kernel 4.1, but I get and error if = CONFIG_RTE_KNI_VHOST=3Dy: CC [M] /root/dpdk-latest/x86_64-native-linuxapp-gcc/build/lib/librte_eal= /linuxapp/kni/kni_vhost.o /root/dpdk-latest/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/= kni/kni_vhost.c:593:2: error: initialization from incompatible pointer type= [-Werror] .sendmsg =3D kni_sock_sndmsg, ^ /root/dpdk-latest/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/= kni/kni_vhost.c:593:2: error: (near initialization for 'kni_socket_ops.send= msg') [-Werror] /root/dpdk-latest/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/= kni/kni_vhost.c:594:2: error: initialization from incompatible pointer type= [-Werror] .recvmsg =3D kni_sock_rcvmsg, ^ /root/dpdk-latest/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/= kni/kni_vhost.c:594:2: error: (near initialization for 'kni_socket_ops.recv= msg') [-Werror] cc1: all warnings being treated as errors /home/kernel_test/kernels_rc/linux-4.1/scripts/Makefile.build:258: recipe f= or target '/root/dpdk-latest/x86_64-native-linuxapp-gcc/build/lib/librte_ea= l/linuxapp/kni/kni_vhost.o' failed make[10]: *** [/root/dpdk-latest/x86_64-native-linuxapp-gcc/build/lib/librt= e_eal/linuxapp/kni/kni_vhost.o] Error 1 /home/kernel_test/kernels_rc/linux-4.1/Makefile:1383: recipe for target '_m= odule_/root/dpdk-latest/x86_64-native-linuxapp-gcc/build/lib/librte_eal/lin= uxapp/kni' failed The fix for this is to remove struct socket *sock from kni_sock_sndmsg and= kni_sock_rcvmsg in kni_vhost.c. Could you send a v2 with this fix as well? Thanks for this, Pablo