From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6FDB511A4 for ; Wed, 22 Jul 2015 10:02:58 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 22 Jul 2015 01:02:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,522,1432623600"; d="scan'208";a="610585243" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga003.jf.intel.com with ESMTP; 22 Jul 2015 01:02:57 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.201]) by IRSMSX104.ger.corp.intel.com ([169.254.5.171]) with mapi id 14.03.0224.002; Wed, 22 Jul 2015 09:02:55 +0100 From: "De Lara Guarch, Pablo" To: "Lu, Wenzhuo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] testpmd: fix wrong variable type in ieee1588fwd for 32 bits Thread-Index: AQHQxEkdsEOElEy5AkyKd2lSFt4v+J3nBgQAgAAa5CA= Date: Wed, 22 Jul 2015 08:02:55 +0000 Message-ID: References: <1437547118-28633-1-git-send-email-pablo.de.lara.guarch@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC0909CFBE1F@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909CFBE1F@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] testpmd: fix wrong variable type in ieee1588fwd for 32 bits X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2015 08:03:00 -0000 Hi, > -----Original Message----- > From: Lu, Wenzhuo > Sent: Wednesday, July 22, 2015 8:26 AM > To: De Lara Guarch, Pablo; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] testpmd: fix wrong variable type in > ieee1588fwd for 32 bits >=20 > Hi Pablo, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > > Sent: Wednesday, July 22, 2015 2:39 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH] testpmd: fix wrong variable type in > ieee1588fwd for > > 32 bits > > > > In ieee1588fwd.c, timestamp.tv_sec is a size_t variable, which is a lon= g int, > but it > I think you mean time_t :) Yes, sorry! Will send a v2. Thanks! Pablo >=20 > > was being printed with PRIu64, causing an issue on 32 bits. > > > > Signed-off-by: Pablo de Lara > > --- > > app/test-pmd/ieee1588fwd.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/app/test-pmd/ieee1588fwd.c b/app/test-pmd/ieee1588fwd.c > index > > 069ee2e..b1a301b 100644 > > --- a/app/test-pmd/ieee1588fwd.c > > +++ b/app/test-pmd/ieee1588fwd.c > > @@ -89,7 +89,7 @@ port_ieee1588_rx_timestamp_check(portid_t pi, > uint32_t > > index) > > (unsigned) pi); > > return; > > } > > - printf("Port %u RX timestamp value %"PRIu64"\n", > > + printf("Port %u RX timestamp value %lu\n", > > (unsigned) pi, timestamp.tv_sec); } > > > > @@ -112,7 +112,7 @@ port_ieee1588_tx_timestamp_check(portid_t pi) > > (unsigned) pi, (unsigned) > > MAX_TX_TMST_WAIT_MICROSECS); > > return; > > } > > - printf("Port %u TX timestamp value %"PRIu64" validated after " > > + printf("Port %u TX timestamp value %lu validated after " > > "%u micro-second%s\n", > > (unsigned) pi, timestamp.tv_sec, wait_us, > > (wait_us =3D=3D 1) ? "" : "s"); > > -- > > 2.4.2