From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 969663195 for ; Thu, 17 Sep 2015 10:33:30 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 17 Sep 2015 01:33:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,545,1437462000"; d="scan'208";a="806408847" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga002.jf.intel.com with ESMTP; 17 Sep 2015 01:33:27 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.107]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0248.002; Thu, 17 Sep 2015 09:32:00 +0100 From: "De Lara Guarch, Pablo" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data Thread-Index: AQHQ8JyPTDiSbJydYEyutbVbg0T2S54/qVSggACYNoCAACIZQA== Date: Thu, 17 Sep 2015 08:31:59 +0000 Message-ID: References: <1442402465-20158-1-git-send-email-pablo.de.lara.guarch@intel.com> <2601191342CEEE43887BDE71AB97725836A870DF@irsmsx105.ger.corp.intel.com> <1926548.3ArlD1O00b@xps13> In-Reply-To: <1926548.3ArlD1O00b@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2015 08:33:34 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, September 17, 2015 8:24 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Ananyev, Konstantin > Subject: Re: [dpdk-dev] [PATCH] ethdev: add new RX/TX queue state arrays > in rte_eth_dev_data >=20 > 2015-09-16 21:22, De Lara Guarch, Pablo: > > From: Ananyev, Konstantin > > > Why not something like: > > > ret =3D dev->dev_ops->tx_queue_start(dev, tx_queue_id); > > > if (ret =3D=3D 0) > > > dev->data->tx_queue_state[tx_queue_id] =3D > > > RTE_ETH_QUEUE_STATE_START; > > > > > > Same for dev_stop and RX. > > > Then you hopefully wouldn't need to update each and every PMD, > > > only rteh_ethdev* would be affected. > > > > Problem is that some PMDs call internally queue_start/stop, but not the > generic rte_eth_rx_queue_start (stop and RX), > > so in that case this would not update the state of the queue. >=20 > Why not changing PMD to call rte_eth_rx_queue_start? Do you think it will > be > too much error prone for later updates? I thought PMDs didn't call API from rte_ethdev. In fact, that function need= s a port id, which is not available in the PMD functions usually. Well, port id can be available in this case since the queues have it as a f= ield, but I see it as a worse solution, as it would be inconsistent with the way PMDs work, IMO. Thanks, Pablo