From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 7049F5938
 for <dev@dpdk.org>; Fri, 30 Oct 2015 12:33:25 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga103.jf.intel.com with ESMTP; 30 Oct 2015 04:33:24 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,217,1444719600"; d="scan'208";a="823076915"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by fmsmga001.fm.intel.com with ESMTP; 30 Oct 2015 04:33:23 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.138]) by
 IRSMSX101.ger.corp.intel.com ([169.254.1.33]) with mapi id 14.03.0248.002;
 Fri, 30 Oct 2015 11:33:21 +0000
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Mrzyglod, DanielX
 T" <danielx.t.mrzyglod@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2 4/6] i40e: add additional ieee1588
 support	functions
Thread-Index: AQHREwToaYctyqeMBU+8JM3apaxTFZ6D5n6Q
Date: Fri, 30 Oct 2015 11:33:20 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C8409A2@IRSMSX108.ger.corp.intel.com>
References: <1443799208-9408-1-git-send-email-danielx.t.mrzyglod@intel.com>
 <1446198204-9852-1-git-send-email-danielx.t.mrzyglod@intel.com>
 <1446198204-9852-5-git-send-email-danielx.t.mrzyglod@intel.com>
 <2601191342CEEE43887BDE71AB97725836AB6EC2@irsmsx105.ger.corp.intel.com>
In-Reply-To: <2601191342CEEE43887BDE71AB97725836AB6EC2@irsmsx105.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 4/6] i40e: add additional
	ieee1588	support	functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Oct 2015 11:33:26 -0000

Hi Konstantin,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ananyev,
> Konstantin
> Sent: Friday, October 30, 2015 11:20 AM
> To: Mrzyglod, DanielX T; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 4/6] i40e: add additional ieee1588 supp=
ort
> functions
>=20
> Hi Daniel,
>=20
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Daniel Mrzyglod
> > Sent: Friday, October 30, 2015 9:43 AM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2 4/6] i40e: add additional ieee1588 suppor=
t
> functions
> >
> > From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >
> > Add additional functions to support the existing IEEE1588
> > functionality and to enable getting, setting and adjusting
> > the device time.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>

[...]

>=20
> These 3 functions above are redefined for each PMD in your patch.
> I think it is worth to move it to the upper layer (rte_ethdev, rte_net) t=
o avoid
> code duplication.
> Thanks
> Kinstantin

We thought about that, but we didn't know what the best place was for them.
Looking at the functions in rte_ethdev, they look quite different compared =
to these ones,
so we thought it wasn't the appropriate place. Do you think that is the bes=
t place?

Thanks,
Pablo