From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 6C684E72 for ; Fri, 6 Nov 2015 09:12:35 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 06 Nov 2015 00:12:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,251,1444719600"; d="scan'208";a="679516458" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga003.jf.intel.com with ESMTP; 06 Nov 2015 00:12:33 -0800 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX151.ger.corp.intel.com (163.33.192.59) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 6 Nov 2015 08:11:30 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.138]) by irsmsx155.ger.corp.intel.com ([169.254.14.150]) with mapi id 14.03.0248.002; Fri, 6 Nov 2015 08:11:29 +0000 From: "De Lara Guarch, Pablo" To: "Zhang, Helin" , "dev@dpdk.org" Thread-Topic: [PATCH 2/3] i40e: fix ICC compile issue Thread-Index: AQHRGGeYLMdM+tQn/0OhfWHFGpJZTZ6OpBIQ Date: Fri, 6 Nov 2015 08:11:29 +0000 Message-ID: References: <1446796116-1219-1-git-send-email-helin.zhang@intel.com> <1446796116-1219-3-git-send-email-helin.zhang@intel.com> In-Reply-To: <1446796116-1219-3-git-send-email-helin.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/3] i40e: fix ICC compile issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2015 08:12:35 -0000 Hi Helin, > -----Original Message----- > From: Zhang, Helin > Sent: Friday, November 06, 2015 7:49 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; Zhang, Helin > Subject: [PATCH 2/3] i40e: fix ICC compile issue >=20 > It fixes compile issue on ICC 13.0.0. >=20 > Error logs: > i40e_ethdev.c(7943): error #188: enumerated type mixed with another type > PMD_INIT_LOG(ERR, >=20 > Signed-off-by: Helin Zhang > --- > drivers/net/i40e/i40e_ethdev.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index ddf3d38..8c1809a 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -7942,7 +7942,7 @@ i40e_vsi_get_bw_info(struct i40e_vsi *vsi) > if (ret) { > PMD_INIT_LOG(ERR, > "couldn't get PF vsi bw config, err %s aq_err %s\n", > - i40e_stat_str(hw, ret), > + i40e_stat_str(hw, (enum i40e_status_code)ret), > i40e_aq_str(hw, hw->aq.asq_last_status)); > return -EINVAL; > } > @@ -7953,7 +7953,7 @@ i40e_vsi_get_bw_info(struct i40e_vsi *vsi) > if (ret) { > PMD_INIT_LOG(ERR, > "couldn't get PF vsi ets bw config, err %s aq_err > %s\n", > - i40e_stat_str(hw, ret), > + i40e_stat_str(hw, (enum i40e_status_code)ret), > i40e_aq_str(hw, hw->aq.asq_last_status)); > return -EINVAL; > } > @@ -8122,7 +8122,7 @@ i40e_vsi_config_tc(struct i40e_vsi *vsi, u8 tc_map) > if (ret) { > PMD_INIT_LOG(ERR, > "Failed updating vsi bw info, err %s aq_err %s", > - i40e_stat_str(hw, ret), > + i40e_stat_str(hw, (enum i40e_status_code)ret), > i40e_aq_str(hw, hw->aq.asq_last_status)); > goto out; > } > @@ -8173,9 +8173,9 @@ i40e_dcb_hw_configure(struct i40e_pf *pf, > if (ret) { > PMD_INIT_LOG(ERR, > "Set DCB Config failed, err %s aq_err %s\n", > - i40e_stat_str(hw, ret), > + i40e_stat_str(hw, (enum i40e_status_code)ret), > i40e_aq_str(hw, hw->aq.asq_last_status)); > - return ret; > + return (enum i40e_status_code)ret; > } > /* set receive Arbiter to RR mode and ETS scheme by default */ > for (i =3D 0; i <=3D I40E_PRTDCB_RETSTCC_MAX_INDEX; i++) { > -- > 1.8.1.4 I think it is best to change the variable type, instead of casting, since i40e_aq_query_vsi_bw_config for instance is returning a enum i40e_sta= tus_code and not an int. Thanks, Pablo