From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2CEE3532D for ; Mon, 9 Nov 2015 15:06:09 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 09 Nov 2015 06:06:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,266,1444719600"; d="scan'208";a="596898859" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by FMSMGA003.fm.intel.com with ESMTP; 09 Nov 2015 06:06:06 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.23]) by IRSMSX103.ger.corp.intel.com ([169.254.3.13]) with mapi id 14.03.0248.002; Mon, 9 Nov 2015 14:06:05 +0000 From: "De Lara Guarch, Pablo" To: "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCHv5 1/2] testpmd: add ability to split outgoing packets Thread-Index: AQHRGtAGcUGnIw35dEGqEFZEhmr+5Z6TsQKAgAADEoCAAAUJMA== Date: Mon, 9 Nov 2015 14:06:05 +0000 Message-ID: References: <1447060816-9923-1-git-send-email-konstantin.ananyev@intel.com> <1447060816-9923-2-git-send-email-konstantin.ananyev@intel.com> <2601191342CEEE43887BDE71AB97725836AC61B0@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725836AC61B0@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCHv5 1/2] testpmd: add ability to split outgoing packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2015 14:06:10 -0000 > -----Original Message----- > From: Ananyev, Konstantin > Sent: Monday, November 09, 2015 1:45 PM > To: De Lara Guarch, Pablo; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCHv5 1/2] testpmd: add ability to split outgo= ing > packets >=20 >=20 >=20 > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Monday, November 09, 2015 1:39 PM > > To: Ananyev, Konstantin; dev@dpdk.org > > Subject: RE: [dpdk-dev] [PATCHv5 1/2] testpmd: add ability to split > outgoing packets > > > > Hi Konstantin, > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Konstantin > > > Ananyev > > > Sent: Monday, November 09, 2015 9:20 AM > > > To: dev@dpdk.org > > > Subject: [dpdk-dev] [PATCHv5 1/2] testpmd: add ability to split outgo= ing > > > packets > > > > > > For CSUM forwarding mode add ability to copy & split outgoing packet > > > into the new mbuf that consists of multiple segments. > > > For TXONLY and CSUM forwarding modes add ability to make number of > > > segments in the outgoing packet to vary on a per packet basis. > > > Number of segments and size of each segment is controlled by > > > 'set txpkts' command. > > > Split policy is controlled by 'set txsplit' command. > > > Possible values are: on | off | rand. > > > Tha allows to increase test coverage for TX PMD codepaths. > > > > > > Signed-off-by: Konstantin Ananyev > > > --- > > > app/test-pmd/cmdline.c | 57 +++++++++- > > > app/test-pmd/config.c | 61 +++++++++++ > > > app/test-pmd/csumonly.c | 163 > > > +++++++++++++++++++++++++++- > > > app/test-pmd/testpmd.c | 3 + > > > app/test-pmd/testpmd.h | 10 ++ > > > app/test-pmd/txonly.c | 13 ++- > > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 11 +- > > > 7 files changed, 309 insertions(+), 9 deletions(-) > > > > > > > [...] > > > > > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > index 4fb1e0b..4608b3f 100644 > > > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > @@ -211,7 +211,7 @@ show config > > > Displays the configuration of the application. > > > The configuration comes from the command-line, the runtime or the > > > application defaults:: > > > > > > - testpmd> show config (rxtx|cores|fwd) > > > + testpmd> show config (rxtx|cores|fwd|txpkts) > > > > > > The available information categories are: > > > > > > @@ -221,6 +221,8 @@ The available information categories are: > > > > > > * ``fwd``: Packet forwarding configuration. > > > > > > +* ``txpkts``: Packets to TX configuration. > > > + > > > For example: > > > > > > .. code-block:: console > > > @@ -396,6 +398,13 @@ Set the length of each segment of the TX-ONLY > > > packets:: > > > > > > Where x[,y]* represents a CSV list of values, without white space. > > > > > > +set txsplit > > > +~~~~~~~~~~~ > > > + > > > +Set the length of each segment of the TX packets, applicable for TX- > ONLY > > > and CSUM forwarding modes:: > > > + > > > + testpmd> set txsplit (off|on|rand) > > > + > > > set corelist > > > ~~~~~~~~~~~~ > > > > > > -- > > > 1.8.5.3 > > > > Description of "set txsplit" does not look correct. Could you fix it? >=20 > Ups, sure will fix it. >=20 > > It would be nice to describe the three different options (off, on, rand= ) as > well. >=20 > Ok, will do. > Any other comments before I'll re-spin it? Just a typo ("packts") in config.c + tx_pkt_split tx_pkt_split =3D TX_PKT_SPLIT_OFF; + /**< Split policy for packts to TX. */ > Thanks > Konstantin >=20 >=20 > > > > Thanks, > > Pablo