From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B24423772 for ; Tue, 10 Nov 2015 17:12:28 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 10 Nov 2015 08:10:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,271,1444719600"; d="scan'208";a="847649609" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga002.fm.intel.com with ESMTP; 10 Nov 2015 08:10:39 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.23]) by irsmsx110.ger.corp.intel.com ([169.254.15.163]) with mapi id 14.03.0248.002; Tue, 10 Nov 2015 16:10:37 +0000 From: "De Lara Guarch, Pablo" To: David Marchand , "dev@dpdk.org" Thread-Topic: [PATCH] app/testpmd: fix icmp echo tx queues Thread-Index: AQHREiZzs/gAjsO9cUqgT8PHHUM7uZ6VgEYw Date: Tue, 10 Nov 2015 16:10:37 +0000 Message-ID: References: <1446108423-14231-1-git-send-email-david.marchand@6wind.com> In-Reply-To: <1446108423-14231-1-git-send-email-david.marchand@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix icmp echo tx queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 16:12:29 -0000 Hi, > -----Original Message----- > From: David Marchand [mailto:david.marchand@6wind.com] > Sent: Thursday, October 29, 2015 8:47 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH] app/testpmd: fix icmp echo tx queues >=20 > icmp echo forward engine relies on the core rank rather than the number o= f > queues available. > This fix is still wrong, because if we set a nb-rxq > nb-txq, then we wil= l use > an invalid txq, but with this, we are aligned on other fwd engines. >=20 > Signed-off-by: David Marchand > --- > app/test-pmd/config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index cf2aa6e..314215c 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -1278,7 +1278,7 @@ icmp_echo_config_setup(void) > fs->rx_port =3D fwd_ports_ids[rxp]; > fs->rx_queue =3D rxq; > fs->tx_port =3D fs->rx_port; > - fs->tx_queue =3D lc_id; > + fs->tx_queue =3D rxq; > fs->peer_addr =3D fs->tx_port; > if (verbose_level > 0) > printf(" stream=3D%d port=3D%d rxq=3D%d > txq=3D%d\n", > -- > 1.9.1 Acked-by: Pablo de Lara