From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8D307ADA2 for ; Fri, 5 Feb 2016 10:20:28 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 05 Feb 2016 01:20:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,399,1449561600"; d="scan'208";a="647613100" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by FMSMGA003.fm.intel.com with ESMTP; 05 Feb 2016 01:20:27 -0800 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by irsmsx105.ger.corp.intel.com (163.33.3.28) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 5 Feb 2016 09:20:26 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.102]) by irsmsx155.ger.corp.intel.com ([169.254.14.217]) with mapi id 14.03.0248.002; Fri, 5 Feb 2016 09:20:26 +0000 From: "De Lara Guarch, Pablo" To: "Wang, Xiao W" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4] testpmd: fix wrong prompt in tx_vlan set command handler Thread-Index: AQHRX9DLUIDINtjHA0qVOJazXwwMYJ8dLRZQ Date: Fri, 5 Feb 2016 09:20:25 +0000 Message-ID: References: <1454647823-26663-1-git-send-email-xiao.w.wang@intel.com> In-Reply-To: <1454647823-26663-1-git-send-email-xiao.w.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGFkZDgyNWEtODJlNS00MzA2LWE1ODEtYzVmM2UwNGE5NTdmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicjZLZmFGZ2lsZUY0cVdrOWZkUGwydktvZ3VjanpLU2RndWRycGozUUtsWT0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] testpmd: fix wrong prompt in tx_vlan set command handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Feb 2016 09:20:29 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wang Xiao W > Sent: Friday, February 05, 2016 4:50 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v4] testpmd: fix wrong prompt in tx_vlan set > command handler >=20 > When using testpmd, sometimes we forget the right order of port_id and > vid in "tx_vlan set (port_id) vlan_id[, vlan_id_outer]\n" command, and > input "tx_vlan set 51 0", we'll get a strange prompt saying "Error, as > QinQ has been enabled.". >=20 > In cmd_tx_vlan_set_parsed function, the first thing we do is checking > the port's vlan_offload capability, rather than checking validity of the > port_id, therefore if it's an invalid port_id we'll get the above wrong > message. We should always make sure that we get a valid port_id before > we do other things. >=20 > It's the similar issue for cmd_tx_vlan_set_qinq_parsed function. >=20 > Fixes: 92ebda07ee58 ("app/testpmd: add qinq stripping and insertion") >=20 > Signed-off-by: Wang Xiao W Acked-by: Pablo de Lara