From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 93C6EC13E
 for <dev@dpdk.org>; Tue, 16 Feb 2016 16:52:48 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP; 16 Feb 2016 07:52:47 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,455,1449561600"; d="scan'208";a="886099239"
Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96])
 by orsmga001.jf.intel.com with ESMTP; 16 Feb 2016 07:52:46 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.102]) by
 IRSMSX154.ger.corp.intel.com ([169.254.12.208]) with mapi id 14.03.0248.002;
 Tue, 16 Feb 2016 15:52:46 +0000
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Griffin, John" <john.griffin@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] qat pmd:Fixing build issue on 32-bit systems
Thread-Index: AQHRaJ7FOUreO9n26UOi9VCRcDj1z58u0PdA
Date: Tue, 16 Feb 2016 15:52:45 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C8A63DE@IRSMSX108.ger.corp.intel.com>
References: <1455615876-29879-1-git-send-email-john.griffin@intel.com>
In-Reply-To: <1455615876-29879-1-git-send-email-john.griffin@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTg1N2FmZjMtYTZmOS00YTI5LWJkMzEtMDI4ZTU3M2YyMGU4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlBocDM3TWZVbFVCblZSS1oyUzdxQ2RvbVBPVGNkSlM0S3prbFpkMWFCelk9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] qat pmd:Fixing build issue on 32-bit systems
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Feb 2016 15:52:49 -0000

Hi John,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John Griffin
> Sent: Tuesday, February 16, 2016 9:45 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] qat pmd:Fixing build issue on 32-bit systems
>=20
> Fixing build issue on 32-bit systems.
> Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices")
>=20
> Signed-off-by: John Griffin <john.griffin@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Could you include the error that you are fixing on this patch?

For example:

drivers/crypto/qat/qat_crypto.c:345:13:=20
error: cast to pointer from integer of different size [-Werror=3Dint-to-poi=
nter-cast]

Also, as a general rule, patch titles start with lowercase and do not inclu=
de the name "issue" if we use "fix".
e.g. (qat: fix build on 32-bit systems).

Apart from this, patch looks OK to me, so you can leave the acknowledgment =
in the v2.

Thanks!
Pablo