From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1EE1337B2 for ; Fri, 19 Feb 2016 16:08:54 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 19 Feb 2016 07:08:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,470,1449561600"; d="scan'208";a="906867092" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2016 07:08:53 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.102]) by IRSMSX106.ger.corp.intel.com ([169.254.8.197]) with mapi id 14.03.0248.002; Fri, 19 Feb 2016 15:08:52 +0000 From: "De Lara Guarch, Pablo" To: Didier Pallard , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 0/2] Fix CRC32c computation Thread-Index: AQHRawTpM30GKCZVR0KYeEPG/sEtr58zdmYA Date: Fri, 19 Feb 2016 15:08:51 +0000 Message-ID: References: <1455010467-4991-1-git-send-email-didier.pallard@6wind.com> <1455879631-18420-1-git-send-email-didier.pallard@6wind.com> In-Reply-To: <1455879631-18420-1-git-send-email-didier.pallard@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2VmOGYwODQtMDhhNS00ODEyLWI5YTMtODA4ODBmYzYxMGM4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkIwNzFkVElqZTRqeUFQWHJ4S1llVlp2YnlYQllpTlZmVDg1TkNscHkybWs9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 0/2] Fix CRC32c computation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2016 15:08:55 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Didier Pallard > Sent: Friday, February 19, 2016 11:00 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 0/2] Fix CRC32c computation >=20 > CRC32c computation is not valid when buffer length is not a multiple of 4 > bytes. > Values returned by rte_hash_crc functions does not match the one > computed by a trivial crc32c implementation. >=20 > First patch fixes crc hash function autotests, to outline the problem. > Second patch fixes CRC32c computation. >=20 > Didier Pallard (2): > test: fix CRC hash function autotest > hash: fix CRC32c computation >=20 > app/test/test_hash_functions.c | 17 +++-- > doc/guides/rel_notes/release_16_04.rst | 5 ++ > lib/librte_hash/rte_crc_arm64.h | 64 +++++++++++++++++ > lib/librte_hash/rte_hash_crc.h | 125 ++++++++++++++++++++++++++-= ---- > -- > 4 files changed, 178 insertions(+), 33 deletions(-) >=20 > -- > 2.1.4 Series-acked-by: Pablo de Lara Not sure if you need to include a "Fixes" line in the commit messages. In the first commit, probably you should, the commit that you are fixing is 6298d2c55ae8 ("app/test: add new functional tests for hash functions"). In the second commit, it is a bit more difficult, as we don't know that the= commit is, that code was integrated a while ago, before 1.2.3, which is the first publ= ic release in dpdk.org. Also, there is a typo "lengthes", in both commit messages. You can leave the ack in both patches. Thanks!!