From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E21EB2BF5 for ; Mon, 21 Mar 2016 10:40:10 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP; 21 Mar 2016 02:40:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,370,1455004800"; d="scan'208";a="70282756" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga004.fm.intel.com with ESMTP; 21 Mar 2016 02:40:09 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 21 Mar 2016 09:40:08 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.13]) by irsmsx112.ger.corp.intel.com ([169.254.1.234]) with mapi id 14.03.0248.002; Mon, 21 Mar 2016 09:40:08 +0000 From: "De Lara Guarch, Pablo" To: "Gonzalez Monroy, Sergio" , "Liu, Yong" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] testpmd: fix build on FreeBSD Thread-Index: AQHRgxNR12iXVdODqEy5h2uNg138i59jnbGAgAAHLoA= Date: Mon, 21 Mar 2016 09:40:07 +0000 Message-ID: References: <1458524684-13539-1-git-send-email-yong.liu@intel.com> <56EFBB35.6080901@intel.com> In-Reply-To: <56EFBB35.6080901@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTQ0MzgwNmItMGYxMy00NmQwLWJkYTAtZWRlNjU2MWE2MDM0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlhvTkdnbGlNK2pMM3g3aTRwakxxMFg0bmN3cUtPV2xrOHduY3Nndmo0amc9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] testpmd: fix build on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2016 09:40:11 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Monday, March 21, 2016 9:13 AM > To: Liu, Yong; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] testpmd: fix build on FreeBSD >=20 > On 21/03/2016 01:44, Marvin Liu wrote: > > Build log: > > /root/dpdk/app/test-pmd/cmdline.c:6687:45: error: no member named > > 's6_addr32' in 'struct in6_addr' > > rte_be_to_cpu_32(res->ip_value.addr.ipv6.s6_addr32[i]); > > > > This is caused by macro "s6_addr32" not defined on FreeBSD. > > > > Signed-off-by: Marvin Liu > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > > index 9d52b8c..51ad23b 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -6684,7 +6684,11 @@ cmd_tunnel_filter_parsed(void *parsed_result, > > int i; > > for (i =3D 0; i < 4; i++) { > > tunnel_filter_conf.ip_addr.ipv6_addr[i] =3D > > +#ifdef RTE_EXEC_ENV_BSDAPP > > + rte_be_to_cpu_32(res- > >ip_value.addr.ipv6.__u6_addr.__u6_addr32[i]); > > +#else > > rte_be_to_cpu_32(res- > >ip_value.addr.ipv6.s6_addr32[i]); > > +#endif >=20 > Why not always use .__u6_addr.__u6_addr32[i] and avoid ifdef? >=20 > Sergio >=20 > > } > > tunnel_filter_conf.ip_type =3D RTE_TUNNEL_IPTYPE_IPV6; > > } Also, can you include the missing "Fixes" line? Thanks, Pablo