From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 556352BFD for ; Wed, 6 Apr 2016 12:11:16 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 06 Apr 2016 03:11:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,447,1455004800"; d="scan'208";a="80044231" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga004.fm.intel.com with ESMTP; 06 Apr 2016 03:11:14 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by irsmsx105.ger.corp.intel.com (163.33.3.28) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 6 Apr 2016 11:11:13 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.13]) by IRSMSX156.ger.corp.intel.com ([169.254.3.132]) with mapi id 14.03.0248.002; Wed, 6 Apr 2016 11:11:13 +0100 From: "De Lara Guarch, Pablo" To: Thomas Monjalon , "Richardson, Bruce" CC: "dev@dpdk.org" , Olivier Matz Thread-Topic: [dpdk-dev] [PATCH v3 0/4] fix creation of duplicate lpm and hash Thread-Index: AQHRjzH1/0YQf1ZyqkS1KeffAXmkvZ97dvMAgAE6oXA= Date: Wed, 6 Apr 2016 10:11:12 +0000 Message-ID: References: <1459841759-23296-1-git-send-email-olivier.matz@6wind.com> <1459857229-9814-1-git-send-email-olivier.matz@6wind.com> <15207929.XBegjfGF8M@xps13> In-Reply-To: <15207929.XBegjfGF8M@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWQzOTU2M2QtMzlkYi00ZTBjLWFiNTAtNTM0OWZlY2I4M2MwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImFScDlYTVdHdTVQd043WDNhK0F3UGN1OHpFYkpsUW84TWtpMUNmYUlIXC9nPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 0/4] fix creation of duplicate lpm and hash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2016 10:11:16 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, April 05, 2016 4:52 PM > To: Richardson, Bruce; De Lara Guarch, Pablo > Cc: dev@dpdk.org; Olivier Matz > Subject: Re: [dpdk-dev] [PATCH v3 0/4] fix creation of duplicate lpm and = hash >=20 > 2016-04-05 13:53, Olivier Matz: > > Seen while trying to fix the func_reentrancy autotest. The > > series addresses several issues: > > > > 1/ Hash and lpm return a pointer to an existing object if the user requ= ests > the > > creation with an already existing name. This look dangerous: when an > object > > is returned, the user does not know if it should be freed or not. > > > > 2/ There is a race condition in cuckoo_hash as the lock is not held in > > rte_hash_create(). We could find some cases where NULL is returned > when the > > object already exists (ex: when rte_ring_create() fails). > > > > 3/ There is a race condition func_reentrancy that can fail even if the = tested > > API behaves correctly. >=20 > Pablo, Bruce, > What do you think of these fixes for 16.04? I was reviewing them yesterday, but couldn't finish in time. I will do now.