From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 812E42931 for ; Thu, 7 Apr 2016 15:15:13 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP; 07 Apr 2016 06:15:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,449,1455004800"; d="scan'208";a="80869089" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga004.fm.intel.com with ESMTP; 07 Apr 2016 06:15:11 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.13]) by IRSMSX107.ger.corp.intel.com ([169.254.10.137]) with mapi id 14.03.0248.002; Thu, 7 Apr 2016 14:15:11 +0100 From: "De Lara Guarch, Pablo" To: "Kulasek, TomaszX" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] app/test: fix array subscript is above array bounds for gcc 4.5 Thread-Index: AQHRkM77kv4rHqaypUCLSGqsFVL1A59+fKUA Date: Thu, 7 Apr 2016 13:15:11 +0000 Message-ID: References: <1460034450-9360-1-git-send-email-tomaszx.kulasek@intel.com> In-Reply-To: <1460034450-9360-1-git-send-email-tomaszx.kulasek@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmZmYmE5NWYtZTMzYS00OGRkLWI3NzctMjk0NjBkOWUwODdhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImJtVWFlek9XUUhaK08zQ0lEYU5sVWtxVTRidDdaTHI0MFdmXC9IaGdaUW44PSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/test: fix array subscript is above array bounds for gcc 4.5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2016 13:15:13 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Kulasek > Sent: Thursday, April 07, 2016 2:07 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] app/test: fix array subscript is above array > bounds for gcc 4.5 >=20 > cc1: warnings being treated as errors > DPDK/app/test/test_cryptodev.c: In function > 'test_snow3g_encrypted_authenti > cation.clone.3': > DPDK/x86_64-ivshmem-linuxapp-gcc/include/rte_memcpy.h:796:14: error: > array > subscript is above array bounds > compilation terminated due to -Wfatal-errors. >=20 >=20 > ROOT OF PROBLEM: > ---------------- >=20 > In lines like: >=20 > rte_memcpy(sym_op->cipher.iv.data, iv, iv_len); >=20 > when "iv" is 64 bytes long array, and "iv_len" is "unsigned int", > compiler tries to evaluate also a code for array size larger than 255 byt= es > long and reports error "array subscript is above array bounds" in line: >=20 > rte_memcpy.h:796 >=20 > rte_mov128((uint8_t *)dst + 128, (const uint8_t *)src + 128); >=20 > caused by evaluation to: >=20 > rte_mov128((uint8_t *)sym_op->cipher.iv.data + 128, (const uint8_t *)= iv > + 128); >=20 > where "iv" is 64 bytes long buffer and "iv + 128" point out of it, gcc 4.= 5. >=20 >=20 > SOLUTION: > --------- >=20 > Using uint8_t as a size of copied block prevents to evaluate in rte_memcp= y > code for size bigger than 255, causing the problem. >=20 >=20 Don't forget to include the "Fixes" line. Thanks, Pablo > Signed-off-by: Tomasz Kulasek > --- > app/test/test_cryptodev.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-)