From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 50EDF3798
 for <dev@dpdk.org>; Thu, 28 Apr 2016 10:53:03 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga101.jf.intel.com with ESMTP; 28 Apr 2016 01:53:01 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,546,1455004800"; d="scan'208";a="693619876"
Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31])
 by FMSMGA003.fm.intel.com with ESMTP; 28 Apr 2016 01:53:01 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.238]) by
 IRSMSX106.ger.corp.intel.com ([169.254.8.172]) with mapi id 14.03.0248.002;
 Thu, 28 Apr 2016 09:53:00 +0100
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "maciej.czekaj@caviumnetworks.com" <maciej.czekaj@caviumnetworks.com>,
 "dev@dpdk.org" <dev@dpdk.org>
CC: "Mcnamara, John" <john.mcnamara@intel.com>
Thread-Topic: [PATCH v2 0/3] testpmd: extend commands for better
 scatter-gather tests
Thread-Index: AQHRnKaRZ6lTc25XzkiSLDy2c+MuVJ+fGAjQ
Date: Thu, 28 Apr 2016 08:52:59 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C912B66@IRSMSX108.ger.corp.intel.com>
References: <1461319098-22632-1-git-send-email-maciej.czekaj@caviumnetworks.com>
 <1461336680-7581-1-git-send-email-maciej.czekaj@caviumnetworks.com>
In-Reply-To: <1461336680-7581-1-git-send-email-maciej.czekaj@caviumnetworks.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTBlNGE4MGItYzkxYi00OWM0LWI3ZmQtMGZhOWViOWRmNDg2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik54VXAwMFV1N1lzckhtWE9mUGw5aWxSMzJhdWc2MHdmXC9ySmVJQ2JFdGhVPSJ9
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 0/3] testpmd: extend commands for better
 scatter-gather tests
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Apr 2016 08:53:03 -0000



> -----Original Message-----
> From: maciej.czekaj@caviumnetworks.com
> [mailto:maciej.czekaj@caviumnetworks.com]
> Sent: Friday, April 22, 2016 3:51 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo; Mcnamara, John; Maciej Czekaj
> Subject: [PATCH v2 0/3] testpmd: extend commands for better scatter-gathe=
r
> tests
>=20
> From: Maciej Czekaj <maciej.czekaj@caviumnetworks.com>
>=20
> v2:
>  - included documentation changes
>  - added value check for "port config all txqflags" as in --tqxflags para=
mater
>=20
> Maciej Czekaj (3):
>   app/testpmd: add "enable-scatter" parameter
>   app/testpmd: extend port config with scatter parameter
>   app/testpmd: support setting up txq_flags value in command line
>=20
>  app/test-pmd/cmdline.c                      | 86 +++++++++++++++++++++++=
++++--
>  app/test-pmd/parameters.c                   |  3 +
>  doc/guides/testpmd_app_ug/run_app.rst       |  4 ++
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst | 20 +++++++
>  4 files changed, 109 insertions(+), 4 deletions(-)
>=20
> --
> 1.9.1

Series-acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Just one comment, maybe we should include some extra info in "show port inf=
o all", like txqflags or scatter mode.