From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9E2D42BB5 for ; Tue, 31 May 2016 13:39:37 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 31 May 2016 04:39:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,395,1459839600"; d="scan'208";a="113366373" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga004.fm.intel.com with ESMTP; 31 May 2016 04:39:35 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.183]) by IRSMSX151.ger.corp.intel.com ([169.254.4.151]) with mapi id 14.03.0248.002; Tue, 31 May 2016 12:39:35 +0100 From: "De Lara Guarch, Pablo" To: "Jain, Deepak K" , "Doherty, Declan" CC: "Jain, Deepak K" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] crypto: fix control issues in aesni pmd Thread-Index: AQHRtQpZIYnuoaUPH0SBrQ53xEwxqJ/S9cKg Date: Tue, 31 May 2016 11:39:34 +0000 Message-ID: References: <1464018398-71742-1-git-send-email-deepak.k.jain@intel.com> In-Reply-To: <1464018398-71742-1-git-send-email-deepak.k.jain@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzc4NTYxZTUtNTMzOC00NzQzLWE5ZmItZjkzNGVmMmI0ZjRiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImViQmxaUnFQZlM0U1IweDFuaTlHSkdwM1ErNkx2ZEdZbUxTbkFBemFpWXM9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto: fix control issues in aesni pmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2016 11:39:38 -0000 Hi Deepak, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Deepak Kumar Jain > Sent: Monday, May 23, 2016 4:47 PM > To: Doherty, Declan > Cc: Jain, Deepak K; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] crypto: fix control issues in aesni pmd >=20 Since this patch is for the AES-NI Multi Buffer PMD, you should change the = title to "aesni_mb: fix...", and of couse without to including then aesni pmd again = :) > From: "Jain, Deepak K" >=20 > Fix the control issues for return value Maybe a more descriptive commit would be something like "Fix wrong indentat= ion for return value", probably applicable for the title too. >=20 > Fixes: 924e84f87306 ("aesni_mb: add driver for multi buffer based crypto"= ) > Coverity ID 126585 Also, take a look at this email and change the commit accordingly, as it fi= xes a Coverity issue: http://dpdk.org/ml/archives/dev/2016-May/039650.html Thanks, Pablo >=20 > Signed-off-by: Deepak Kumar Jain > --- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > index 3415ac1..9c42f88 100644 > --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > @@ -560,7 +560,7 @@ aesni_mb_pmd_enqueue_burst(void *queue_pair, > struct rte_crypto_op **ops, > goto flush_jobs; > else > qp->stats.enqueued_count +=3D processed_jobs; > - return i; > + return i; >=20 > flush_jobs: > /* > -- > 2.5.5