From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 982776C96 for ; Tue, 7 Jun 2016 11:28:08 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 07 Jun 2016 02:28:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,432,1459839600"; d="scan'208";a="715135781" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by FMSMGA003.fm.intel.com with ESMTP; 07 Jun 2016 02:28:06 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX109.ger.corp.intel.com (163.33.3.23) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 7 Jun 2016 10:28:06 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.183]) by irsmsx112.ger.corp.intel.com ([10.108.20.5]) with mapi id 14.03.0248.002; Tue, 7 Jun 2016 10:28:06 +0100 From: "De Lara Guarch, Pablo" To: "Wang, Zhihong" , "dev@dpdk.org" CC: "Ananyev, Konstantin" , "Richardson, Bruce" , "thomas.monjalon@6wind.com" Thread-Topic: [PATCH v2 1/5] testpmd: add retry option Thread-Index: AQHRu/FSRhxagF3r/UKW7uZ96Tw9+Z/dxNRg Date: Tue, 7 Jun 2016 09:28:04 +0000 Message-ID: References: <1462488421-118990-1-git-send-email-zhihong.wang@intel.com> <1464751663-135211-1-git-send-email-zhihong.wang@intel.com> <1464751663-135211-2-git-send-email-zhihong.wang@intel.com> In-Reply-To: <1464751663-135211-2-git-send-email-zhihong.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjYwZmM5MDAtNjQ4Ny00NGYyLTk5ZTUtYzAwY2NlYjg0YWQ2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im9TRW5uYXNvblBXUVNGU2JDRzYxandmdWF3d3hnVE4yOWVSTUkwZEhDcWM9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/5] testpmd: add retry option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2016 09:28:09 -0000 > -----Original Message----- > From: Wang, Zhihong > Sent: Wednesday, June 01, 2016 4:28 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin; Richardson, Bruce; De Lara Guarch, Pablo; > thomas.monjalon@6wind.com; Wang, Zhihong > Subject: [PATCH v2 1/5] testpmd: add retry option >=20 > This patch adds retry option in testpmd to prevent most packet losses. > It can be enabled by "set fwd retry". All modes except rxonly > support this option. >=20 > Adding retry mechanism expands test case coverage to support scenarios > where packet loss affects test results. >=20 >=20 > Signed-off-by: Zhihong Wang ... > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -249,8 +249,10 @@ set fwd >=20 > Set the packet forwarding mode:: >=20 > - testpmd> set fwd (io|mac|mac_retry|macswap|flowgen| \ > - rxonly|txonly|csum|icmpecho) > + testpmd> set fwd (io|mac|macswap|flowgen| \ > + rxonly|txonly|csum|icmpecho) (""|retry) > + > +``retry`` can be specified for forwarding engines except ``rx_only``. >=20 > The available information categories are: >=20 > @@ -260,8 +262,6 @@ The available information categories are: >=20 > * ``mac``: Changes the source and the destination Ethernet addresses of > packets before forwarding them. >=20 > -* ``mac_retry``: Same as "mac" forwarding mode, but includes retries if = the > destination queue is full. > - > * ``macswap``: MAC swap forwarding mode. > Swaps the source and the destination Ethernet addresses of packets bef= ore > forwarding them. >=20 > @@ -392,7 +392,7 @@ Set number of packets per burst:: >=20 > This is equivalent to the ``--burst command-line`` option. >=20 > -In ``mac_retry`` forwarding mode, the transmit delay time and number of > retries can also be set:: > +When retry is enabled, the transmit delay time and number of retries can > also be set:: >=20 > testpmd> set burst tx delay (micrseconds) retry (num) Could you fix the typo "micrseconds" in this patch? =20 >=20 > -- > 2.5.0 Apart from this, Acked-by: Pablo de Lara