From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 9FA969AA7 for ; Tue, 7 Jun 2016 15:17:26 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 07 Jun 2016 06:17:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,433,1459839600"; d="scan'208";a="715233848" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by FMSMGA003.fm.intel.com with ESMTP; 07 Jun 2016 06:17:25 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 7 Jun 2016 14:17:24 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.183]) by irsmsx111.ger.corp.intel.com ([169.254.2.182]) with mapi id 14.03.0248.002; Tue, 7 Jun 2016 14:17:24 +0100 From: "De Lara Guarch, Pablo" To: "Gonzalez Monroy, Sergio" , "dev@dpdk.org" CC: "Mcnamara, John" Thread-Topic: [dpdk-dev] [PATCH v2 5/9] examples/ipsec-secgw: fix no sa found case Thread-Index: AQHRsQLicIgTNN0OwkihQSEQpV2sQJ/eGztg Date: Tue, 7 Jun 2016 13:17:23 +0000 Message-ID: References: <1462552302-5852-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1463575330-8467-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1463575330-8467-6-git-send-email-sergio.gonzalez.monroy@intel.com> In-Reply-To: <1463575330-8467-6-git-send-email-sergio.gonzalez.monroy@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzViY2NmNjAtYzBhZi00ZTY5LWFlZDEtNDcyZjY4M2JmMzJmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlpFQnlWOUFpS3hGM2hDS2tLK042dG9PNzBXaVdyWVRHNVpwNnZjaWJ4RkE9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 5/9] examples/ipsec-secgw: fix no sa found case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2016 13:17:27 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Wednesday, May 18, 2016 1:42 PM > To: dev@dpdk.org > Cc: Mcnamara, John > Subject: [dpdk-dev] [PATCH v2 5/9] examples/ipsec-secgw: fix no sa found > case >=20 > The application only checks that an SA shoudln't be NULL through ASSERT Typo here: "a SA should not be" > (only when debugging is enabled) without properly dealing with the case > of not having an SA for the processed packet. >=20 > If no SA is found, drop the packet. >=20 > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application"= ) >=20 > Signed-off-by: Sergio Gonzalez Monroy