From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id A1E06567B for ; Mon, 13 Jun 2016 17:57:57 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 13 Jun 2016 08:57:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,466,1459839600"; d="scan'208";a="718344269" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by FMSMGA003.fm.intel.com with ESMTP; 13 Jun 2016 08:57:31 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX151.ger.corp.intel.com (163.33.192.59) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 13 Jun 2016 16:57:30 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.183]) by irsmsx155.ger.corp.intel.com ([169.254.14.34]) with mapi id 14.03.0248.002; Mon, 13 Jun 2016 16:57:30 +0100 From: "De Lara Guarch, Pablo" To: "Iremonger, Bernard" , "dev@dpdk.org" Thread-Topic: [PATCH v3 4/9] app/testpmd: remove fwd_config_setup from fwd_config_display Thread-Index: AQHRxL5jvIKd/gG4z0+f3ESaOKr2Tp/ni/Hg Date: Mon, 13 Jun 2016 15:57:30 +0000 Message-ID: References: <1462462795-18767-1-git-send-email-bernard.iremonger@intel.com> <1465744997-15487-1-git-send-email-bernard.iremonger@intel.com> <1465744997-15487-5-git-send-email-bernard.iremonger@intel.com> In-Reply-To: <1465744997-15487-5-git-send-email-bernard.iremonger@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTkyM2I3MDAtMDhjNi00NTM4LWI1MGMtYmMyZTY2OTlhMmRlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlZZb1wvTHM2N2dySnZndlhUUXN1TDZXVDQ2NHgrZlh4dlE4dzJMT0tVNjdvPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 4/9] app/testpmd: remove fwd_config_setup from fwd_config_display X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2016 15:57:58 -0000 Hi Bernard, > -----Original Message----- > From: Iremonger, Bernard > Sent: Sunday, June 12, 2016 4:23 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; Iremonger, Bernard > Subject: [PATCH v3 4/9] app/testpmd: remove fwd_config_setup from > fwd_config_display >=20 > Remove fwd_config_setup from fwd_config_display and check that > forwarding has been setup before displaying forwarding configuration. > Add call to fwd_config_setup for corelist, coremask, nbcore setup. > Add call to fwd_config_setup for portlist, portmask, nbport setup. Probably we need to add that call to the commands that change number of RX/= TX queues, as well. >=20 > Signed-off-by: Bernard Iremonger > --- > app/test-pmd/cmdline.c | 23 ++++++++++++++++------- > app/test-pmd/config.c | 6 ++++-- > 2 files changed, 20 insertions(+), 9 deletions(-) >=20 [...] > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -1424,8 +1424,10 @@ pkt_fwd_config_display(struct fwd_config *cfg) > void > fwd_config_display(void) > { > - fwd_config_setup(); > - pkt_fwd_config_display(&cur_fwd_config); > + if (cur_fwd_config.nb_fwd_ports) > + pkt_fwd_config_display(&cur_fwd_config); > + else > + printf("Please set portlist first\n"); I think this is not necessary. I would call fwd_config_setup() at startup, so everything is setup when this is called (even if it is the first command= when the prompt comes up). I think at the end of init_config() is a good place. > } >=20 > int > -- > 2.6.3