From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 177828E6A for ; Tue, 14 Jun 2016 17:13:29 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 14 Jun 2016 08:13:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,470,1459839600"; d="scan'208";a="718915001" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by FMSMGA003.fm.intel.com with ESMTP; 14 Jun 2016 08:13:24 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.183]) by IRSMSX152.ger.corp.intel.com ([169.254.6.247]) with mapi id 14.03.0248.002; Tue, 14 Jun 2016 16:13:22 +0100 From: "De Lara Guarch, Pablo" To: "Wang, Zhihong" , "dev@dpdk.org" CC: "Ananyev, Konstantin" , "Richardson, Bruce" , "thomas.monjalon@6wind.com" Thread-Topic: [PATCH v2 5/5] testpmd: show topology at forwarding start Thread-Index: AQHRu/EaedZPW07CHEiripA9wRT/Up/pHXYw Date: Tue, 14 Jun 2016 15:13:21 +0000 Message-ID: References: <1462488421-118990-1-git-send-email-zhihong.wang@intel.com> <1464751663-135211-1-git-send-email-zhihong.wang@intel.com> <1464751663-135211-6-git-send-email-zhihong.wang@intel.com> In-Reply-To: <1464751663-135211-6-git-send-email-zhihong.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjZlMDEzMDktYjMyOS00YzU2LTkwODAtNGU1YTI3ZjE3ZmZmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Iks3eEk2OVZDdDV0WmNIU1FwWFVqVVBaR0JLQzZySjhOXC93dG10OGExTXVVPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 5/5] testpmd: show topology at forwarding start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2016 15:13:30 -0000 Hi Zhihong, > -----Original Message----- > From: Wang, Zhihong > Sent: Wednesday, June 01, 2016 4:28 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin; Richardson, Bruce; De Lara Guarch, Pablo; > thomas.monjalon@6wind.com; Wang, Zhihong > Subject: [PATCH v2 5/5] testpmd: show topology at forwarding start >=20 > This patch show topology at forwarding start. >=20 > "show config fwd" also does this, but showing it directly can reduce the > possibility of misconfiguration. >=20 >=20 > Signed-off-by: Zhihong Wang [...] > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 9b1d99c..b946034 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1009,7 +1009,7 @@ start_packet_forwarding(int with_tx_first) > if(!no_flush_rx) > flush_fwd_rx_queues(); >=20 > - fwd_config_setup(); > + fwd_config_setup_display(); Bernard has made a patch that separates the display and setup of the config= uration, (http://dpdk.org/dev/patchwork/patch/13650/) so fwd_config_display() does not call fwd_config_setup() anymore. Could you modify this patch, so you call fwd_config_setup() and fwd_config_= display()? Sorry for the confusion, Pablo > rxtx_config_display(); >=20 > for (i =3D 0; i < cur_fwd_config.nb_fwd_ports; i++) {