From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id CFA7A8E5E
 for <dev@dpdk.org>; Sat, 25 Jun 2016 17:24:18 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga104.fm.intel.com with ESMTP; 25 Jun 2016 08:24:18 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,527,1459839600"; d="scan'208";a="1009528583"
Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59])
 by fmsmga002.fm.intel.com with ESMTP; 25 Jun 2016 08:24:18 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.183]) by
 IRSMSX151.ger.corp.intel.com ([169.254.4.151]) with mapi id 14.03.0248.002;
 Sat, 25 Jun 2016 16:24:16 +0100
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "Doherty, Declan"
 <declan.doherty@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v2] cryptodev: uninline parameter parsing
Thread-Index: AQHRzuNtes0Wrb3OG0OS9ft93ikKWZ/6SX7g
Date: Sat, 25 Jun 2016 15:24:15 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C96A09B@IRSMSX108.ger.corp.intel.com>
References: <1466783244-4484-1-git-send-email-thomas.monjalon@6wind.com>
 <1466860424-4155-1-git-send-email-thomas.monjalon@6wind.com>
In-Reply-To: <1466860424-4155-1-git-send-email-thomas.monjalon@6wind.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGJlYzkxY2YtNmY0Yy00ZjRlLWIzN2MtYTEzOWYxZDZiOThkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImtEOE4xd3VZcXJLV1FHeER2VzBzSWdpVDFEcGVXKzVqUGdwRkdZemJlMVE9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: uninline parameter parsing
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Jun 2016 15:24:19 -0000

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Saturday, June 25, 2016 2:14 PM
> To: Doherty, Declan; De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: [PATCH v2] cryptodev: uninline parameter parsing
>=20
> There is no need to have this parsing inlined in the header.
> It brings kvargs dependency to every crypto drivers.
> The functions are moved into rte_cryptodev.c.
>=20
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
> v2:
> - remove kvargs dep in null PMD
> - add function in .map file
> ---
>  drivers/crypto/null/Makefile                   |  1 -
>  lib/librte_cryptodev/rte_cryptodev.c           | 91 ++++++++++++++++++++=
++++
>  lib/librte_cryptodev/rte_cryptodev.h           | 95 ++------------------=
------
>  lib/librte_cryptodev/rte_cryptodev_version.map |  7 ++
>  4 files changed, 102 insertions(+), 92 deletions(-)
>=20
> diff --git a/drivers/crypto/null/Makefile b/drivers/crypto/null/Makefile
> index 573894f..35db8b1 100644
> --- a/drivers/crypto/null/Makefile
> +++ b/drivers/crypto/null/Makefile
> @@ -56,6 +56,5 @@ DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO)
> +=3D lib/librte_eal
>  DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) +=3D lib/librte_mbuf
>  DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) +=3D
> lib/librte_cryptodev
>  DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) +=3D lib/librte_ring
> -DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) +=3D lib/librte_kvargs
>=20
>  include $(RTE_SDK)/mk/rte.lib.mk

[...]

>  /**
>   * Create a virtual crypto device
> diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map
> b/lib/librte_cryptodev/rte_cryptodev_version.map
> index 41004e1..a08fd20 100644
> --- a/lib/librte_cryptodev/rte_cryptodev_version.map
> +++ b/lib/librte_cryptodev/rte_cryptodev_version.map
> @@ -32,3 +32,10 @@ DPDK_16.04 {
>=20
>  	local: *;
>  };
> +
> +DPDK_16.07 {
> +	global:
> +
> +	rte_cryptodev_parse_vdev_init_params;

I think this function does not need to be public.
This function is only called in the PMDs, and the only public function
to initialize a crypto device is rte_eal_vdev_init.

> +
> +} DPDK_16.04;
> --
> 2.7.0

Also, could you remove the includes of rte_vargs.h in the PMDs,
as it is not needed (I think it was not necessary before either).