From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6F93158D4 for ; Fri, 8 Jul 2016 11:09:15 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 08 Jul 2016 02:09:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,329,1464678000"; d="scan'208";a="991289631" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga001.jf.intel.com with ESMTP; 08 Jul 2016 02:09:13 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.125]) by irsmsx110.ger.corp.intel.com ([163.33.3.25]) with mapi id 14.03.0248.002; Fri, 8 Jul 2016 10:09:11 +0100 From: "De Lara Guarch, Pablo" To: Neil Horman , "dev@dpdk.org" CC: "Richardson, Bruce" , Thomas Monjalon , Stephen Hemminger , Panu Matilainen Thread-Topic: [PATCH] crypto: normalize cryptodev pmd names with macros Thread-Index: AQHR2GXEj+5/tTpl0kO53K+daAZYH6AOPPlw Date: Fri, 8 Jul 2016 09:09:10 +0000 Message-ID: References: <1467905863-27038-1-git-send-email-nhorman@tuxdriver.com> In-Reply-To: <1467905863-27038-1-git-send-email-nhorman@tuxdriver.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2NhMGY3MTMtNmI3NS00MDkzLWI0MDQtODMwNTM0ODA1YTFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Iko2cjQzNkZJMlY2ckhscE5kUzg0TFlLVmtFR1JUbEh0a2M1bis5emJwUjg9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto: normalize cryptodev pmd names with macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2016 09:09:16 -0000 Hi Neil, > -----Original Message----- > From: Neil Horman [mailto:nhorman@tuxdriver.com] > Sent: Thursday, July 07, 2016 4:38 PM > To: dev@dpdk.org > Cc: Neil Horman; Richardson, Bruce; Thomas Monjalon; De Lara Guarch, > Pablo; Stephen Hemminger; Panu Matilainen > Subject: [PATCH] crypto: normalize cryptodev pmd names with macros >=20 > Recently reported, the introduction of pmd information exports led to a > breakage of cryptodev unit tests because the test infrastructure relies o= n the > cryptodev names being available in macros. This patch fixes the pmd nami= ng > to > use the macro names. Note that the macro names were already pre- > stringified, > which won't work as the PMD_REGISTER_DRIVER macro requires the name in > both a > processing token and stringified form. As such the names are defined now= as > tokens, and converted where needed to stringified form on demand using > RTE_STR. >=20 > Tested using the null and aesni_mb crypto pmds, as I don't have hardware = for > any > other device. Also not build tested on snow3g or kasumi pmd because > building > those requires external libraries that appear to not be open source licen= sed. >=20 > Signed-off-by: Neil Horman > CC: Bruce Richardson > CC: Thomas Monjalon > CC: "De Lara Guarch, Pablo" > CC: Stephen Hemminger > CC: Panu Matilainen > --- > app/test/test_cryptodev.c | 20 ++++++++++------= ---- > app/test/test_cryptodev_perf.c | 18 +++++++++-------= -- > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 7 +++---- > drivers/crypto/aesni_gcm/aesni_gcm_pmd_private.h | 6 +++--- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 7 +++---- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 2 +- > drivers/crypto/kasumi/rte_kasumi_pmd.c | 5 ++--- > drivers/crypto/null/null_crypto_pmd.c | 7 +++---- > drivers/crypto/null/null_crypto_pmd_private.h | 6 +++--- > drivers/crypto/qat/rte_qat_cryptodev.c | 4 ++-- > drivers/crypto/snow3g/rte_snow3g_pmd.c | 4 ++-- > lib/librte_cryptodev/rte_cryptodev.h | 12 ++++++------ > 12 files changed, 47 insertions(+), 51 deletions(-) Thanks for this patch. I tested snow3g and kasumi, and they don't compile. I have a fix for that, so I can send a v2 of this patch if it is OK for you= . Also, we should make these changes in the other PMDs as well, right? I mean, avoid setting the name of the driver directly in the structure and = go back to the original name. I can do that as well, if you want (maybe a separate patch, as this one is = only related to crypto). Thanks, Pablo