From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7088247D1 for ; Fri, 22 Jul 2016 16:15:59 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 22 Jul 2016 07:15:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,405,1464678000"; d="scan'208";a="851294667" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga003.jf.intel.com with ESMTP; 22 Jul 2016 07:15:40 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 22 Jul 2016 15:15:39 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.71]) by IRSMSX156.ger.corp.intel.com ([169.254.3.57]) with mapi id 14.03.0248.002; Fri, 22 Jul 2016 15:15:39 +0100 From: "De Lara Guarch, Pablo" To: "Yigit, Ferruh" , "dev@dpdk.org" , "Mcnamara, John" Thread-Topic: [dpdk-dev] [PATCH] doc: announce driver name changes Thread-Index: AQHR2gLAlSTv1y4zL06qupSmwQ2p4KAkd14Q///0IACAAAbWAIAAHSeQ Date: Fri, 22 Jul 2016 14:15:39 +0000 Message-ID: References: <1468083394-94907-1-git-send-email-pablo.de.lara.guarch@intel.com> <20160722125410.GE9044@6wind.com> <57921D2E.20604@intel.com> In-Reply-To: <57921D2E.20604@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmYwZmJjZGItMmFkYy00ZDNhLThhZTktZDJlM2YyNzQyOTQyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik00RlpjVUZ4a2kwQVlaZHBWQ3pNbko3M3dkUlVHYWZpZHM3anJ5d0ZwUTg9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: announce driver name changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2016 14:16:00 -0000 > -----Original Message----- > From: Yigit, Ferruh > Sent: Friday, July 22, 2016 2:19 PM > To: De Lara Guarch, Pablo; dev@dpdk.org; Mcnamara, John > Subject: Re: [dpdk-dev] [PATCH] doc: announce driver name changes >=20 > On 7/22/2016 1:54 PM, Adrien Mazarguil wrote: > > Hi Pablo, > > > > On Fri, Jul 22, 2016 at 12:37:22PM +0000, De Lara Guarch, Pablo wrote: > >> Hi, > >> > >>> -----Original Message----- > >>> From: De Lara Guarch, Pablo > >>> Sent: Saturday, July 09, 2016 5:57 PM > >>> To: dev@dpdk.org > >>> Cc: Mcnamara, John; De Lara Guarch, Pablo > >>> Subject: [PATCH] doc: announce driver name changes > >>> > >>> Driver names for all the supported devices in DPDK do not have > >>> a naming convention. Some are using a prefix, some are not > >>> and some have long names. Driver names are used when creating > >>> virtual devices, so it is useful to have consistency in the names. > >>> > >>> Signed-off-by: Pablo de Lara > >>> --- > >>> doc/guides/rel_notes/deprecation.rst | 5 +++++ > >>> 1 file changed, 5 insertions(+) > >>> > >>> diff --git a/doc/guides/rel_notes/deprecation.rst > >>> b/doc/guides/rel_notes/deprecation.rst > >>> index f502f86..37d65c8 100644 > >>> --- a/doc/guides/rel_notes/deprecation.rst > >>> +++ b/doc/guides/rel_notes/deprecation.rst > >>> @@ -41,3 +41,8 @@ Deprecation Notices > >>> * The mempool functions for single/multi producer/consumer are > >>> deprecated and > >>> will be removed in 16.11. > >>> It is replaced by rte_mempool_generic_get/put functions. > >>> + > >>> +* Driver names are quite inconsistent among each others and they wil= l > be > >>> + renamed to something more consistent (net_ prefix for net drivers = and > >>> + crypto_ for crypto drivers) in 16.11. Some of these driver names a= re > used > >>> + publicly, to create virtual devices, so a deprecation notice is ne= cessary. > >>> -- > >>> 2.7.4 > >> > >> Any more comments on this (apart from Christian Ehrhardt's)? > > > > Yes, since you're suggesting to prefix driver names, shall "librte_pmd_= mlx5" > > really become "net_librte_pmd_mlx5" or shortened to "net_mlx5" instead? > > > > What about using a '/' separator instead of '_'? > > > > Will this impact directories as well ("net/mlx5" -> "net/net_mlx5")? > > We will leave these untouched, although I don't think renaming the director= ies was necessary. >=20 > For physical net devices, driver name is same as folder name (mlnx5, > ixgbe ...) >=20 > For virtual net devices, driver name is folder name with "eth_" prefix > (eth_pcap, eth_ring) >=20 > Driver names for net devices looks consistent already, I don't know > about crypto devices but if crypto driver names are inconsistent what do > you think renaming crypto drivers only? Sure, as long as virtual Ethernet devices are consistent, I think it is ok. My main intention here was to have consistent (and short) driver names, to call rte_eal_vdev_init (or --vdev in command line). Thanks, Pablo >=20 > Thanks, > ferruh