From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6C7A75589 for ; Fri, 16 Sep 2016 00:52:23 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 15 Sep 2016 15:52:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,341,1470726000"; d="scan'208";a="879592767" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga003.jf.intel.com with ESMTP; 15 Sep 2016 15:52:21 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 15 Sep 2016 23:52:20 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX156.ger.corp.intel.com ([169.254.3.48]) with mapi id 14.03.0248.002; Thu, 15 Sep 2016 23:52:20 +0100 From: "De Lara Guarch, Pablo" To: "Yigit, Ferruh" , "dev@dpdk.org" Thread-Topic: [PATCH] kni: support RHEL 7.3 Thread-Index: AQHSDrVR93aYtImJN0KSWZqfes4CSKB6RUCAgADkVQA= Date: Thu, 15 Sep 2016 22:52:19 +0000 Message-ID: References: <1473877521-2234-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzNlMmE2ZDUtNWM2NC00YWIyLTg4MWUtNWZjZjc0NTU5NGI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlNjNmYwTmlyUjJVNUNJVThyZDFYY255Zis5QWs4YkI5YXhBdmxZcDA0cmc9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] kni: support RHEL 7.3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2016 22:52:23 -0000 > -----Original Message----- > From: Yigit, Ferruh > Sent: Thursday, September 15, 2016 3:13 AM > To: De Lara Guarch, Pablo; dev@dpdk.org > Subject: Re: [PATCH] kni: support RHEL 7.3 >=20 > On 9/14/2016 7:25 PM, Pablo de Lara wrote: > > Add support for RHEL 7.3, which uses kernel 3.10, > > but backported features from newer kernels. > > > > Signed-off-by: Pablo de Lara > > --- > > lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > > index bdd0806..1e20a9e 100644 > > --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > > +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > > @@ -3891,7 +3891,7 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, > __always_unused int type) > > #if (( LINUX_VERSION_CODE >=3D KERNEL_VERSION(3,19,0) ) \ > > || ( RHEL_RELEASE_CODE >=3D RHEL_RELEASE_VERSION(7,2) )) > > #define HAVE_NDO_DFLT_BRIDGE_ADD_MASK > > -#if (!( RHEL_RELEASE_CODE >=3D RHEL_RELEASE_VERSION(7,2) )) > > +#if (!( RHEL_RELEASE_CODE =3D=3D RHEL_RELEASE_VERSION(7,2) )) >=20 > What about following to simplify the logic: > +#if ( RHEL_RELEASE_CODE !=3D RHEL_RELEASE_VERSION(7,2) ) >=20 Good point. Will send a v2 with that :) Thanks, Pablo > Thanks, > ferruh